feat: update exec api to acommodate to last changes in rollkit

[randygrok]

Overview

Summary by CodeRabbit

• Refactor

  • Simplified and consolidated import statements for improved maintainability.
  • Updated the process for creating and passing the DA client, streamlining node startup configuration.

• Chores

  • Removed unused command-line flags related to lazy aggregation mode.

[coderabbitai]

Walkthrough

This change removes two command-line flags related to lazy aggregation mode from the server configuration and updates the DA client instantiation in the node startup logic. The DA client is now created using a consolidated import path and includes an additional namespace parameter.

Changes

File(s)	Change Summary
server/flags.go	Removed two command-line flags: one for enabling lazy aggregator mode and another for block interval.
server/start.go	Simplified DA client imports and instantiation; added namespace parameter to DA client creation.

Sequence Diagram(s)

sequenceDiagram
    participant CLI as CLI Flags
    participant Server as Server
    participant Node as Node
    participant DA as DA Client

    CLI->>Server: Start command (no lazy aggregation flags)
    Server->>DA: jsonrpc.NewClient(endpoint, namespace)
    Server->>Node: NewNode(..., &DA.DA)
    Node->>DA: Interact with DA client as needed

Loading

Possibly related PRs

• refactor: improve start handler api #41: Modifies server/start.go with changes to DA client creation and imports, similar to this PR's adjustments in DA client handling.

Suggested reviewers

• facundomedica

Poem

Hopping through code, I clear the old flags,
Lazy aggregators—packed up in bags.
DA client’s path is now tidy and neat,
With namespaces added, the change is complete.
The server starts fresh, with less to configure,
A leap toward simplicity—swift and secure! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d62bf75 and fc371b7.

📒 Files selected for processing (2)

• server/flags.go (0 hunks)
• server/start.go (3 hunks)

💤 Files with no reviewable changes (1)

• server/flags.go

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: lint / golangci-lint

🔇 Additional comments (4)

server/start.go (4)

36-36: Import path update is aligned with Rollkit changes.

The import statement has been updated to use the consolidated DA client package from Rollkit.

---

48-48: Dependency import simplification.

The provider package import has been simplified by removing any alias, making the code more consistent with Go conventions.

---

409-409: DA client reference passing updated.

The DA client is now passed by reference directly to the node.NewNode constructor, which aligns with the latest Rollkit API changes.

---

399-399:

Details

❓ Verification inconclusive

DA client initialization updated with namespace parameter.

The DA client initialization now uses jsonrpc.NewClient with an additional namespace parameter from the configuration. This change:

1. Aligns with Rollkit's latest API
2. Removes hardcoded values
3. Makes the code more configurable

---

🏁 Script executed:

#!/bin/bash
# Check the Rollkit DA client interface to verify parameter usage
rg -A 3 -B 3 "func NewClient" --glob "**/*.go"

Length of output: 48

---

Verify jsonrpc.NewClient signature

I wasn’t able to locate the NewClient definition in the codebase, so please confirm that the jsonrpc.NewClient(ctx, logger, address, authToken, namespace) call matches the actual function signature in the imported jsonrpc package. This ensures the added namespace parameter is supported and your code will compile as expected.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[tac0turtle]

We still need these. They were changed. To lazymode and lazyblock interval

[jgimeno]

ah ok, thanks

[tac0turtle]

this doesnt work out of the box unless you update the rollkit version in the go.mod.

[tac0turtle]

replaced by #79