Skip to content

feat: update exec api to acommodate to last changes in rollkit #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
randygrok wants to merge 1 commit into from
Closed

feat: update exec api to acommodate to last changes in rollkit #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions server/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ func AddFlags(cmd *cobra.Command) {
cmd.Flags().Bool(config.FlagLight, def.Node.Light, "run light client")
cmd.Flags().Duration(config.FlagBlockTime, def.Node.BlockTime.Duration, "block time (for aggregator mode)")
cmd.Flags().String(config.FlagTrustedHash, def.Node.TrustedHash, "initial trusted hash to start the header exchange service")
cmd.Flags().Bool(config.FlagLazyAggregator, def.Node.LazyAggregator, "produce blocks only when transactions are available or after lazy block time")

@tac0turtle tac0turtle May 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need these. They were changed. To lazymode and lazyblock interval

@jgimeno jgimeno May 6, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, thanks

cmd.Flags().Uint64(config.FlagMaxPendingBlocks, def.Node.MaxPendingBlocks, "maximum blocks pending DA confirmation before pausing block production (0 for no limit)")
cmd.Flags().Duration(config.FlagLazyBlockTime, def.Node.LazyBlockTime.Duration, "maximum interval between blocks in lazy aggregation mode")

// Data Availability configuration flags
cmd.Flags().String(config.FlagDAAddress, def.DA.Address, "DA address (host:port)")
Expand Down
12 changes: 4 additions & 8 deletions server/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ import (
"google.golang.org/grpc/credentials/insecure"

"github.com/rollkit/rollkit/core/sequencer"
rollkitda "github.com/rollkit/rollkit/da"
"github.com/rollkit/rollkit/da/proxy/jsonrpc"
"github.com/rollkit/rollkit/da/jsonrpc"
"github.com/rollkit/rollkit/node"
"github.com/rollkit/rollkit/pkg/config"
"github.com/rollkit/rollkit/pkg/genesis"
Expand All @@ -46,7 +45,7 @@ import (
"github.com/rollkit/go-execution-abci/pkg/adapter"
"github.com/rollkit/go-execution-abci/pkg/rpc"
rpcjson "github.com/rollkit/go-execution-abci/pkg/rpc/json"
provider "github.com/rollkit/go-execution-abci/pkg/rpc/provider"
"github.com/rollkit/go-execution-abci/pkg/rpc/provider"
execsigner "github.com/rollkit/go-execution-abci/pkg/signer"
)

Expand Down Expand Up @@ -397,20 +396,17 @@ func startNode(
)

// create the DA client
daClient, err := jsonrpc.NewClient(ctx, logger, rollkitcfg.DA.Address, rollkitcfg.DA.AuthToken)
daClient, err := jsonrpc.NewClient(ctx, logger, rollkitcfg.DA.Address, rollkitcfg.DA.AuthToken, rollkitcfg.DA.Namespace)
if err != nil {
return nil, nil, nil, cleanupFn, fmt.Errorf("failed to create DA client: %w", err)
}

// TODO(@facu): gas price and gas multiplier should be set by the node operator
rollkitda := rollkitda.NewDAClient(&daClient.DA, 1, 1, []byte(cmtGenDoc.ChainID), []byte{}, logger)

rolllkitNode, err = node.NewNode(
ctxWithCancel,
rollkitcfg,
executor,
sequencer.NewDummySequencer(),
rollkitda,
&daClient.DA,
signer,
*nodeKey,
p2pClient,
Expand Down