Skip to content

Replace fast_star paths with path patterns - #1369

Merged
crandmck merged 1 commit into
expressjs:gh-pagesfrom
aelmardhi:fast_star
Sep 2, 2024
Merged

crandmck merged 1 commit into
expressjs:gh-pagesfrom
aelmardhi:fast_star

Conversation

@aelmardhi

Copy link
Copy Markdown
Contributor

fast star is no longer supporrted
using path patterns to allow match all

fast star is no longer supporrted
@crandmck crandmck added the 5.x Docs for 5.x version label Mar 5, 2024
@crandmck crandmck added the needs tech review A doc edit that requires technical review before merging label May 24, 2024

@IamLizu IamLizu left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Let's get it landed.

Edit: I removed the "needs tech review" label as I can confirm the changes are correct.

@IamLizu IamLizu added pr and removed needs tech review A doc edit that requires technical review before merging labels Sep 1, 2024
@crandmck

crandmck commented Sep 2, 2024

Copy link
Copy Markdown
Member

Thanks for reviewing/confirming this fix @IamLizu !

@crandmck
crandmck merged commit 7086c51 into expressjs:gh-pages Sep 2, 2024
chrisdel101 pushed a commit to chrisdel101/expressjs.com that referenced this pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.x Docs for 5.x version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants