Skip to content

Change wildcard to catch routes - #1583

Closed
IamLizu wants to merge 1 commit into
expressjs:gh-pagesfrom
IamLizu:fix/5x-router-wildcardd
Closed

IamLizu wants to merge 1 commit into
expressjs:gh-pagesfrom
IamLizu:fix/5x-router-wildcardd

Conversation

@IamLizu

@IamLizu IamLizu commented Aug 23, 2024

Copy link
Copy Markdown
Member

As #1408 points out, the wildcard defined no longer works. So, replaced * with (.*) in 5.x specific files. I have also installed the 5.x from npm and verified the wildcard change for root level and api level routes present in the docs.

Notes

@netlify

netlify Bot commented Aug 23, 2024 •

Copy link
Copy Markdown

✅ Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 5928cce
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/66c8430efdf9980008f7d70e
😎 Deploy Preview https://deploy-preview-1583--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas

bjohansebas commented Aug 27, 2024 •

Copy link
Copy Markdown
Member

@IamLizu It seems that this PR has the same changes as #1369, Which one should we keep?

@IamLizu

IamLizu commented Sep 1, 2024

Copy link
Copy Markdown
Member Author

@IamLizu It seems that this PR has the same changes as #1369, Which one should we keep?

We should definitely land the existing one. My bad I didn't check for this. I am closing this in reference of #1369

@IamLizu IamLizu closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

express 5 router wildcard does not work as documented

2 participants