Skip to content

fix(core, web): skip hot-restart listener cleanup in profile mode - #18729

Merged
SelaseKay merged 1 commit into
mainfrom
fix/issue-18728
Sep 28, 2026
Merged

SelaseKay merged 1 commit into
mainfrom
fix/issue-18728

Conversation

@SelaseKay

@SelaseKay SelaseKay commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Description

Profile web builds were still storing hot-restart unsubscribe functions on window. firebase_auth_web only assigns a unique listener key when Flutter's kDebugMode is true, so in profile every listener used no-op. firebase_core_web treated profile as debug because it only checked dart.vm.product, which stays false in profile. Creating FirebaseAuth subscribes to auth state and then to the ID token, so the second subscription cancelled the first before Firebase Auth could emit. authStateChanges() then never fired.

The core flag now matches Flutter's kDebugMode (!dart.vm.product && !dart.vm.profile). Debug builds still save unsubscribe functions for hot restart. Profile and release builds do not. Firestore, Storage, and App Check share this helper and the same no-op key, so they pick up the same fix.

Related Issues

Fixes #18728

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Test plan

  • Profile, release, and debug web builds of a page that subscribes to auth state and then the ID token, using the real window listener helpers. Before the fix, profile dropped the auth callback (auth js unsubscribe called). After the fix, profile emitted, with both keys still no-op and no unsubscribe call. Release and debug emitted before and after.
  • dart analyze packages/firebase_core/firebase_core_web/lib/src/interop/utils/utils.dart

The flag is a compile-time constant, so a debug flutter test run cannot observe the profile branch. The full package test suite and melos run analyze were not run.

Profile builds left dart.vm.product unset, so web listeners were stored under the shared 'no-op' key and the next subscription cancelled them.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@SelaseKay
SelaseKay merged commit 20f2cbf into main Sep 28, 2026
114 checks passed
@SelaseKay
SelaseKay deleted the fix/issue-18728 branch September 28, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firebase_auth_web]: authStateChanges() never emits in --profile web builds (listener key 'no-op' collides)

3 participants