Skip to content

fix(core, web): skip hot-restart listener cleanup in profile mode #18729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SelaseKay merged 1 commit into from
Sep 28, 2026
Merged

fix(core, web): skip hot-restart listener cleanup in profile mode #18729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/firebase_core/firebase_core_web/lib/src/interop/utils/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,19 @@ import 'package:web/web.dart' as web;

import 'func.dart';

// Hot restart exists only in debug mode. This must match Flutter's
// kDebugMode (`!dart.vm.product && !dart.vm.profile`). Profile builds leave
// dart.vm.product false, so gating on product mode alone still stores JS
// unsubscribe functions on window. Plugins then share the key 'no-op'
// outside debug and cancel the previous listener on the next subscription.
// See https://github.com/firebase/flutterfire/issues/18728.
// ignore: do_not_use_environment
const bool _kDebugMode = !bool.fromEnvironment('dart.vm.product');
const bool _kReleaseMode = bool.fromEnvironment('dart.vm.product');

// ignore: do_not_use_environment
const bool _kProfileMode = bool.fromEnvironment('dart.vm.profile');

const bool _kDebugMode = !_kReleaseMode && !_kProfileMode;

/// Handles the [Future] object with the provided [mapper] function.
JSPromise handleFutureWithMapper<T, S>(
Expand Down
Loading