Skip to content

Bump fontanf/shape dependency - #599

Merged
fontanf merged 1 commit into
masterfrom
bump-shape
Sep 23, 2026
Merged

fontanf merged 1 commit into
masterfrom
bump-shape

Conversation

@fontanf

@fontanf fontanf commented Sep 23, 2026 •

Copy link
Copy Markdown
Owner

Bumps shape from ea5dc54 to b347249, which picks up fontanf/shape#69, fontanf/shape#70, fontanf/shape#71, fontanf/shape#72 and fontanf/shape#73.

Fixes #595 and #598.

What the new shape commits fix

Testing

With packingsolver built against shape at b347249:

Picks up fontanf/shape#69, #70, #71, #72 and #73, which fix the failures
of the irregular instance building reported in #595 and #598:

- #69: the line-segment approximation of an arc placed on its circle
  ended with a degenerate segment, making circular holes look
  self-intersecting.
- #70: the fallback union of that approximation used clockwise extras
  for anticlockwise arcs, filling holes.
- #71, #72: line/circle and circle/circle tangencies were computed as
  two intersections a few micro-units apart, or as none, which made
  boolean operations fail ("face area is not positive") or overflow the
  stack.
- #73: no_fit_polygon merged nearly parallel edges in the wrong order,
  so the self-NFPs used by the periodic packing were not exact (nor
  centrally symmetric), which made the lattice search unions fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

irregular: "face area is not positive" when an outline arc is concentric with a circular hole

1 participant