Skip to content

build(deps): refresh lockfiles, nixpkgs and the native libraries ⬆️ - #70

Merged
kp2pml30 merged 1 commit into
v0.2-devfrom
pr/v0.2/feat/deps-refresh
Nov 5, 2026
Merged

kp2pml30 merged 1 commit into
v0.2-devfrom
pr/v0.2/feat/deps-refresh

Conversation

@kp2pml30

@kp2pml30 kp2pml30 commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Auto-opened executor mirror of genlayerlabs/genvm-manager#83.

Carries the executor-side work for that manager PR. The manager branch update fast-forwards v0.2-dev to its pinned commit after landing.

Summary by CodeRabbit

  • New Features
    • Added configuration options for enabling floating-point operations and setting WebAssembly call-depth and value-stack limits.
    • Added on-demand memory fingerprints for inspecting module instances.
    • SIMD lane-copy operations are now permitted when floating-point operations are disabled.
  • Bug Fixes
    • Improved error reporting for disabled reference types and missing exported memory.
    • Nondeterministic instructions in deterministic mode now have a more specific trap classification.

- Rebase the wasmtime patch series onto v48.0.8, which fixes 32 advisories since 48.0.3; nearly all sit in the component model, WASI and wasi-http, which the executor does not use. The patches are otherwise unchanged
- Rebase the wasm-tools patch onto v1.254.2, the wasmparser line 48.0.8 depends on
- `cargo update` every Cargo.lock outside the runners
- Pin mt19937 to 3.1.0 and zip to 4.3.0: both decide contract-visible results, so they move only with an executor version bump
- Register the async fd through `AsyncFd::register`, since tokio 1.54 deprecates `AsyncFd::new`
- `nix flake update` the dev shell inputs
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Wasmtime changes add float-operation controls, configurable stack limits, store-context APIs, and memory fingerprints. The PR also updates wasm-tools integration, Wiggle interfaces, selected dependency versions, and AsyncCustomFD descriptor registration.

Changes: Wasmtime and wasm-tools

Layer / File(s) Summary
wasm-tools integration
.git-third-party/patches/.../wasm-tools/src3845vax81sahq, .git-third-party/patches/.../wasmtime/502v4v1ajc7t4xxw
Wasmtime uses local wasm-tools paths, and wasmparser enables SIMD. The wasm-smith patch makes Module::encoded public and adds the reference type to an assertion message.
Float instruction handling
.git-third-party/patches/.../wasmtime/3akahs7t9mzpn07c, .git-third-party/patches/.../wasmtime/502v4v1ajc7t4xxw, .git-third-party/patches/.../wasmtime/vjpk415t4mrqsecz, crates/cranelift/src/func_environ.rs, crates/environ/src/trap_encoding.rs
The trap at numeric value 50 is renamed to NondetInstruction. Float operations check the float-enabled setting, while SIMD lane-copy operations remain allowed.
Stack limits and runtime configuration
.git-third-party/patches/.../wasmtime/502v4v1ajc7t4xxw, .git-third-party/patches/.../wasmtime/kxr8chk502g5anar, crates/wasmtime/src/config.rs, crates/wasmtime/src/runtime/store.rs, crates/wiggle/*, crates/cache/src/config.rs
Wasmtime adds configurable call-depth and value-slot limits, updates counters during function entry and return, and restores counters in catch and entry-store paths. The changes also add GenVM store context, cache configuration validation, and Wiggle memory/context APIs.
Memory fingerprints
.git-third-party/patches/.../wasmtime/502v4v1ajc7t4xxw, .git-third-party/patches/.../wasmtime/ypjcbtfcjfhyg8e7, crates/wasmtime/src/runtime/func.rs, crates/wasmtime/src/runtime/store.rs
Store fingerprint methods hash unshared memories with BLAKE3 and record shared memories with empty hashes. Duplicate module names receive numeric suffixes. Trap handling no longer attaches fingerprints to errors.

Executor dependency and I/O updates

Layer / File(s) Summary
Dependency and descriptor updates
executor/Cargo.toml, executor/crates/common/Cargo.toml, executor/crates/modules-interfaces/Cargo.toml, executor/crates/common/src/io.rs
Tokio changes to 1.54.0. The mt19937 and zip requirements become exact pins. AsyncCustomFD::new registers its descriptor with AsyncFd::register.

Estimated code review effort: 4 (Complex) | ~50 minutes

Change: Other

Sequence Diagram(s)

sequenceDiagram
  participant Config
  participant Store
  participant VMStoreContext
  participant CompiledWasmFunction
  Config->>Store: Set call-depth and value-slot limits
  Store->>VMStoreContext: Initialize reverse limit counters
  CompiledWasmFunction->>VMStoreContext: Decrement counters on entry
  CompiledWasmFunction->>VMStoreContext: Restore counters on return or catch
  VMStoreContext-->>CompiledWasmFunction: Trap with STACK_OVERFLOW on underflow
Loading
Merge Risk: Minimal · up to c01d0

No merge-blocking issue was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title describes the pull request as a dependency and build-input refresh. This matches the dependency version updates, Wasmtime and wasm-tools refreshes, and lockfile updates described in the obje…
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title describes the pull request as a dependency and build-input refresh. This matches the dependency version updates, Wasmtime and wasm-tools refreshes, and lockfile updates described in the objectives, although it does not mention the runtime and API changes in detail.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files. (9 skipped: 9 unsupported.)

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Clippy (1.99.0)

Clippy execution failed

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 7cba87e and c01d09a.

Files ignored due to path filters: 9
  • .git-third-party/manifest.json is excluded by !**/*.json
  • executor/Cargo.lock is excluded by !**/*.lock, !**/*.lock
  • executor/crates/calldata-derive/Cargo.lock is excluded by !**/*.lock, !**/*.lock
  • executor/crates/calldata/Cargo.lock is excluded by !**/*.lock, !**/*.lock
  • executor/crates/common/Cargo.lock is excluded by !**/*.lock, !**/*.lock
  • executor/crates/modules-interfaces/Cargo.lock is excluded by !**/*.lock, !**/*.lock
  • executor/crates/sdk-rs/Cargo.lock is excluded by !**/*.lock, !**/*.lock
  • flake.lock is excluded by !**/*.lock, !**/*.lock
  • support/nix/py-test/flake.lock is excluded by !**/*.lock, !**/*.lock
Files selected for processing: 10
  • .git-third-party/patches/executor/third-party/wasm-tools/src3845vax81sahq
  • .git-third-party/patches/executor/third-party/wasmtime/3akahs7t9mzpn07c
  • .git-third-party/patches/executor/third-party/wasmtime/502v4v1ajc7t4xxw
  • .git-third-party/patches/executor/third-party/wasmtime/kxr8chk502g5anar
  • .git-third-party/patches/executor/third-party/wasmtime/vjpk415t4mrqsecz
  • .git-third-party/patches/executor/third-party/wasmtime/ypjcbtfcjfhyg8e7
  • executor/Cargo.toml
  • executor/crates/common/Cargo.toml
  • executor/crates/common/src/io.rs
  • executor/crates/modules-interfaces/Cargo.toml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@kp2pml30
kp2pml30 merged commit c01d09a into v0.2-dev Nov 5, 2026
1 check passed
@kp2pml30
kp2pml30 deleted the pr/v0.2/feat/deps-refresh branch November 5, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant