Skip to content

build(deps): refresh lockfiles, nixpkgs and the native libraries ⬆️ - #83

Merged
kp2pml30 merged 3 commits into
v0.6-devfrom
feat/deps-refresh
Nov 5, 2026
Merged

kp2pml30 merged 3 commits into
v0.6-devfrom
feat/deps-refresh

Conversation

@kp2pml30

@kp2pml30 kp2pml30 commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Second of 3 stacked PRs: lockfiles, wasmtime and native libraries, after the infrastructure in #82 and ahead of the stdlib fixes (3)

Changes

  • Both executor lines move to wasmtime 48.0.8 (LTS) and wasm-tools 1.254.2, and refresh every non-runner lockfile
  • Executor: pin mt19937 = "=3.1.0" and zip = "=4.3.0", since both are contract-visible and may change only with an executor version bump
  • Executor: switch to AsyncFd::register, because tokio 1.54 deprecates AsyncFd::new
  • cargo update every manager Cargo.lock and nix flake update the flake inputs
  • Use nixpkgs lief 1.0.0 instead of the 0.17.6 override, and pin post-install to lief 1.0.0
  • musl 1.2.6 for CVE-2025-26519
  • Build lsqlite3 against the SQLite 3.54.1 amalgamation instead of the bundled 3.24.0
  • hickory-resolver 0.26 for GHSA-3v94-mw7p-v465, GHSA-5j98-2g5x-46v6, GHSA-q2qq-hmj6-3wpp and GHSA-6f2x-v7q7-m7m5
  • puppeteer-core 25.16.0 for the zod memory-exhaustion advisory
  • HTTP test mocks read the request head before answering; with the refreshed stack, hyper fails a response that arrives before its request is written

Runners are untouched

Validation

  • Full local suite without fuzz: 2080 passed, 0 failed; clippy clean
  • All 4 release artifacts build. The amd64 artifact carries musl 1.2.6 and SQLite 3.54.1, its binaries run, and its ELF section headers are intact
  • genvm-tool audit: 197 findings down to 23

Remaining Advisories

  • zip 4.3.0: fixes ship only in 9.x, which changes which contract code parses as an archive, so it needs an executor version bump
  • unsafe-libyaml: unmaintained, no fixed release
  • NVD matches on SQLite 3.54.1 and Lua 5.3.6: probable false positives

Summary by CodeRabbit

  • Chores
    • Updated networking components and supporting build tools and libraries.
    • Updated SQLite build configuration to use a specified source and matching headers.
    • Refreshed executor components and development environment settings.
    • Updated build-time checks for a required packaging tool version and adjusted linting configuration.

- Bump both executor lines to wasmtime 48.0.8
- `cargo update` every manager Cargo.lock and `nix flake update` the flake inputs
- Use nixpkgs lief 1.0.0 instead of the 0.17.6 override, and pin post-install to lief 1.0.0, which carries the same section-header fix
- Bump musl to 1.2.6 for CVE-2025-26519
- Build lsqlite3 against the SQLite 3.54.1 amalgamation instead of its bundled 3.24.0
- Bump hickory-resolver to 0.26 for GHSA-3v94-mw7p-v465, GHSA-5j98-2g5x-46v6, GHSA-q2qq-hmj6-3wpp and GHSA-6f2x-v7q7-m7m5
- Bump puppeteer-core to 25.16.0 for the zod memory-exhaustion advisory
- Make the HTTP test mocks read the request head before answering; with the refreshed stack, hyper fails a response that arrives before its request is written
@kp2pml30 kp2pml30 self-assigned this Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

GenVM PR actions

Tick a box to run it (the box unticks itself when handled). Actions only run while the PR has the ci-safe label.

  • Force run full tests
  • Provision executor PRs
Commands
  • /genvm-run-tests — run full tests once for the current manager snapshot
  • /merge — queue the exact manager snapshot through the App-owned E2E merge train

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request updates executor references and resolver handling. It also changes native build inputs, including the SQLite source, musl version, and LIEF package selection, and updates Ruff configuration.

Changes: Executor and Resolver Updates

Layer / File(s) Summary
Executor references and resolver construction
executors/v0.2.x, executors/v0.3.x, implementation/Cargo.toml, implementation/src/common/mod.rs
The executor submodule references and hickory-resolver requirement change. FilteringResolver::new adds the context “building hickory resolver” to resolver build errors.
Sidecar test request reading
implementation/src/common/mod.rs, implementation/src/web/tests.rs
A test helper reads request bytes until the request-head terminator or end of stream. The sidecar test server reads the request head before sending its response.

Native Build and Tooling Updates

Layer / File(s) Summary
SQLite source provisioning and compilation
flake.nix, libs/lsqlite3.nix, implementation/build.rs
The base shell exposes SQLITE_SRC for SQLite 3.54.1. The Nix build copies the amalgamation files, and the build script compiles from the specified SQLite source and copies lsqlite3.c into OUT_DIR.
Native build and lint tool updates
libs/libc.nix, support/default.nix, ruff.toml
musl-src changes to version 1.2.6. patch-rpath uses nixpkgs’ lief package and checks that its version is at least 0.17.6. Ruff excludes Markdown files and explicitly selects rules E4, E7, E9, and F.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Possibly related issues

Possibly related PRs

Merge Risk: Minimal · up to e79d2

No actionable merge-blocking issue is established by the supplied changes. Mergeable subject to normal build and test checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely summarizes the main changes: refreshing dependency lockfiles, Nix inputs, and native libraries.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 4 functions across 3 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between deb4ab8 and e79d26c.

Files selected for processing: 2
  • executors/v0.3.x
  • ruff.toml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

Linked executor PR(s)

executor: genlayerlabs/genvm-executor#70 (v0.2)
executor: genlayerlabs/genvm-executor#71 (v0.3)

- Select E4, E7, E9 and F explicitly: ruff 0.17 from the flake update enables a much larger default set, 205 findings in existing code
- Exclude Markdown: ruff 0.17 formats Python blocks inside `.md` files
- Keep ruff's pre-0.17 rule set in the executor
- Skip pyright on `evm/generate.py` until the runner source fix lands with a hash bump
@kp2pml30

kp2pml30 commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

/genvm-run-tests

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

👀 Full tests are running for e79d26ce87b5: open run #41876020133

@kp2pml30

kp2pml30 commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

/run-e2e all

@ci-core-e2e-runner

Copy link
Copy Markdown

E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally.

@kp2pml30

kp2pml30 commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

/genvm-fast-forward

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

🚀 Fast-forwarded v0.6-dev to e79d26ce87b5

Open run

@kp2pml30
kp2pml30 merged commit e79d26c into v0.6-dev Nov 5, 2026
32 of 33 checks passed
@kp2pml30
kp2pml30 deleted the feat/deps-refresh branch November 5, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant