Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions docs/contributing/howto/extending/modify-runner.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,17 @@ line's `data/all.json`:
### Adding a Fork

The schedule is `install/data/genvm-chainforks.json` in the manager repo; a fork
named by a pin but missing there fails the build. A host with its own schedule
(Studio's) passes it as `genvm-manager --chainforks-path <file> --default-network <network>`,
named by a pin but missing there fails the build. It holds only `dev`: real
networks live in each host's own schedule (the node's, Studio's), which the host
passes as `genvm-manager --chainforks-path <file> --default-network <network>`,
both for serving and for `check-install`. A flag left out falls back to the
config's `chainforks_path` or `default_network`. A null `default_network`
rejects a request naming no network
config's `chainforks_path` or `default_network`. The shipped `default_network`
is null, so a request naming no network is rejected unless the host passes one

1. Add the fork under `forks`, with `"requires": ["genvm/executor/<line>"]`: a
name extending another fork's name must require it
2. Schedule it on every network under `networks.<name>.forks`: `always` on
`dev`, so the test suite sees it, and `never` or the agreed RFC 3339 date on
the real networks. A network missing the fork fails the build and the
manager startup
2. Schedule it `always` on `dev`, so the test suite sees it. A network missing
the fork fails the build and the manager startup
3. Add the same fork to each host's schedule, scheduled on every network there
(`never` or the agreed RFC 3339 date on the real ones),
before the host moves to this release: the manager and `check-install`
Expand Down
27 changes: 2 additions & 25 deletions implementation/src/manager/chainforks_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,36 +35,13 @@ fn the_shipped_schedule_is_valid() {
)
.unwrap();

assert_eq!(
schedule.networks.keys().collect::<Vec<_>>(),
["bradbury-phase2", "clarke", "dev", "phantom-bradbury"]
);
// Real networks belong to the hosts, which pass their own schedules
assert_eq!(schedule.networks.keys().collect::<Vec<_>>(), ["dev"]);
let dev = schedule.active("dev", at("1970-01-01T00:00:00Z")).unwrap();
assert_eq!(
dev.to_string(),
"genvm/executor/v0.2,genvm/executor/v0.3,genvm/executor/v0.4"
);
let now = at("2026-11-09T00:00:00Z");
assert_eq!(
schedule.active("clarke", now).unwrap().to_string(),
"genvm/executor/v0.4"
);
for when in [at("1970-01-01T00:00:00Z"), at("2026-01-01T00:00:00Z"), now] {
assert_eq!(
schedule
.active("phantom-bradbury", when)
.unwrap()
.to_string(),
schedule
.active("bradbury-phase2", when)
.unwrap()
.to_string()
);
}
assert!(!schedule
.active("bradbury-phase2", now)
.unwrap()
.contains("genvm/executor/v0.4"));
}

#[test]
Expand Down
2 changes: 1 addition & 1 deletion install/config/genvm-manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ log_level: info

manifest_path: ${exeDir}/../data/manifest.yaml
chainforks_path: ${exeDir}/../data/genvm-chainforks.json # when each executor line and runner activates, per network
default_network: bradbury-phase2 # network of a request that names none
default_network: null # network of a request that names none; null rejects such a request
allow_two_workers: true # overlap deterministic execution with nondeterministic validation
permits: # 1 permit is 1 GiB of RAM
total: null # if null, free memory times `per_gib`
Expand Down
21 changes: 0 additions & 21 deletions install/data/genvm-chainforks.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,27 +12,6 @@
"genvm/executor/v0.3": "always",
"genvm/executor/v0.4": "always"
}
},
"bradbury-phase2": {
"forks": {
"genvm/executor/v0.2": "never",
"genvm/executor/v0.3": "always",
"genvm/executor/v0.4": "never"
}
},
"phantom-bradbury": {
"forks": {
"genvm/executor/v0.2": "never",
"genvm/executor/v0.3": "always",
"genvm/executor/v0.4": "never"
}
},
"clarke": {
"forks": {
"genvm/executor/v0.2": "never",
"genvm/executor/v0.3": "never",
"genvm/executor/v0.4": "always"
}
}
}
}
Loading