You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(manager): ship only the dev network and no default network ✨ - #88
Review layer of stack #92, above #91: do not post /merge here until #91 lands. Breaking for the node on v0.6-dev, which relies on the production networks this PR drops, so it lands with genlayer-node#2428
Problem and Outcome
Production networks belong to their hosts: the node owns bradbury-phase2, phantom-bradbury and clarke and passes its schedule with --chainforks-path
The shipped schedule keeps only dev
The shipped default_network is null: a request naming no network is rejected unless the host passes one
Implementation and Validation
The shipped-schedule test expects exactly dev
Breaking for any host that starts the manager without a network and sends none, such as dev-env
Summary by CodeRabbit
Configuration
Requests that omit a network are now rejected by default; hosts can supply a default network in their configuration.
Documentation
Updated fork scheduling guidance to distinguish the manager’s development schedule from host-provided real-network schedules.
Clarified that omitted command-line options use configured values, and that hosts must schedule the fork on each network before moving to the release.
Reviewing files that changed from the base of the PR and between f69bc41 and f67532d.
Files ignored due to path filters: 2
implementation/src/manager/chainforks_test.rs is excluded by !**/*_test.rs
install/data/genvm-chainforks.json is excluded by !**/*.json
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
The shipped configuration now sets default_network to null. The fork instructions distinguish the manager’s dev schedule from real-network schedules supplied by each host.
Changes: Network defaults and fork scheduling
Layer / File(s)
Summary
Default network and fork schedule install/config/genvm-manager.yaml, docs/contributing/howto/extending/modify-runner.md
The shipped default_network is now null. The instructions document config fallbacks, schedule the fork always on dev, and state that hosts supply real-network schedules.
Requests that name no network are now rejected unless the host passes a default network. This is an intentional breaking change. Merge it only in coordination with the node PR and #91, as the PR description states, and run the full tests first.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the main change: the manager ships only the dev network and no default network. The raw summary confirms default_network changes from bradbury-phase2 to null and the docs drop th…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: the manager ships only the dev network and no default network. The raw summary confirms default_network changes from bradbury-phase2 to null and the docs drop the production schedules. The title is specific and matches the objectives. The emoji is noise, but it does not make the title unrelated or vague.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
kp2pml30
changed the title
feat(manager): ship only the dev network and no default network ✨
feat(manager): let hosts own the chainforks schedule and verify it ✨
Nov 12, 2026
kp2pml30
changed the title
feat(manager): let hosts own the chainforks schedule and verify it ✨
feat(manager): ship only the dev network and no default network ✨
Nov 12, 2026
Production networks belong to their hosts, which pass their own schedule and network with `--chainforks-path` and `--default-network`
- The shipped schedule keeps only `dev`
- The shipped `default_network` is null, so a request naming no network is rejected unless the host passes one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci-safenot rebasedbranch is behind its base; rebase before it can be merged
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivery Context
Hub: genlayerlabs/genlayer-node#2428
Review layer of stack #92, above #91: do not post
/mergehere until #91 lands. Breaking for the node onv0.6-dev, which relies on the production networks this PR drops, so it lands with genlayer-node#2428Problem and Outcome
Production networks belong to their hosts: the node owns
bradbury-phase2,phantom-bradburyandclarkeand passes its schedule with--chainforks-pathdevdefault_networkis null: a request naming no network is rejected unless the host passes oneImplementation and Validation
devSummary by CodeRabbit