Skip to content

feat(manager): ship only the dev network and no default network ✨ - #88

Open
kp2pml30 wants to merge 1 commit into
v0.6-devfrom
feat/host-chainforks-prod
Open

kp2pml30 wants to merge 1 commit into
v0.6-devfrom
feat/host-chainforks-prod

Conversation

@kp2pml30

@kp2pml30 kp2pml30 commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Delivery Context

Hub: genlayerlabs/genlayer-node#2428

Review layer of stack #92, above #91: do not post /merge here until #91 lands. Breaking for the node on v0.6-dev, which relies on the production networks this PR drops, so it lands with genlayer-node#2428

Problem and Outcome

Production networks belong to their hosts: the node owns bradbury-phase2, phantom-bradbury and clarke and passes its schedule with --chainforks-path

  • The shipped schedule keeps only dev
  • The shipped default_network is null: a request naming no network is rejected unless the host passes one

Implementation and Validation

  • The shipped-schedule test expects exactly dev
  • Breaking for any host that starts the manager without a network and sends none, such as dev-env

Summary by CodeRabbit

  • Configuration
    • Requests that omit a network are now rejected by default; hosts can supply a default network in their configuration.
  • Documentation
    • Updated fork scheduling guidance to distinguish the manager’s development schedule from host-provided real-network schedules.
    • Clarified that omitted command-line options use configured values, and that hosts must schedule the fork on each network before moving to the release.

@kp2pml30
kp2pml30 added this pull request to stack #89 November 12, 2026 12:23
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Files ignored due to path filters: 2

  • implementation/src/manager/chainforks_test.rs is excluded by !**/*_test.rs
  • install/data/genvm-chainforks.json is excluded by !**/*.json
Run configuration

Commits

Reviewing files that changed from the base of the PR and between f69bc41 and f67532d.

Files ignored due to path filters: 2

  • implementation/src/manager/chainforks_test.rs is excluded by !**/*_test.rs
  • install/data/genvm-chainforks.json is excluded by !**/*.json

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The shipped configuration now sets default_network to null. The fork instructions distinguish the manager’s dev schedule from real-network schedules supplied by each host.

Changes: Network defaults and fork scheduling

Layer / File(s) Summary
Default network and fork schedule
install/config/genvm-manager.yaml, docs/contributing/howto/extending/modify-runner.md
The shipped default_network is now null. The instructions document config fallbacks, schedule the fork always on dev, and state that hosts supply real-network schedules.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: Low · previous review f69bc

Requests that name no network are now rejected unless the host passes a default network. This is an intentional breaking change. Merge it only in coordination with the node PR and #91, as the PR description states, and run the full tests first.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: the manager ships only the dev network and no default network. The raw summary confirms default_network changes from bradbury-phase2 to null and the docs drop th…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the manager ships only the dev network and no default network. The raw summary confirms default_network changes from bradbury-phase2 to null and the docs drop the production schedules. The title is specific and matches the objectives. The emoji is noise, but it does not make the title unrelated or vague.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 826bc3e and f69bc41.

Files ignored due to path filters: 2

  • implementation/src/manager/chainforks_test.rs is excluded by !**/*_test.rs
  • install/data/genvm-chainforks.json is excluded by !**/*.json
Files selected for processing: 2

  • docs/contributing/howto/extending/modify-runner.md
  • install/config/genvm-manager.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

GenVM PR actions

Tick a box to run it (the box unticks itself when handled). Actions only run while the PR has the ci-safe label.

  • Force run full tests
  • Provision executor PRs
Commands
  • /genvm-run-tests — run full tests once for the current manager snapshot
  • /genvm-fast-forward — land an approved, green PR by moving its base branch to the PR head
  • /merge — queue the exact manager snapshot through the App-owned E2E merge train

Base automatically changed from feat/host-chainforks to v0.6-dev November 12, 2026 14:13
@kp2pml30
kp2pml30 force-pushed the feat/host-chainforks-prod branch from ea21971 to f500647 Compare November 12, 2026 16:56
@kp2pml30 kp2pml30 changed the title feat(manager): ship only the dev network and no default network ✨ feat(manager): let hosts own the chainforks schedule and verify it ✨ Nov 12, 2026
@kp2pml30
kp2pml30 force-pushed the feat/host-chainforks-prod branch from f500647 to f69bc41 Compare November 12, 2026 17:24
@kp2pml30
kp2pml30 removed this pull request from stack #89 November 12, 2026 17:25
@kp2pml30
kp2pml30 changed the base branch from v0.6-dev to feat/manager-get-forks November 12, 2026 17:25
@kp2pml30
kp2pml30 added this pull request to stack #92 November 12, 2026 17:25
@kp2pml30 kp2pml30 changed the title feat(manager): let hosts own the chainforks schedule and verify it ✨ feat(manager): ship only the dev network and no default network ✨ Nov 12, 2026
Base automatically changed from feat/manager-get-forks to v0.6-dev November 13, 2026 09:22
@kp2pml30
kp2pml30 marked this pull request as ready for review November 13, 2026 09:57
@kp2pml30

Copy link
Copy Markdown
Member Author

/genvm-run-tests

@github-actions

Copy link
Copy Markdown

👀 Full tests are running for f69bc41538f2: open run #43428229583

@github-actions github-actions Bot added the not rebased branch is behind its base; rebase before it can be merged label Nov 16, 2026
Production networks belong to their hosts, which pass their own schedule and network with `--chainforks-path` and `--default-network`

- The shipped schedule keeps only `dev`
- The shipped `default_network` is null, so a request naming no network is rejected unless the host passes one
@kp2pml30
kp2pml30 force-pushed the feat/host-chainforks-prod branch from f69bc41 to f67532d Compare November 17, 2026 17:30
@kp2pml30
kp2pml30 requested a review from jmlago as a code owner November 17, 2026 17:30
@kp2pml30

Copy link
Copy Markdown
Member Author

/genvm-run-tests

@github-actions github-actions Bot removed the not rebased branch is behind its base; rebase before it can be merged label Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

🚀 Full tests passed for f67532d76b1d: open run #44137916498

@github-actions github-actions Bot added the not rebased branch is behind its base; rebase before it can be merged label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-safe not rebased branch is behind its base; rebase before it can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant