Repository navigation
feat(manager): let a host verify its chainforks schedule and ask for forks ✨ - #91
Conversation
…forks ✨ A host that passes its own schedule with `--chainforks-path` proves the manager runs the same one with a hash, then asks which forks are active, before it builds a run - New socket method `get_forks` answers every fork a network schedules and whether it is active at a timestamp, through the same resolver a run uses, on any connection with or without a run - `network_hash` is keccak256 of the calldata map of the network's activation strings; a different one fails with `chainforks_mismatch`, an unknown or empty network with `unknown_network` - A schedule naming an empty network is rejected at load
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
GenVM PR actionsTick a box to run it (the box unticks itself when handled). Actions only run while the PR has the
Commands
|
|
/genvm-run-tests |
|
👀 Full tests are running for |
|
/run-e2e all |
|
E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally. |
|
/run-e2e all |
|
E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally. |
|
robo-kp2pml30: @kp2pml30 E2E cannot start for this PR: both runs died in the planner before any build, with the same native crash
Not rerunning again: it reproduced on both. This needs a fix or a runner image change in genlayer-e2e |
|
/run-e2e |
|
E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally. |
|
/genvm-fast-forward |
|
🚀 Fast-forwarded |
Delivery Context
Bottom of stack #92 and its own landing cut: backwards compatible, nothing depends on it landing together
Problem and Outcome
A host that passes its own schedule with
--chainforks-pathneeds to know the manager runs the same schedule, and which forks are active, before it builds a run: a run request may depend on the forks. Now it can ask over the existing websocketget_forks(GET_FORKS = 8): given a network, a timestamp andnetwork_hash, it answers every fork the network schedules and whether it is active, through the same resolver a run uses, on any connection with or without a runnetwork_hashis keccak256 of the calldata map of the network's activation strings; a different one fails withCHAINFORKS_MISMATCH = 8, an unknown or empty network withUNKNOWN_NETWORK = 7manager-api.jsonand the generated Rust, Python and docs are updatedNon-goal: the shipped schedule and
default_networkare unchanged; #88 drops the production networksImplementation and Validation
get_forks, with the vector genlayer-node pinsget_forksSummary by CodeRabbit