Repository navigation
test: Observe iOS CrashE2E process exits - #9345
Merged
Merged
Conversation
supervacuus
requested review from
NinjaLikesCheez,
itaybre,
noahsmartin and
philprime
as code owners
October 14, 2026 12:26
9 tasks
Size Analysis1 component analyzed iOS Builds
|
📲 Install BuildsiOS
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1cba5c4 | 1230.28 ms | 1271.48 ms | 41.20 ms |
| 8a8e812 | 1233.65 ms | 1257.19 ms | 23.54 ms |
| 89ccfc2 | 1210.78 ms | 1245.02 ms | 34.24 ms |
| fee4ec3 | 1229.19 ms | 1269.85 ms | 40.66 ms |
| 545ca7e | 1233.89 ms | 1269.30 ms | 35.41 ms |
| b0aa013 | 1208.48 ms | 1244.00 ms | 35.52 ms |
| 02b997a | 1224.77 ms | 1263.96 ms | 39.19 ms |
| 88e0b6e | 1212.93 ms | 1251.27 ms | 38.33 ms |
| 80db012 | 1211.67 ms | 1273.24 ms | 61.57 ms |
| f6e658b | 1203.39 ms | 1238.34 ms | 34.95 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1cba5c4 | 24.14 KiB | 1.38 MiB | 1.36 MiB |
| 8a8e812 | 24.14 KiB | 1.38 MiB | 1.36 MiB |
| 89ccfc2 | 24.14 KiB | 1.38 MiB | 1.36 MiB |
| fee4ec3 | 24.14 KiB | 1.39 MiB | 1.36 MiB |
| 545ca7e | 24.14 KiB | 1.39 MiB | 1.36 MiB |
| b0aa013 | 24.14 KiB | 1.38 MiB | 1.36 MiB |
| 02b997a | 24.14 KiB | 1.39 MiB | 1.36 MiB |
| 88e0b6e | 24.14 KiB | 1.38 MiB | 1.36 MiB |
| 80db012 | 24.14 KiB | 1.39 MiB | 1.36 MiB |
| f6e658b | 24.14 KiB | 1.38 MiB | 1.35 MiB |
supervacuus
enabled auto-merge (squash)
October 14, 2026 15:26
Contributor
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0aebb74. Configure here.
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📜 Description
NOTE_EXITnotifications instead of pollinglaunchdjob registrations#skip-changelog
💡 Motivation and Context
A recent investigation into increasing CrashE2E failures in CI revealed: a
launchdjob can remain registered after its process exits and, as a consequence, a failedlaunchctlquery does not prove the app terminated. Neither should determine whether the CrashE2E harness proceeds to drain and verify reports.In addition, when we introduced CrashE2E in CI, we added coarse known-failure handling that could disguise harness failures as expected SDK reporting gaps (for instance, when SentryCrash can't pass a scenario that the KSCrash integration supports) and bypass cleanup. Classifying failures only after cleanup preserves scenario isolation and prevents false-green runs.
Both will help us with distinguishing cause and effect when CrashE2E runs fail in CI (especially for iOS simulator runs).
💚 How did you test it?
I ran the newly added test suite for the runner and the CrashE2E runner on some iOS tests.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.Closes #9346