Repository navigation
test: improve CrashE2E timeout diagnostics - #9412
Merged
Merged
Conversation
supervacuus
requested review from
NinjaLikesCheez,
itaybre,
noahsmartin and
philprime
as code owners
October 20, 2026 18:53
Size Analysis1 component analyzed iOS Builds
|
📲 Install BuildsiOS
|
itaybre
approved these changes
Oct 21, 2026
itaybre
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, very samll comments
Contributor
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
This PR further improves on the data collected when an iOS CrashE2E app does not exit:
samplewatchdog with kernel stackshots fromspindumpthe outer time limit)
sudo--keep-goingsuccessfully runs the next scenario(!)available (also added tests for this)
💡 Motivation and Context
While last week's changes (#9345) improved the
CrashE2Efailure rate quite a bit, a couple of recent iOS CrashE2E timeouts were hard to investigate because the diagnostic commandsamplestopped after eight seconds, sometimes while processing symbols, without saving usable stacks.I simply wanted the next failure to tell us what the app-under-test was doing. Passing ordinary crash scenarios in CI also did not prove that timeout diagnostics and cleanup worked, so this change tests that path explicitly.
This improves the harness and its diagnostics, should help us reduce the CrashE2E failure rate even further, and is essential preparation for #8855.
💚 How did you test it?
Ran the CrashE2E tests and the tests that test the harness lots of times :)
Also successfully ran the live timeout tests in experimental CI runs.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.