Repository navigation
unicode : extending opt-in NFC support beyond UGM - #30708
Open
sandrohanea wants to merge 1 commit into
Open
sandrohanea wants to merge 1 commit into
sandrohanea wants to merge 1 commit into
Conversation
Member
|
Should probably take the time to also address the cpt/utf8 round-trip issue, see #30679 |
Contributor
|
Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The existing NFC metadata flag
tokenizer.ggml.normalizer.nfcnow works across all seven tokenizer families, through shared normalization after special-token partitioning.Additional information
Added also
unicode_cpts_from_utf8(const char * utf8, size_t length)overload so that NFC-enabled fragments decode directly from a bounded pointer and length, avoiding an intermediate substring copy. Existing string decoder signatures and default-off behavior are preserved.Requirements