Skip to content

vocab : NFC in the BPE tokenizer - #30748

Closed
sushrut1058 wants to merge 1 commit into
ggml-org:masterfrom
sushrut1058:tokenizer-bpe-nfc-normalization
Closed

sushrut1058 wants to merge 1 commit into
ggml-org:masterfrom
sushrut1058:tokenizer-bpe-nfc-normalization

Conversation

@sushrut1058

@sushrut1058 sushrut1058 commented Oct 18, 2026 •

Copy link
Copy Markdown

Overview

BPE loads tokenizer.ggml.normalizer.nfc and never applies it. Normalize before the pre-tokenizer when the flag is set.

Fixes #30747

Additional information

Qwen2, no BOS, café as NFD (63 61 66 65 cc 81): HF 924 58858, llama.cpp 924 1859 53839. NFC input matches. ASCII is unaffected.

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: YES. An assistant wrote the BPE change and the regression test. I reviewed the diff.

@sushrut1058
sushrut1058 requested a review from CISC as a code owner October 18, 2026 05:21
@ggml-gh-bot

ggml-gh-bot Bot commented Oct 18, 2026

Copy link
Copy Markdown

Hi @sushrut1058, thanks for your contribution!

Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:

  • PR Template not respected: Please respect the template when creating a new pull request. Make sure to fill out all required sections.

Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below.

@ggml-gh-bot ggml-gh-bot Bot added the draft PR will be changed to draft by github-actions bot label Oct 18, 2026
@github-actions
github-actions Bot marked this pull request as draft October 18, 2026 05:27
@github-actions github-actions Bot removed the draft PR will be changed to draft by github-actions bot label Oct 18, 2026
@sushrut1058
sushrut1058 marked this pull request as ready for review October 18, 2026 05:34
@CISC

CISC commented Oct 18, 2026

Copy link
Copy Markdown
Member

Overlaps #30708

@CISC CISC closed this Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BPE ignores tokenizer.ggml.normalizer.nfc

2 participants