GLTF: Preserve node visibility on import - #98874
Conversation
|
I would move the We can do it now or later. |
2bdaedd to
911f03e
Compare
|
@fire Updated the PR to remove the "not discarding invisible nodes" part. |
|
We discussed:
This causes an option that would change meaning in a future release.
I do not favour this because it doesn't default on, so any bugs will be hidden for maybe a year. |
911f03e to
9247327
Compare
|
The artifact upload failed, so feel free to press the redo failed jobs button. |
|
Thanks! |
…isibility GLTF: Preserve node visibility on import
…isibility GLTF: Preserve node visibility on import
…isibility GLTF: Preserve node visibility on import
…isibility GLTF: Preserve node visibility on import
KHR_node_visibility is implemented by PR #93722 but is not yet ratified by Khronos. In the meantime, I tried to implement this in GDScript, but I found that it was impossible for 2 reasons:
Invisible nodes are discarded during export.This PR extracts the fixes to
these problemsthe first problem from PR #93722 to allow implementing KHR_node_visibility in GDScript. EDIT: For import only.The fix for not discarding invisible nodes may be controversial, especially since due to the lack of the user-facing settings in PR #93722, there is no exposed setting to customize this. Still, I think this is a good change. I would exclude this part when cherry-picking to 4.3 though. Or, I can remove it if I really must, and at least we can fix importing.