Skip to content

[4.2] GLTF: Preserve node visibility on import - #98878

Merged
akien-mga merged 1 commit into
godotengine:4.2from
aaronfranke:4.2-gltf-preserve-visibility
Dec 5, 2024
Merged

akien-mga merged 1 commit into
godotengine:4.2from
aaronfranke:4.2-gltf-preserve-visibility

Conversation

@aaronfranke

Copy link
Copy Markdown
Member

Backport of PR #98874 for Godot 4.2. Due to conflicts, #98877 could not be automatically cherry-picked.

I also included the rename of ImporterMeshInstance3D *mesh_3d to importer_mesh_3d because 1) Improved readability and 2) May decrease friction in future backports to have this code similar to master.

Comment thread modules/gltf/extensions/gltf_document_extension_convert_importer_mesh.cpp Outdated
@aaronfranke
aaronfranke force-pushed the 4.2-gltf-preserve-visibility branch from 2835c93 to 8bf8028 Compare November 8, 2024 22:24

@lyuma lyuma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved in meeting

@akien-mga
akien-mga merged commit 369b981 into godotengine:4.2 Dec 5, 2024
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

@aaronfranke
aaronfranke deleted the 4.2-gltf-preserve-visibility branch December 5, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants