chore(Auth): move the auth library to the mono repo. - #9514
Open
Hectorhammett wants to merge 1131 commits into
Open
chore(Auth): move the auth library to the mono repo.#9514Hectorhammett wants to merge 1131 commits into
Hectorhammett wants to merge 1131 commits into
Conversation
…esidency checks (#682)
# Conflicts: # Auth/src/Credentials/GCECredentials.php # Auth/tests/ApplicationDefaultCredentialsTest.php # Auth/tests/Credentials/AppIdentityCredentialsTest.php # Auth/tests/Credentials/ExternalAccountAuthorizedUserCredentialsTest.php # Auth/tests/Credentials/ExternalAccountCredentialsTest.php # Auth/tests/Credentials/GCECredentialsTest.php # Auth/tests/Credentials/IAMCredentialsTest.php # Auth/tests/Credentials/ImpersonatedServiceAccountCredentialsTest.php # Auth/tests/Credentials/InsecureCredentialsTest.php # Auth/tests/Credentials/RegionalAccessBoundaryTraitTest.php # Auth/tests/Credentials/ServiceAccountCredentialsTest.php # Auth/tests/Credentials/ServiceAccountJwtAccessCredentialsTest.php # Auth/tests/Credentials/UserRefreshCredentialsTest.php # Auth/tests/CredentialsLoaderTest.php # Auth/tests/FetchAuthTokenCacheTest.php # Auth/tests/OAuth2Test.php # Auth/tests/ObservabilityMetricsTest.php
Hectorhammett
added
the
do not merge
Hectorhammett
force-pushed
the
move-auth
branch
from
August 21, 2026 21:01
851e7b3 to
263d7b4
Compare
bshaffer
reviewed
Aug 25, 2026
| @@ -258,10 +258,6 @@ private function validateComponentFiles(): void | |||
| $this->namespaces = $namespaces; | |||
|
|
|||
| $this->componentDependencies = []; | |||
| // All components depend on google/auth | |||
| if ($this->name !== 'auth') { | |||
| $this->componentDependencies[] = new Component('auth', self::ROOT_DIR . '/dev/vendor/google/auth'); | |||
Contributor
There was a problem hiding this comment.
we should keep this, but instead it should be:
$this->componentDependencies[] = new Component('Auth');And you'll need to update the above conditional to be $this->name !== 'Auth'
| @@ -8,7 +8,6 @@ language: "php" | |||
| distribution_name: "google/cloud-vision" | |||
| github_repository: "googleapis/google-cloud-php-vision" | |||
| issue_tracker: "https://github.com/googleapis/google-cloud-php-vision/issues" | |||
| xrefs: "devsite://php/auth" | |||
Contributor
There was a problem hiding this comment.
If we make the above change to Component, this will not be removed (which is what we want)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are making an effort to move all of our libraries into the mono repo.
This depends on:
googleapis/google-auth-library-php#683
This PR should basically mirror all the changes done on the auth library PR to keep the history clean.