UI polish: design-system + a11y audit sweep (stacked on #65) - #66
Merged
Conversation
Multi-agent audit (48 findings, adversarially triaged) against the amicode design system and ui-ux-pro-max critical checklists. Fixes: Tokens: update pill off the grey-on-light icon-accent color-mix fills onto --accent-fill-soft/--accent-edge; connections project rows off banned v1 vars (--border-weak-base/--surface-base); ask-card selected edge onto --accent-edge; new --accent-fill-hover token replaces two hand-rolled accent mixes; titlebar tabs onto the radius scale; channel badge raw hex dropped; run-gallery scrim into the 40-60% band. Type scale: off-scale weights (450/530/550/640/750/800) and sizes (9/11.5/12.5/15px) across solver-toggle, defaults-capsule, amicode.css, home-cards onto the sanctioned scales; off-grid paddings/gaps onto the 4px grid. Interaction: bounds-moving press/hover transforms (translateY) replaced with elevation/fill feedback; hover+focus-visible states added to yellow CTA, action cards, rail inspect/retry, starter chips, suggestion rows; busy save button gets wait cursor + reduced emphasis; sub-150ms transitions raised; MeetAmico shine + lift gated on reduced motion. A11y: onboarding-wizard inputs no longer strip the focus outline; action cards and MeetAmico are keyboard-operable (role, tabIndex, Enter/Space); profile inputs get real labels; edit-profile toggle gets aria-label/expanded; vault-panel text-glyph arrows replaced with the icon family; context-tree legend unhidden from AT; vault mount chips join the accent selected pattern. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
kateebonner
force-pushed
the
kate/ui-polish-audit
branch
from
July 27, 2026 21:49
836185f to
99f2eff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #65 — merge that first; this branch contains its commits. The diff unique to this PR is the last commit.
A multi-agent audit of the amicode UI surfaces against the design system (tokens, yellow law, geometry, both-themes) and the ui-ux-pro-max critical checklists (accessibility, interaction states, motion). 48 raw findings, adversarially triaged; the confirmed + solo-verified set is fixed here across 14 files.
Token conformance
icon-icon-accentcolor-mix fills onto--accent-fill-soft/--accent-edge; focus ring restored (wasoutline-none).--border-weak-base/--surface-basev1 vars → v2 tokens (selected state already on the accent pair — now both states speak one token system).--accent-edge; run-gallery scrim 62% → 50%; titlebar tabsrounded-[6px]→rounded-md; channel badge raw#FFFdropped.--accent-fill-hovertoken (one step past soft, per-scheme) replaces two hand-rolled accent mixes (widget pin hover, MeetAmico shine).Interaction states
translateY(cards, ask options, MeetAmico lift).amc-secondary-btnrecipe).prefers-reduced-motion.Accessibility
aria-label/aria-expanded; context-tree legend unhidden from AT; vault-panel text-glyph arrows (▾/▸) replaced with the icon family; vault mount chips join the accent selected pattern.Deferred (flagged, not rushed)
Combobox semantics + arrow-key nav for the institution autocomplete; keyboard navigation of context-tree canvas nodes; "Amico remembers" tooltip-only details; consolidating the three profile-input recipes; the solver toggle's ⚡ emoji (intentional design flair — flagging per the no-emoji-icons rule, your call).
Verification: typecheck clean (app, ui), 787 tests green, lint 0 errors.
🤖 Generated with Claude Code