UI polish: deferred a11y items (stacked on #66) - #67
Merged
Conversation
Multi-agent audit (48 findings, adversarially triaged) against the amicode design system and ui-ux-pro-max critical checklists. Fixes: Tokens: update pill off the grey-on-light icon-accent color-mix fills onto --accent-fill-soft/--accent-edge; connections project rows off banned v1 vars (--border-weak-base/--surface-base); ask-card selected edge onto --accent-edge; new --accent-fill-hover token replaces two hand-rolled accent mixes; titlebar tabs onto the radius scale; channel badge raw hex dropped; run-gallery scrim into the 40-60% band. Type scale: off-scale weights (450/530/550/640/750/800) and sizes (9/11.5/12.5/15px) across solver-toggle, defaults-capsule, amicode.css, home-cards onto the sanctioned scales; off-grid paddings/gaps onto the 4px grid. Interaction: bounds-moving press/hover transforms (translateY) replaced with elevation/fill feedback; hover+focus-visible states added to yellow CTA, action cards, rail inspect/retry, starter chips, suggestion rows; busy save button gets wait cursor + reduced emphasis; sub-150ms transitions raised; MeetAmico shine + lift gated on reduced motion. A11y: onboarding-wizard inputs no longer strip the focus outline; action cards and MeetAmico are keyboard-operable (role, tabIndex, Enter/Space); profile inputs get real labels; edit-profile toggle gets aria-label/expanded; vault-panel text-glyph arrows replaced with the icon family; context-tree legend unhidden from AT; vault mount chips join the accent selected pattern. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…av, disclosures, one input recipe - Institution autocomplete is a real combobox: role/aria-expanded/ aria-activedescendant, arrow-key navigation, Enter picks, Escape closes; options are listbox options with an active highlight. - Context tree is keyboard-operable: the canvas takes focus, arrows walk the tree's flat order, Home/End jump, Enter/Space opens the focused node; the engine gained focus(id) and an aria-live region announces each node. role=img corrected to role=application. - 'Amico remembers' details unfold inline as disclosures instead of hiding in a hover-only title tooltip. - ONE text-input recipe: .amc-input (+ --compact) in amicode.css replaces the three divergent inline recipes across the onboarding wizard, profile editor, and connections forms — focus ring included so no caller ever strips an outline again. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
kateebonner
force-pushed
the
kate/ui-polish-deferred
branch
from
July 27, 2026 21:49
5c28312 to
b183578
Compare
kateebonner
added a commit
that referenced
this pull request
Jul 27, 2026
Vault browser replaces git review in the session side panel (stacked on #67)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #66 (which stacks on #65) — the diff unique here is the last commit.
The four items deferred from the #66 audit, done properly:
role=combobox+aria-expanded/aria-controls/aria-activedescendanton the input,listbox/optionsemantics on the dropdown, ArrowUp/Down navigation with a visible active highlight, Enter picks, Escape closes. The ⌘V paste fallback still rides the same keydown.role=application); arrow keys walk the tree in draw order, Home/End jump, Enter/Space opens the focused node (file tab or Vault panel — same paths as clicking). The engine gainedfocus(id)(camera-glance + ring, label raised), and a visually-hiddenaria-liveregion announces each focused node.aria-expanded, instead of living in a hover-onlytitletooltip invisible to keyboard and touch..amc-input(+--compact) class replaces the three divergent inline recipes (onboarding wizard, profile editor, connections credential forms — 14 inputs). Focus ring and disabled/placeholder styles are part of the recipe.Still open by choice: the solver toggle's ⚡ emoji (needs Kate's call).
Verification: typecheck clean (app, ui), 787 tests green, lint 0 errors.
🤖 Generated with Claude Code