Repository navigation
Make ReplayKit smoke tests portable and restore strict Rust checks - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collector integration tests pulled in native TLS/OpenSSL despite using local HTTP only. The persistence smoke depended on undeclared netcat and launched cargo wrapper processes, making cleanup/restart less reliable; strict Rust lint also failed on an unused test import.
Disable reqwest default features for the local-HTTP dev dependency and update the lockfile. Run the built collector/API binaries directly from the smoke, replace netcat with Bash TCP readiness checks, retain service logs for failures, and anchor the script to the repository root. Fix the existing strict-lint import and formatting failures.
Validation: 161 Rust tests pass (one pre-existing ignored doctest); cargo fmt and strict workspace/all-target clippy pass. Frontend: 69 tests, ESLint, and production build pass. Real collector → API → span tree → API restart → SQLite/blob persistence smoke passes. git diff --check passes.
Scope: no browser interaction, Docker runtime, or external agent/provider replay was exercised. Actual UI recording remains held pending browser verification; real CLI/collector/API persistence is verified.
Published exact-head CI also passes Rust, Web, and Docker. Docker job logs confirm both the collector and API responded after container startup; this remains a startup check, not full browser integration.