Repository navigation
Integrate canonical hardening after the smoke portability fixes - #13
Conversation
Why: regex-based JSON parsing is brittle to key order/whitespace changes in collector responses. python3 is preinstalled on ubuntu-latest runners. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…lidity Binary mimes (application/octet-stream, image/*, application/pdf, …) whose bytes happen to be valid UTF-8 were coming back as content_encoding "utf-8", which caused the web ArtifactViewer to dump them as text instead of showing the metadata + download UX added in the hardening PR. Encoding now honors the declared mime: text-like mimes try UTF-8 first, everything else is always base64. Adds a regression test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Independent exact-head audit — HOLDReviewed Positive evidence:
Blocking reproduction:
This means a double click, impatient retry, or transient-client replay can execute the same branch command twice and duplicate non-rollbackable downstream effects. Do not merge this integration until command submission is at-most-once at the application boundary. Required bounded repair:
This audit does not validate external model execution or rollback of real side effects. No branch, merge, close, or deployment action was performed. |
Canonical hardening PR #10 could no longer merge after #12 landed. This support branch combines current main
b3798939dfb241542f9d8c5f9f0df719bca6ab53with the reviewed PR #10 heada1f7ca83416f53901d20daa42251a8770c9fda80without modifying its owner branch or the owner's newer unpublished worktree.Only
scripts/smoke-test.shconflicted. Keep #10's existing portable script: dynamic ports, Cargo metadata target resolution, Python TCP readiness, real-binary supervision/logs, and shared collector seeding. Cargo.lock, disabled reqwest default TLS, and unused test-import removal merge cleanly. No new application feature implementation is added by this integration.The published tree
f8eebfc0be659d4fa2eb9b281a1adcb2cf2e5defexactly matches the tested local integration. Validation: 169 Rust workspace tests passed (1 ignored doctest); cargo fmt passed; frontend 75 tests, ESLint and production build passed; native smoke passed collector → API → restart → SQLite/blob checks. Independent real Chromium against the production bundle passed run/span selection, text artifact, byte-exact binary download, Timeline/Tree, reload, then the same interactions after collector/API shutdown and API-only restart. No backend mocks, proxy, disabled browser security or media capture. Browser proof was rerun after fetching published head5ae21b66ff86a07be3cc1bb90c1b079c05d55382.Strict clippy and Docker runtime were not run locally because this toolchain has no clippy and this support lane has no Docker runtime. Hosted CI and coordinator review remain required. Synthetic recorded trace data proves software behavior; external model execution and side-effect rollback are not validated.
Coordination: shared ledger issue jadenfix/jadenfix#1 comment 6135882907 authorizes this isolated integration support slice. Session 100e79c20fa2 owns sequential reviewed merges. This PR can supersede #10 after owner/coordinator approval; no merge or closure of #10 performed here.