[akrem-chabchoub]

closes: #860
related: #1010
blocked by: #1043

Summary

Wire the workspace kind selection step to hide kinds when the API returns ruleEffects.uiHide: true, while keeping kinds visible when ruleEffects is missing .
GET /workspacekinds?namespaceFilter=… is already used from the wizard via useWorkspaceKinds(namespace) (#1010)

What changed

• WorkspaceFormKindList: filter kinds before the name filter — drop hidden and ruleEffects.uiHide, then apply the existing toolbar filters.
• data-contracts: optional ruleEffects on workspace kinds (uiHide, aclDeny). Stubbed in the generated contracts until swagger is updated; remove the TODO and run npm run generate:api once the spec includes it.
• mockBuilder: default ruleEffects on buildMockWorkspaceKind so mocks match the new shape.
• Tests: unit tests for uiHide / missing ruleEffects and Cypress tests.

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign paulovmr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• workspaces/frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[akrem-chabchoub]

CI is failing. The frontend workflow runs npm run generate:api, which regenerates src/generated/data-contracts.ts from workspaces/backend/openapi/swagger.json and removes any hand-edited types not present in swagger, including the ruleEffects stub in this PR.

Maybe I can add those fields in backend (temporarly) ?

[thaorell]

Hi @akrem-chabchoub , thank you for opening the PR. Yes I do believe the change should happen in the backend first. The types in data-contracts.ts describe the communication between the frontend and backend. It is autogenerated by running npm run generate:api and should not be manually fixed.
Any change should happen in the swagger.json file in the backend. The frontend can then detect the change in swagger.version file and then you can run npm run generate:api

[akrem-chabchoub]

@thaorell Thanks!
I made the implementation in backend side in #1043 to include ruleEffects.

Now once its merged we can link the commit to swagger.version and generate the data contracts.

[andyatmiami]

/hold

need to work with @akrem-chabchoub (and update issues/writeups) to reflect a slight change in requirements on how we want this implemented.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed if no further activity occurs.
Thank you for your contributions.

Members may comment /lifecycle frozen to prevent this pull request from being marked as stale.

[github-actions]

This pull request has been automatically closed because it has not had recent activity.
You can reopen the PR if you want.