Repository navigation
feat: Stub ruleEffects on workspacekinds list API - #1244
christian-heusel wants to merge 1 commit into
Conversation
Add a hard-coded `ruleEffects: {"uiHide": false}` attribute to each item
of the `GET /api/v1/workspacekinds` list response. This is a stub for
the Compatibility Selectors feature that establishes the response schema
the frontend can code against, without implementing the WorkspaceKind
filterRules evaluation itself.
`uiHide` is always false and is included regardless of whether the
`namespaceFilter` query parameter is provided.
Assisted-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Christian Heusel <christian@heusel.eu>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/close |
|
@christian-heusel: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
github-project-automation
Bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
Add a hard-coded
ruleEffects: {"uiHide": false}attribute to each itemof the
GET /api/v1/workspacekindslist response. This is a stub forthe Compatibility Selectors feature that establishes the response schema
the frontend can code against, without implementing the WorkspaceKind
filterRules evaluation itself.
uiHideis always false and is included regardless of whether thenamespaceFilterquery parameter is provided.Closes #838
Related #1043 #1033