Skip to content

Logging should be streamlined #291

Closed

Description

@vincepri

The current controller runtime offers a log package that includes a zap logger and lets users to bring their own logger by implementing https://github.com/go-logr/logr interfaces. Most of the other tools in the Kubernetes ecosystem use klog as the main logging point, which makes it hard to have a single output and logger given that klog doesn't expose any interface that implements logr interfaces.

Some related issues in the community:

Activity

  1. DirectXMan12 commented on Jan 15, 2019

    @DirectXMan12
    Contributor

    github.com/go-logr/glogr should be trivially adaptable to klog (it was originally written for glog). We'll see how klog evolves, but getting that situation squared away is something I would definitely like to do.

  2. DirectXMan12 commented on Jan 15, 2019

    @DirectXMan12
    Contributor

    /priority important-soon

  3. added
    priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.
    on Jan 15, 2019
  4. DirectXMan12 commented on Mar 6, 2019

    @DirectXMan12
    Contributor

    kubernetes/klog#37 at least partially solves this problem with its klogr package. The other half is being worked on it kubernetes/klog#20.

  5. added a commit that references this issue on Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions