Repository navigation
fix(Board): end a handle's keyboard activation on a press elsewhere - #103
Merged
Merged
Conversation
Contributor
PR Analysis Report📚 Storybook PreviewGitHub Pages may take up to a minute to hydrate after the deploy. 🧩 Changed Components
📦 Bundle Size
Total gzip (JS + CSS): 197.2 kB (+0.1 kB vs Generated by the PR Preview workflow for |
lablup-octodog
temporarily deployed
to
release
October 27, 2026 06:40 — with
GitHub Actions
Inactive
Contributor
|
Preview published under the pnpm add @lablup/ui-common@0.2.0-alpha.20.pr-103-20261027071136-f36a9a259
pnpm add -D @lablup/ui-common-cli@0.2.0-alpha.20.pr-103-20261027071136-f36a9a259In backend.ai-webui: |
Contributor
Author
Ready-gate agent review (Opus) — blocking issues only
The fix landed after this review and was not re-reviewed; |
lablup-octodog
marked this pull request as ready for review
October 27, 2026 06:44
lablup-octodog
temporarily deployed
to
release
October 27, 2026 06:46 — with
GitHub Actions
Inactive
A click on a move or resize handle without a drag activates it for arrow keys and direction buttons. The activation ended only on Enter, Escape or the handle's blur, and a press elsewhere inside the board did not always blur the handle, so the item stayed active and kept reacting to the arrow keys. While a keyboard activation is on, a capture-phase pointerdown on the document now commits it unless the press lands on the active handle or its direction buttons; focus stays where the press put it.
Add a Board test for a press that leaves focus on the activated handle: the existing test moves focus to the pressed button, so the handle's blur commits it and the test passed without the new pointerdown listener.
Rebased onto main. #68 dropped renderItem and the per-item remove button, so the outside-press test now presses a button placed in another item's description.
lablup-octodog
force-pushed
the
fix/gh-102-board-clicking-a-handle-leaves
branch
from
October 27, 2026 07:11
6ab779b to
f36a9a2
Compare
lablup-octodog
temporarily deployed
to
release
October 27, 2026 07:14 — with
GitHub Actions
Inactive
This was referenced Oct 27, 2026
Open
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #102
Resolves #101
Summary
Board: while a handle is activated for keyboard steps (a click without a drag, or Enter / Space), a capture-phasepointerdownlistener on the document commits the activation — the same path as Enter and blur — when the press lands anywhere but the active handle and its direction buttons, inside the board or not.Board.test.tsx, and aCHANGELOG.mdentry under[Unreleased] / Fixed.mainafter feat(Board)!: items are a title and a description, padded by the board #68 (items are a title and a description): the tests press elements that exist in that structure.Why
Clicking a Board item's move or resize handle without dragging puts the item in keyboard mode. That mode ended only on Enter, Escape or the handle's blur, and a press elsewhere inside the board did not always move focus off the handle. The item kept its active outline and kept moving or resizing on the arrow keys (the dashboard in backend.ai-webui, which renders this Board, shows it). #101 reports the same symptom and is closed by this PR too. backend.ai-webui picks the fix up with the next
@lablup/ui-commonrelease.Test plan
src/components/Board/Board.test.tsx›pointer:Verification