Repository navigation
test(responses): register thinking recovery owner for #7147 - #7221
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
I reviewed the complete one-line diff at The missing_coauthor_credit result is a false positive from the sentence saying this child does not carry a second copy of #7147. I am applying attribution-approved only for that original inventory correction, with this rationale. It does not waive regression coverage, current-head CI, parent review, or merge policy. Keep the child on its open parent for now. Its author-recorded red/green and six-consumer coverage are in Verification; I did not rerun tests or approve/merge the PR in this pass. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. Hygiene✅ Deterministic PR hygiene checks passed. |
3eed767
into
lidge-jun:fix/7098-thinking-binding-recovery
Summary
anthropic-thinking-recovery.tsin the Responses core source inventory. This fixes the module-boundary CI failure introduced by fix(anthropic): recover rejected thinking without local prefix validation #7147 without changing runtime behavior or weakening the guard.fix/7098-thinking-binding-recoveryate015627576bf4ea5ab9c0576761a4d595f79b8b8. It does not carry a second copy of fix(anthropic): recover rejected thinking without local prefix validation #7147 intodev.Verification
Bun 1.4.3. Tested tree matches fork commit
a71aa0583461e6a7862e086e50b0ffeafcfa3491(changed-file blob968416117a70e6cbb590c21ea9675c163b533655). Commands ran on an isolated dot-cloud checkout with no user account or device involved.bun scripts/test.ts --parallel=1 tests/responses/responses-core-modules.test.tsfailed on the original head with 9 passed / 1 failed at line 44. The assertion identified the missing recovery module.bun scripts/test.ts --parallel=1 tests/responses/responses-core-modules.test.ts tests/lib/reasoning-replay-scope-source.test.ts tests/oauth/generic-oauth-failover.test.ts tests/server/passive-route-linker.test.ts tests/responses/responses-passthrough-transient-policy.test.ts tests/lab/lab-passive-production-evidence.test.ts— 112 passed / 0 failed, 711 assertions. These are every direct consumer of the source-inventory helper.bun scripts/test.ts --parallel=1 tests/test-layout.test.ts tests/test-layout-tooling.test.ts tests/ci-workflows/file-size-ratchet.test.ts— 36 passed / 0 failed, 653 assertions.bun run typecheck,bun run structure:check,bun run privacy:scan, andgit diff --check— passed.env -i HOME=/tmp PATH="$BUN_DIR:/usr/bin:/bin" OCX_TEST_RUNNER_BUN="$BUN"; the repository runner supplied its normal per-run/per-file HOME isolation and queue controls.mainandpreview. PR CI may require maintainer approval; no hosted CI pass is claimed.test:changedruns were not performed: the one-line test-inventory change has six explicit consumers, all covered above, and broad runtime validation would be disproportionate amid concurrent work. Exact-head CI and maintainer acceptance remain required. No full-suite or cross-platform pass is claimed.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.