Skip to content

test(responses): register thinking recovery owner for #7147 - #7221

Merged
lidge-jun merged 1 commit into
lidge-jun:fix/7098-thinking-binding-recoveryfrom
lcxhh521:fix/7147-thinking-module-inventory
Oct 17, 2026
Merged

lidge-jun merged 1 commit into
lidge-jun:fix/7098-thinking-binding-recoveryfrom
lcxhh521:fix/7147-thinking-module-inventory

Conversation

@lcxhh521

@lcxhh521 lcxhh521 commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Verification

Bun 1.4.3. Tested tree matches fork commit a71aa0583461e6a7862e086e50b0ffeafcfa3491 (changed-file blob 968416117a70e6cbb590c21ea9675c163b533655). Commands ran on an isolated dot-cloud checkout with no user account or device involved.

  • Red/green: bun scripts/test.ts --parallel=1 tests/responses/responses-core-modules.test.ts failed on the original head with 9 passed / 1 failed at line 44. The assertion identified the missing recovery module.
  • bun scripts/test.ts --parallel=1 tests/responses/responses-core-modules.test.ts tests/lib/reasoning-replay-scope-source.test.ts tests/oauth/generic-oauth-failover.test.ts tests/server/passive-route-linker.test.ts tests/responses/responses-passthrough-transient-policy.test.ts tests/lab/lab-passive-production-evidence.test.ts — 112 passed / 0 failed, 711 assertions. These are every direct consumer of the source-inventory helper.
  • bun scripts/test.ts --parallel=1 tests/test-layout.test.ts tests/test-layout-tooling.test.ts tests/ci-workflows/file-size-ratchet.test.ts — 36 passed / 0 failed, 653 assertions.
  • bun run typecheck, bun run structure:check, bun run privacy:scan, and git diff --check — passed.
  • The test commands used env -i HOME=/tmp PATH="$BUN_DIR:/usr/bin:/bin" OCX_TEST_RUNNER_BUN="$BUN"; the repository runner supplied its normal per-run/per-file HOME isolation and queue controls.
  • Before this PR opened, the exact fork commit had no workflow runs or check runs: the CI push trigger only includes main and preview. PR CI may require maintainer approval; no hosted CI pass is claimed.
  • Full-suite and test:changed runs were not performed: the one-line test-inventory change has six explicit consumers, all covered above, and broad runtime validation would be disproportionate amid concurrent work. Exact-head CI and maintainer acceptance remain required. No full-suite or cross-platform pass is claimed.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed. No runtime or user-facing change requires a documentation update.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. No such source, workflow, or dependency changes are included.

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

  • Required local validation passed; commands, results, and any full-suite exception are documented.

  • I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). intake: hygiene-blocked Deterministic PR hygiene checks failed labels Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Deterministic hygiene checks failed.

  • missing_coauthor_credit — This pull request says it reimplements, supersedes, carries, or rebases another author's pull request, but no Co-authored-by trailer names that author. Prose in a commit body is not read by anything; the trailer is what GitHub counts. Add it to the description or a commit, or obtain attribution-approved. Paths: #7147.

@Ingwannu

Copy link
Copy Markdown
Owner

I reviewed the complete one-line diff at a71aa0583461e6a7862e086e50b0ffeafcfa3491 against its open parent fix/7098-thinking-binding-recovery@e015627576. It adds the existing recovery module to the test source inventory; it does not copy/reimplement the parent's runtime change.

The missing_coauthor_credit result is a false positive from the sentence saying this child does not carry a second copy of #7147. I am applying attribution-approved only for that original inventory correction, with this rationale. It does not waive regression coverage, current-head CI, parent review, or merge policy.

Keep the child on its open parent for now. Its author-recorded red/green and six-consumer coverage are in Verification; I did not rerun tests or approve/merge the PR in this pass.

@Ingwannu Ingwannu added the attribution-approved Maintainer approved a carry whose original author is not named in a trailer label Oct 16, 2026
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • review readiness checklist open (0/4 boxes ticked).

What to do

  • Tick all four boxes in the PR description once you're done (currently 0/4).

Review readiness checklist

  • ⬜ Required local validation passed; commands, results, and any full-suite exception are documented.
  • ⬜ I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
  • ⬜ I resolved all correct Codex and CodeRabbit findings.
  • ⬜ My PR is ready for review.

0/4 boxes ticked.

This PR stays in draft until every box above is ticked.

Hygiene

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot removed the intake: hygiene-blocked Deterministic PR hygiene checks failed label Oct 16, 2026
@lidge-jun
lidge-jun merged commit 3eed767 into lidge-jun:fix/7098-thinking-binding-recovery Oct 17, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attribution-approved Maintainer approved a carry whose original author is not named in a trailer chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants