Skip to content

feat: add workflow to notify when a PR need review on Slack - #337

Merged
GabrielePicco merged 3 commits into
masterfrom
feat/add-slack-notification-workflow
Apr 3, 2025
Merged

GabrielePicco merged 3 commits into
masterfrom
feat/add-slack-notification-workflow

Conversation

@GabrielePicco

@GabrielePicco GabrielePicco commented Apr 2, 2025 •

Copy link
Copy Markdown
Collaborator

Description

  • Add workflow to notify when a PR need review on Slack

Greptile Summary

This pull request introduces a new GitHub Actions workflow to notify reviewers on Slack when a PR review is requested.

  • Added new Slack notification workflow in /.github/workflows/slack-notify.yml using slackapi/slack-github-action@v1.24.0
  • Configured event trigger on "review_requested", capturing essential PR details (title, URL, and requester)
  • Uses secret SLACK_WEBHOOK_URL for secure webhook communication.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a GitHub Actions workflow that sends a Slack notification when a pull request receives a review request.

  • Adds a new workflow configuration that listens to pull_request review_requested events.
  • Configures the Slack GitHub Action to send a formatted message with PR details to a specified Slack channel.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@GabrielePicco
GabrielePicco merged commit 2aaf360 into master Apr 3, 2025
@GabrielePicco
GabrielePicco deleted the feat/add-slack-notification-workflow branch April 3, 2025 15:18
thlorenz added a commit that referenced this pull request Apr 13, 2025
* master:
  Validator integration with Domain registry contract (#321)
  Ledger purgatory (#332)
  fix(accountsdb): cast block size and block count to u64 before comput… (#341)
  Enforce nightly fmt check. + formatting (#339)
  feat: add workflow to notify when a PR need review on Slack (#337)
  fix: commit changes after standalone index del method invocation (#340)
  fix: prevent empty sysvar cache states, by rolling over the old cache (#333)
snawaz added a commit that referenced this pull request Nov 10, 2026
Pin RedSuite to 1488223536910cbddbb8550aa644ce196c709574 so CI
exercises the foreign-account settlement fixture fix from PR #337.
The fixture now supplies the validator fee vault and reaches the intended
ownership checks after scheduling-fee validation moved earlier.

The shared RedSuite action uses this revision for correctness and security
checks, as well as release benchmarks. Its source-SHA cache keys ensure
that the previous runner and fixture artifacts are not reused.

RedSuite PR: magicblock-labs/redsuite#337

Validation: action YAML parsing and git diff --check passed. The pinned
RedSuite commit's settlement_lifecycle scenario passed locally against
this validator branch before this configuration-only change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants