You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: provide the fee vault in foreign settlement tests - #337
The foreign-account settlement test omitted the fee vault. With validator #1920, fee accounts are checked earlier, so the test fails with MissingAccount before reaching the ownership checks.
Supply the current validator’s fee vault in both commit and undelegation cases. The existing ownership errors and unchanged-account assertions still verify that foreign accounts cannot be settled.
Integration
Validator #1920 now pins CI to this fix (1488223). Its CI run passed with the updated fixture.
The foreign-ownership scenario delegates its payer to the current validator
but builds settlement requests without that validator's fee vault. After
validator PR #1920 validates fee accounts before preparing the intent, these
requests fail with MissingAccount before reaching the ownership checks.
Build the existing commit and undelegation requests with an IntentBundle
that includes the current validator's fee vault. Keep the foreign cell,
expected IllegalOwner/ReadonlyDataModified errors, and unchanged-account
assertions so the scenario isolates foreign delegation rather than relying
on validation order.
Context: magicblock-labs/magicblock-validator#1920
Pin RedSuite to 1488223536910cbddbb8550aa644ce196c709574 so CI
exercises the foreign-account settlement fixture fix from PR #337.
The fixture now supplies the validator fee vault and reaches the intended
ownership checks after scheduling-fee validation moved earlier.
The shared RedSuite action uses this revision for correctness and security
checks, as well as release benchmarks. Its source-SHA cache keys ensure
that the previous runner and fixture artifacts are not reused.
RedSuite PR: magicblock-labs/redsuite#337
Validation: action YAML parsing and git diff --check passed. The pinned
RedSuite commit's settlement_lifecycle scenario passed locally against
this validator branch before this configuration-only change.
Reviewing files that changed from the base of the PR and between 1488223 and 1488223.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
The foreign-ownership test now creates an intent bundle with the outsider as payer, the ER identity as validator, and a commit for the foreign cell and outsider. This replaces direct construction of a settlement instruction.
Changes: Foreign-ownership test
Layer / File(s)
Summary
Build the settlement intent bundle redshift/src/scenarios/committor/settlement_lifecycle.rs
The test imports Commit and IntentBundle. It creates an intent bundle with the outsider as payer, the ER identity as validator, and a commit for the foreign cell and outsider.
magicblock-labs/redsuite#272: Adds authorization tests for mixed-owner settlement, including commit and undelegation paths.
Suggested labels:rust
Suggested reviewers:bmuddha
Merge Risk: Minimal · up to 14882
No actionable merge-blocking risk was identified.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly describes the change: providing the fee vault in foreign settlement tests.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description explains that the test now supplies the fee vault in commit and undelegation cases to reach the ownership checks.
Full details: Docstring Coverage
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
CI annotation context is incomplete: annotation collection unavailable or limited
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The foreign-account settlement test omitted the fee vault. With validator #1920, fee accounts are checked earlier, so the test fails with
MissingAccountbefore reaching the ownership checks.Supply the current validator’s fee vault in both commit and undelegation cases. The existing ownership errors and unchanged-account assertions still verify that foreign accounts cannot be settled.
Integration
Validator #1920 now pins CI to this fix (
1488223). Its CI run passed with the updated fixture.