[RFR] Disable the Export button when there is nothing to export - #2595
Merged
Merged
Conversation
Member
|
Nice! Don't forget to add the |
Luwangel
changed the title
djhi
suggested changes
Nov 30, 2018
djhi
left a comment
djhi
left a comment
Contributor
There was a problem hiding this comment.
Nice! Missing an update to the documentation though: https://github.com/marmelab/react-admin/blob/master/docs/List.md#actions
Luwangel
force-pushed
the
disable-export-no-data
branch
from
December 4, 2018 13:07
b15cfdb to
3419db6
Compare
Member
|
Thanks! |
Member
|
@Luwangel You change triggers a warning on Mobile in the simple example (because the Export button is minimized, and uses a tooltip). Would you mind taking a look? |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this issue #2483
Todo