Skip to content

[RFR] Fix warning when disabling a button on small devices - #2731

Merged
fzaninotto merged 1 commit into
nextfrom
fix-disabled-button-warning
Jan 7, 2019
Merged

fzaninotto merged 1 commit into
nextfrom
fix-disabled-button-warning

Conversation

@Luwangel

@Luwangel Luwangel commented Jan 7, 2019

Copy link
Copy Markdown
Contributor

With Material UI, it is not possible to wrap a disabled IconButton inside a Tooltip.

<Tooltip title={translate(label, { _: label })}>
    <IconButton
        aria-label={translate(label, { _: label })}
        color={color}
        disabled // This is not allowed
    >
        {children}
    </IconButton>
</Tooltip>

The PR #2595 causes this issue when there are not data to export.

Todo

  • Don't display the Tooltip on small devices when the IconButton is disabled

peek 07-01-2019 10-12

@Luwangel Luwangel added the bug label Jan 7, 2019
@Luwangel
Luwangel requested a review from fzaninotto January 7, 2019 09:24
@fzaninotto
fzaninotto merged commit 302a1a1 into next Jan 7, 2019
@fzaninotto
fzaninotto deleted the fix-disabled-button-warning branch January 7, 2019 09:43
@fzaninotto fzaninotto added this to the 2.6.0 milestone Jan 7, 2019
@fzaninotto fzaninotto removed the bug label Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants