[ra-input-rich-text] Do not show error message, if input isn't touched - #3208
Merged
djhi merged 1 commit intoMay 9, 2019
Merged
Conversation
djhi
approved these changes
May 9, 2019
Contributor
|
Thanks! |
Member
|
Something is wrong with this patch. If the form is submitted but the user didn't touch the field, I expect the error message to show up. Now it doesn't do that anymore. Please open a new PR to fix that or I'll have to revert this patch. |
Contributor
Author
|
I suppose, it's because of |
Contributor
Author
|
@fzaninotto checked it, it is fixed by #3209 |
Member
|
#3209 breaks other things, I can't merge it. So I'm going to roll back this one. |
Member
|
Superseded by #3223 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3207