[RichTextInput] add tests and fix bugs - #3223
Merged
Merged
Conversation
when removing event listener, it's important to pass same function as argument. This PR makes sure, that onTextInput is the same function when adding and removing event listener
they broke because body input is not required
This was referenced May 15, 2019
This was referenced May 16, 2019
2 tasks
Contributor
Author
|
Let me know If there's anything blocking this PR from merging |
djhi
approved these changes
May 22, 2019
djhi
suggested changes
Jun 5, 2019
| }); | ||
|
|
||
| it('should not show rich text input error message when field is untouched', () => { | ||
| cy.get('.ra-input-body .ra-rich-text-input > p').should('not.exist'); |
Contributor
There was a problem hiding this comment.
Looking for a p seems fragile. Would you mind adding a className (error ?) on the FormHelperText used to display validation errors?
djhi
approved these changes
Jun 5, 2019
Contributor
Author
|
@djhi can you rerun travis ci build? It's failed because of timeout error:
which seems to be caused by network issues. e2e tests are passing locally. |
fzaninotto
approved these changes
Jun 13, 2019
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #3209 (comment), I've added tests.
Fixes #3206, #3207 and #3209 (comment)
Closes #3209, #3221 and #3208 patches, since it contains them all.