[RichTextInput] Fix debouncing - #3221
Closed
cherniavskii wants to merge 1 commit into
Closed
cherniavskii wants to merge 1 commit into
cherniavskii wants to merge 1 commit into
Conversation
when removing event listener, it's important to pass same function as argument. This PR makes sure, that onTextInput is the same function when adding and removing event listener
Kmaschta
approved these changes
May 14, 2019
Contributor
Author
|
I'll submit another PR, which will address few issues at once, as suggested in #3209 (comment) |
Member
|
Superseded by #3223 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue, described by @fzaninotto in #3209 (comment)
This PR makes sure, that
onTextInputis the same function used for adding and removing event listener.Also, it partially resolves #3220, I'll describe it better in issue comment