fix(RegionMap): load() returns actual read success instead of hardcoded true - #2917
Merged
ripplebiz merged 1 commit intoJul 13, 2026
Merged
Conversation
Previously load() returned true unconditionally on file-open success, masking truncated or corrupt /regions2 files. Additionally, the first field of each entry record (r->id) used the same success-chaining pattern as subsequent fields, so a clean EOF at a record boundary set success=false and would have been indistinguishable from real corruption once the return value was fixed. The r->id read is now split out: n==0 is a clean EOF (break, success retains its prior value from the header read), n!=sizeof(r->id) is a partial read or corruption (break, success=false). load() now returns success instead of an unconditional true, so its return value reflects the actual parse outcome. Companion fix to meshcore-dev#2372, which fixed the same return-true hardcoding in save(). (meshcore-dev#1891 originally reported this on load() but was closed when meshcore-dev#2372 landed — that PR only touched save(); this addresses the load() side.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion fix to #2372, which fixed the same `return true` hardcoding
in save(). load() has the same issue — it ignores read failures and
always returns true regardless of what happened during the read loop.
(Note: #1891 originally reported this on load(), but was closed when
#2372 landed — that PR only touched save(). This PR addresses the
load() side.)
Fix distinguishes:
a variable-length region list, success unaffected
real failure, success=false
Verified on Wio Tracker L1 Pro (companion firmware): wrote 3 regions
via `region put`, rebooted, confirmed all 3 persisted correctly after
reboot — the clean-EOF path in load() does not regress normal loads.