You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[SPEC] targets: rejects the vscode identifier that the 4.2.1 rewrite rule requires #3860
Describe the bug
After #3801, OpenAPM sec. 4.2.1 says a manifest rewrite MUST keep vscode, and apm manifest migrate writes targets: [vscode]. However, the sec. 4.2 targets row and req-tg-008 say a targets: token that is not canonical or all MUST be rejected. So a conformant third-party consumer must reject a migrated manifest that APM itself accepts. The change was also recorded as an erratum, but sec. 9.4 reserves errata for behaviour-neutral clarifications.
Expected behavior
The spec admits the preserved legacy identifier vscode under targets:, and a conformance case covers it. The MCP paths become non-normative. The target: deprecation is recorded. The erratum becomes the proposed amendment row 0.1.61.
Additional context
These are the spec-guardian fold-now items F1-F9 on #3801: #3801 (comment)
Decision: approve
Area: project
Scope: Apply the apm-spec-guardian fold-now items F1-F9 from #3801 to docs/src/content/docs/specs/openapm-v0.1.md: admit the preserved legacy identifier vscode under targets: in the sec.4.2 targets row and req-tg-008, move MCP destination paths into a non-normative note, complete the canonical set, record the target: deprecation, replace the erratum with the proposed amendment row 0.1.61, add Appendix E.5, and add the req-tg-008 conformance case.
Done when: The spec no longer requires conformant consumers to reject targets: [vscode]; the statement count stays 139; no requirement ID is added or renumbered; a req-tg-008 conformance test covers targets: [vscode]; the spec linter passes; and a delta apm-spec-guardian panel on the PR has no blocking findings.
Out of scope: The deferred items in #3859, implementation changes (#3857, #3858), and any change to published JSON Schemas.
Review contact: Daniel Meppiel (@danielmeppiel)
Activity
danielmeppiel commentedon Nov 18, 2026
Decision: approve
Area: project
Scope: Apply the apm-spec-guardian fold-now items F1-F9 from #3801 to docs/src/content/docs/specs/openapm-v0.1.md: admit the preserved legacy identifier vscode under targets: in the sec.4.2 targets row and req-tg-008, move MCP destination paths into a non-normative note, complete the canonical set, record the target: deprecation, replace the erratum with the proposed amendment row 0.1.61, add Appendix E.5, and add the req-tg-008 conformance case.
Done when: The spec no longer requires conformant consumers to reject targets: [vscode]; the statement count stays 139; no requirement ID is added or renumbered; a req-tg-008 conformance test covers targets: [vscode]; the spec linter passes; and a delta apm-spec-guardian panel on the PR has no blocking findings.
Out of scope: The deferred items in #3859, implementation changes (#3857, #3858), and any change to published JSON Schemas.
Review contact: Daniel Meppiel (@danielmeppiel)
danielmeppiel commentedon Nov 18, 2026
Context: Daniel Meppiel (@danielmeppiel) asked for a full apm-spec-guardian review of merged #3801 and for its fold-now items to land in one follow-up PR. Panel: #3801 (comment)
fix(spec): admit preserved vscode under targets: (OpenAPM 0.1.61 prop…
fix(spec): fold delta spec-guardian round 1 on 0.1.61 (#3851)
fix(spec): admit preserved vscode under targets: (OpenAPM 0.1.61 prop…
fix(spec): fold delta spec-guardian round 1 on 0.1.61 (#3851)
fix(spec): admit preserved vscode under targets: (OpenAPM 0.1.61 prop…