Repository navigation
fix(spec): admit preserved vscode under targets: (OpenAPM 0.1.61 proposed) - #3851
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the vscode alias normalization and migration-compatibility changes.
No open issues 🎉
What changed in this PR
This follow-up to #3801 aligns OpenAPM’s vscode alias rules with APM’s migration behavior, so migrated dependencies continue deploying to copilot projects without changing their MCP configuration destination.
Changes:
- Normalize plural
targets: [vscode]tocopilotin the declaration owner’s canonical view while preserving runtime selection. - Update the specification to accept
vscodeundertargets:and document the proposed amendment’s compatibility implications. - Add unit and lifecycle regression coverage for alias equivalence and unchanged deployment after migration.
| File | Description |
|---|---|
tests/unit/models/test_manifest_targets.py |
Checks canonical alias resolution for both manifest spellings. |
tests/integration/test_manifest_target_migrate_lifecycle.py |
Checks that migrating a dependency preserves deployed files. |
src/apm_cli/models/manifest_targets.py |
Normalizes plural target aliases without changing MCP selection. |
docs/src/content/docs/specs/openapm-v0.1.md |
Clarifies alias acceptance, rewrite rules, and amendment compatibility. |
CHANGELOG.md |
Records the dependency deployment fix and specification update. |
Review effort: Balanced
a318935 to
145b75c
Compare
- req-tg-008, sec 4.2.1 and the 0.1.61 row state that vscode denotes the copilot target in the effective target intersection (closes pm-blk-r1-1; no new keyword or anchor). - target: deprecation and the sec 9.5 window take effect on 9.3 adoption of 0.1.61, not on the proposal date. - The 2026-11-17 erratum is recorded as withdrawn and reclassified instead of deleted. - 0.1.61 row: provenance (#3801, #3851, #3860), narrowed deployed- behavior claim (#3861 / #3864), req-mf-005 impact of hermes/grok-bot. - Appendix E.5: schema validity does not imply req-tg-008 acceptance. - Test comment points the admission check to the narrowing xfail. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Non-normative pointer in sec 4.2.1 and the 0.1.61 row: the dependency vscode MCP-destination question and the vscode + copilot co-occurrence are tracked in #3853. Link req-tg-008 / req-mf-005 mentions in E.5 and the 0.1.61 row. No keyword, anchor or count change. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
APM Spec Guardian:
|
| Panel | Stance | Shocked | New B | New R | New N |
|---|---|---|---|---|---|
| Spec Swagger Editor | ship_with_followups | 8/10 | 0 | 1 | 2 |
| Spec OCI Editor | ship_with_followups | 8/10 | 0 | 1 | 1 |
| Spec Pkgmgr Editor | ship_with_followups | 8/10 | 0 | 1 | 1 |
| Spec TAG Architect | ship_with_followups | 8/10 | 0 | 2 | 1 |
Round 1 (head 145b75c): swagger 7 (0B/2R/2N), oci 7 (0B/1R/2N), pkgmgr 7 (1B/2R/1N, needs_revision), tag 7 (0B/2R/2N).
B = new blocking findings, R = new recommended, N = new nits.
Counts are signal strength, not gates. The maintainer ships.
Convergent themes (flagged by 2+ panels)
- R1-T1 -- req-tg-008 admitted
vscodewithout saying it denotescopilotin the intersection (supporting: pm-blk-r1-1, sw-rec-r1-1, oci-rec-r1-1, tag-rec-r1-1). Closed by F10. - R1-T2 -- The
target:deprecation clock was tied to an unadopted proposal (supporting: sw-rec-r1-2, pm-rec-r1-1, tag-rec-r1-2). Closed by F11. - R1-T3 -- The published erratum was deleted instead of withdrawn (supporting: pm-rec-r1-2, tag-nit-r1-1). Closed by F12.
- R1-T4 -- 0.1.61 row provenance and the deployed-behavior claim (supporting: sw-nit-r1-2, pm-nit-r1-1). Closed by F13 and F14.
- T1 -- The 4.2.1 body read as settled while the dependency-
vscodeMCP question andvscode+copilotco-occurrence are open (supporting: sw-rec-r2-1, oci-nit-r2-1, pm-nit-r2-1, tag-rec-r2-1). Pointer added by F19 and F20. - T2 -- Lock fields
target_subset/subset_pairingsdo not say whether they recordvscodeorcopilot(supporting: oci-rec-r2-1, pm-rec-r2-1). Deferred to [FEATURE] OpenAPM: record target aliases canonically in lock target_subset and subset_pairings #3855. - T3 -- The manifest schema
targetspattern and annotation do not express req-tg-008 admission (supporting: tag-rec-r2-2, sw-nit-r2-2). Deferred to [SPEC] Specify the target: -> targets: rewrite contract, alias table and legacy all semantics #3859.
Fold now (applied in this PR)
- [F10 / R1-T1] sec 4.2.1, req-tg-008, 0.1.61 row:
vscodedenotes thecopilottarget for target selection and in the effective target intersection. It does not activate, add, or remove any other target. - [F11 / R1-T2] sec 4.2
targetrow and 0.1.61 row: the deprecation and the sec 9.5 window start on sec 9.3 adoption. - [F12 / R1-T3] Appendix D Errata: the 2026-11-17 entry is recorded as withdrawn on 2026-11-18 and reclassified as 0.1.61.
- [F13, F14, F15 / R1-T4] 0.1.61 row: provenance (feat(manifest): deprecate target: and add apm manifest migrate #3801, fix(spec): admit preserved vscode under targets: (OpenAPM 0.1.61 proposed) #3851, [SPEC] targets: rejects the vscode identifier that the 4.2.1 rewrite rule requires #3860); deployed-behavior claim narrowed ([BUG] A dependency declaring targets: [vscode] deploys nothing to copilot projects #3861 / fix(targets): deploy a targets: [vscode] dependency to copilot projects #3864); req-mf-005 producers now accept
hermesandgrok-bot. - [F16 / standalone] Appendix E.5: schema validity does not imply req-tg-008 acceptance.
- [F17 / standalone] conformance test comment: the admission check points to the narrowing xfail.
- [F19, F20 / T1] sec 4.2.1 note and 0.1.61 row: non-normative pointer to [FEATURE] OpenAPM: a dependency's vscode target must not choose the consumer's MCP destination #3853 for both open MCP-destination questions.
- [F21, F22 / standalone] E.5 and 0.1.61 row: req-tg-008 and req-mf-005 mentions are now links.
Defer to v0.1.1
- [F18 / R1-T5] req-mf-005 and req-tg-008: producer-side
targets:token symmetry. Tracked in [SPEC] Specify the target: -> targets: rewrite contract, alias table and legacy all semantics #3859. - [F23 / T2] req-rs-018 lock fields: recorded spelling of
vscode. Tracked in [FEATURE] OpenAPM: record target aliases canonically in lock target_subset and subset_pairings #3855, aligned with [FEATURE] OpenAPM: a dependency's vscode target must not choose the consumer's MCP destination #3853. - [F24 / T3] Appendix A manifest schema: tighter proposed schema for
targetsand the description annotation. Tracked in [SPEC] Specify the target: -> targets: rewrite contract, alias table and legacy all semantics #3859. - [F25 / standalone] sec 9.4: wording about errata placement versus the now-populated Errata list. Tracked in [SPEC] Specify the target: -> targets: rewrite contract, alias table and legacy all semantics #3859 (the earlier [FEATURE] OpenAPM: align sec 9.4 with where errata are listed in Appendix D #3856 was closed as superseded).
Rejected findings
- tag-nit-r1-2 --
allappears both in the canonical block and as the req-tg-008 sentinel. This is deliberate emphasis on sentinel semantics carried over from wording already on main, and [SPEC] Specify the target: -> targets: rewrite contract, alias table and legacy all semantics #3859 will restate the grammar.
Linter (Wave 5) at dc052c4: all 11 checks pass. ASCII OK; no forbidden tokens; 140 unique req anchors (unchanged); 139 (134 MUST, 5 SHOULD) agrees across sec 1.3, Appendix C and Appendix D; links resolve; JSON schemas are byte-unchanged and pass check_schema; no mermaid; fixtures unchanged; CHANGELOG mentions openapm. Check 11 notes that a .py test file changed (the req-tg-008 conformance test), which is expected. orphan_check aligns 139. test_manifest_reqs.py reports 96 passed and 1 strict xfail (#3861).
Full per-panel findings
Spec Swagger Editor -- shocked_meter 7 -> 8/10, confidence high
Summary (r2): All four round-1 findings are closed with no change to keywords, anchors, counts or schema bytes. Remaining: the vscode + copilot MCP edge case (#3853) and two editorial nits.
- [sw-rec-r1-1] No statement of which target
vscodeselects in the intersection. Folded (F10). - [sw-rec-r1-2] Deprecation stated as settled while 0.1.61 is only proposed. Folded (F11).
- [sw-nit-r1-1] req-mf-005 impact of
hermesandgrok-bot. Folded (F15). [sw-nit-r1-2] Provenance. Folded (F13). - [sw-rec-r2-1] MCP destination undefined for
[vscode, copilot]. Pointer folded (F19); rule in [FEATURE] OpenAPM: a dependency's vscode target must not choose the consumer's MCP destination #3853. - [sw-nit-r2-1] sec 9.4 errata placement. Deferred (F25, [SPEC] Specify the target: -> targets: rewrite contract, alias table and legacy all semantics #3859). [sw-nit-r2-2] Schema description annotation. Deferred (F24, [SPEC] Specify the target: -> targets: rewrite contract, alias table and legacy all semantics #3859).
Spec OCI Editor -- shocked_meter 7 -> 8/10, confidence high
Summary (r2): All round-1 items closed. One new recommendation on the lock spelling of vscode; defer to #3853 / #3855.
- [oci-rec-r1-1] Intersection identity of
vscodenot stated. Folded (F10). - [oci-nit-r1-1] Schema validity is not acceptance. Folded (F16). [oci-nit-r1-2] Test assertion ambiguity. Folded (F17).
- [oci-rec-r2-1] Lock
target_subset/subset_pairingsspelling. Deferred (F23, [FEATURE] OpenAPM: record target aliases canonically in lock target_subset and subset_pairings #3855). - [oci-nit-r2-1] The 4.2.1 body does not show that the [FEATURE] OpenAPM: a dependency's vscode target must not choose the consumer's MCP destination #3853 question is open. Folded (F19).
Spec Pkgmgr Editor -- shocked_meter 7 -> 8/10, confidence high
Summary (r2): pm-blk-r1-1 is closed. req-tg-008 and sec 4.2.1 state that vscode denotes copilot, so the strict xfail now checks stated behavior. All recommended items folded. One new gap: lock spelling.
- [pm-blk-r1-1] req-tg-008 admitted
vscodebut did not define its intersection identity; the [BUG] A dependency declaring targets: [vscode] deploys nothing to copilot projects #3861 behavior was conformant. Closed in r2 (F10). - [pm-rec-r1-1] Deprecation clock tied to an unadopted proposal. Folded (F11). [pm-rec-r1-2] Erratum deleted. Folded (F12).
- [pm-nit-r1-1] Deployed-behavior overclaim. Folded (F14).
- [pm-rec-r2-1] Lock spelling. Deferred (F23, [FEATURE] OpenAPM: record target aliases canonically in lock target_subset and subset_pairings #3855). [pm-nit-r2-1]
[vscode, copilot]co-occurrence. Pointer folded (F19); rule in [FEATURE] OpenAPM: a dependency's vscode target must not choose the consumer's MCP destination #3853.
Spec TAG Architect -- shocked_meter 7 -> 8/10, confidence high
Summary (r2): All round-1 recommendations closed and no blocker. Follow-ups: body/history consistency on #3853 (folded as a pointer) and schema admission (#3859).
- [tag-rec-r1-1] Intersection identity. Folded (F10). [tag-rec-r1-2] Deprecation effective date. Folded (F11); producer symmetry deferred (F18, [SPEC] Specify the target: -> targets: rewrite contract, alias table and legacy all semantics #3859).
- [tag-nit-r1-1] Erratum deleted. Folded (F12). [tag-nit-r1-2]
alllisted twice. Rejected (pre-existing emphasis). - [tag-rec-r2-1] Body and history disagree on [FEATURE] OpenAPM: a dependency's vscode target must not choose the consumer's MCP destination #3853. Folded (F19, F20). [tag-rec-r2-2] Schema cannot enforce token admission. Deferred (F24, [SPEC] Specify the target: -> targets: rewrite contract, alias table and legacy all semantics #3859).
- [tag-nit-r2-1] Bare requirement mentions. Folded (F21, F22).
This panel is advisory. It does not block merge. Re-apply the spec-review label after addressing feedback to re-run.
Generated by apm-spec-guardian. This comment is AI-generated and may contain errors.
…osed) Applies fold_now F1-F9 from the apm-spec-guardian review of #3801. The 4.2.1 rewrite rule wrote targets: [vscode], which the sec 4.2 targets row and req-tg-008 told conforming consumers to reject. - sec 4.2 targets row and req-tg-008 (revised in place) admit the preserved legacy identifier vscode; agents stays rejected. - sec 4.2.1: rewrite keeps vscode and normalises agents; MCP paths move into a non-normative note; hermes and grok-bot join the canonical set. - sec 4.2 target row marked deprecated. - The #3801 erratum becomes an Appendix D 0.1.61 (proposed) row; Errata restored to none; proposals paragraph and Appendix E.5 updated. - req-tg-008 conformance test; the targets: [vscode] copilot narrowing is a strict xfail linking #3861 until the owner fix lands. - CONFORMANCE regenerated. Count unchanged at 139 (134 MUST, 5 SHOULD). Fixes #3860 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- req-tg-008, sec 4.2.1 and the 0.1.61 row state that vscode denotes the copilot target in the effective target intersection (closes pm-blk-r1-1; no new keyword or anchor). - target: deprecation and the sec 9.5 window take effect on 9.3 adoption of 0.1.61, not on the proposal date. - The 2026-11-17 erratum is recorded as withdrawn and reclassified instead of deleted. - 0.1.61 row: provenance (#3801, #3851, #3860), narrowed deployed- behavior claim (#3861 / #3864), req-mf-005 impact of hermes/grok-bot. - Appendix E.5: schema validity does not imply req-tg-008 acceptance. - Test comment points the admission check to the narrowing xfail. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Non-normative pointer in sec 4.2.1 and the 0.1.61 row: the dependency vscode MCP-destination question and the vscode + copilot co-occurrence are tracked in #3853. Link req-tg-008 / req-mf-005 mentions in E.5 and the 0.1.61 row. No keyword, anchor or count change. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
test_targets_vscode_narrows_like_copilot now passes on main. The 0.1.61 row records that the reference implementation's targets: [vscode] intersection was fixed in PR #3864. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
dc052c4 to
6b962f2
Compare
…nd-trip and uninstall, MCP declarer hint, dry-run source root) - PROXY_REGISTRY_ONLY: a targeted apm update still checks the lock entries it keeps; only the re-resolved selection skips the stale-source check. - default_host: shorthand parses as <default_host>/<shorthand> so GitLab subgroups and Azure DevOps keep their repository boundary; apm.yml drops the host only when the short form round-trips; uninstall resolves against the manifest host (owner: models/dependency/manifest_host.py). - Transitive MCP policy hints name the direct apm.yml dependency that brings the server in, never a package display name. - Dry-run prospective package resolves local paths from the real project. - OpenAPM amendment row renumbered to 0.1.62 after #3851 took 0.1.61. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: land the docs re-sweep code defects (#3835-#3847) Policy violations name the dependency, audit PACKAGE normalizes and fails on no match, audit --ci shows [x], install --dry-run writes nothing, hints name apm update, apm update gains --legacy-skill-paths, auto-integrate is deprecated, explicit no-output targets are honored by compile, aliases persist canonically, manifest default_host is honored (req-mf-019), publish keeps the host in the identity, pack always embeds the integrity manifest, stale CLI messages are fixed, and the OpenAPM merge table states stricter-wins for fetch_failure (proposed amendment 0.1.61). Adds owner record + static guard install-deployment-policy-violation-subjects. apm-spec-waiver: docs re-sweep defect batch; spec citations are req-mf-019 and req-pl-006 (amendment 0.1.61) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * test: align audit no-match exit and lint fixes Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * docs(changelog): reference #3865 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * test(policy): assert the per-dependency violation contract in GitLab lifecycle (#3835) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * fix: address review on #3865 (targeted proxy update, default_host round-trip and uninstall, MCP declarer hint, dry-run source root) - PROXY_REGISTRY_ONLY: a targeted apm update still checks the lock entries it keeps; only the re-resolved selection skips the stale-source check. - default_host: shorthand parses as <default_host>/<shorthand> so GitLab subgroups and Azure DevOps keep their repository boundary; apm.yml drops the host only when the short form round-trips; uninstall resolves against the manifest host (owner: models/dependency/manifest_host.py). - Transitive MCP policy hints name the direct apm.yml dependency that brings the server in, never a package display name. - Dry-run prospective package resolves local paths from the real project. - OpenAPM amendment row renumbered to 0.1.62 after #3851 took 0.1.61. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * fix: fold lean panel findings on #3865 - One owner enters the manifest default_host scope (models/dependency/manifest_host.manifest_host_scope_for); install, uninstall, APMPackage and audit PACKAGE route through it, so apm audit acme/x finds a default_host package. - PolicyRemedy enum owns the remedy vocabulary; an unknown or missing remedy never renders a remove-from-apm.yml hint. - Content-hash/licence mismatch hints name the targeted apm update <pkg> for direct dependencies. - apm config set auto-integrate warns first and stores without a success claim. - apm pack no longer records the 'minimal' pseudo-target; install treats legacy 'minimal' bundles as target-agnostic (fixes a crash for lockless packs with no target folder). - Integration coverage: lockless pack -> install -> tamper rejection, and a lifecycle-state no-write check for bootstrap dry-run. - CHANGELOG: default_host moved to Changed with an upgrade note. Deferred: derive CheckResult details from subjects (#3869). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * fix(bundle): ignore unknown informational pack.target names on install pack.target is metadata only; a name the installing CLI does not know (legacy 'minimal', or a target from a newer APM) no longer raises KeyError in check_target_mismatch. Addresses the panel CEO follow-up on the post-panel minimal-target fix. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: danielmeppiel <danielmeppiel@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Description
Applies fold-now items F1-F9 from the apm-spec-guardian review of merged #3801 (#3801 (comment); next_brief, avg 6.25). All four panels raised the same blocker. #3801's sec 4.2.1 rewrite rule makes
apm manifest migratewritetargets: [vscode], but the sec 4.2targetsrow and req-tg-008 required conforming consumers to reject that.OpenAPM v0.1 changes (Amendment 0.1.61, proposed; next free number at this head):
targetsrow and req-tg-008 (revised in place, same keywords and id) admit the preserved legacy identifiervscode.agentsis still rejected undertargets:.apm manifest migraterewrite oftarget: vscodeyieldstargets: [vscode], which parses and resolves with no error diagnostic;targets: [agents]is rejected namingagents; and the spec text is pinned. The fourth assertion (targets: [vscode]narrows likecopilot) passes now that fix(targets): deploy a targets: [vscode] dependency to copilot projects #3864 (fix for [BUG] A dependency declaring targets: [vscode] deploys nothing to copilot projects #3861) has landed.agentsis normalised andvscodeis preserved on rewrite; MCP destination paths move into a non-normative note.hermesandgrok-botjoin the canonical set to match the explicit-only enumeration.test_manifest_target_enum_is_pinnedwas updated to match.0.1.61 (proposed)row; "Errata (none at publication)." is restored; the proposals paragraph names 0.1.61.targetrow is marked deprecated in favor oftargets.The statement count is unchanged at 139 (134 MUST, 5 SHOULD). CONFORMANCE is regenerated. JSON Schema bytes are unchanged.
apm-spec-guardian: editorial-patch (delta panel fold_and_ship, avg 8.0: #3851 (comment))
Issue and approved scope
Issue: Fixes #3860
Human scope-approval comment: #3860 (comment)
Does this PR complete the issue, or what remains? It completes #3860. The rewrite contract, alias table and legacy
allsemantics are in #3859. The implementation bug #3861 was fixed by #3864 (merged).Type of change
Testing
Validation evidence (local, at head
6b962f2cf3onmain9474bd8380):.venv/bin/python -m pytest tests/spec_conformance/test_manifest_reqs.py -p no:xdist -q.venv/bin/python -m pytest tests/spec_conformance -p no:xdist -qtest_manifest_target_enum_is_pinned, which pinned the old canonical set) was updated for F5 and now passes.venv/bin/python -m pytest tests/spec_conformance --collect-only -q -p no:xdistthenpython -m tests.spec_conformance.gen_statement.venv/bin/python -m tests.spec_conformance.orphan_checkuvx ruff@0.15.12 check/format --checkSpec conformance (OpenAPM v0.1)
docs/src/content/docs/specs/openapm-v0.1.mdupdated (req-tg-008 revised in place; Appendix D 0.1.61 row; no new anchor, so Appendix C is unchanged).docs/src/content/docs/specs/manifests/openapm-v0.1.requirements.ymlupdated (no id, keyword, section or class change).@pytest.mark.req("req-tg-008")test undertests/spec_conformance/added or extended.CONFORMANCE.{md,json}regenerated viauv run --extra dev python -m tests.spec_conformance.gen_statementand committed.