Use mssql instead of azure-sql-edge for ServiceBus Emulator

[Martin Costello (martincostello)]

Description

Switch the azure-sql-edge container for mssql/server for the Azure ServiceBus emulator as Azure SQL Edge is retiring in September 2025.

Relates to #9279. Provides the switch from the to-be-retired image, but does not introduce the ability to allow the user to configure the dependent SQL Server image proposed.

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No - does not include the API suggested by Allow to choose Service Bus emulator SQL instance #9279.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No
• Did you add public API?
  • Yes
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
  • No
• Does the change require an update in our Aspire docs?
  • Yes
    • Link to aspire-docs issue:
      • Update ServiceBus emulator child image name dotnet/docs-aspire#4043
  • No

[Copilot]

Pull Request Overview

This PR replaces the retiring azure-sql-edge emulator image with the official mssql/server image for the Azure ServiceBus emulator.

• Switch container image constants from Azure SQL Edge to SQL Server
• Update emulator extension to create and reference an -mssql container instead of -sqledge
• Adjust corresponding test to look for sb-mssql rather than sb-sqledge

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
tests/Aspire.Hosting.Azure.Tests/AzureServiceBusExtensionsTests.cs	Test updated to expect the resource named sb-mssql instead of sb-sqledge.
src/Aspire.Hosting.Azure.ServiceBus/ServiceBusEmulatorContainerImageTags.cs	Renamed constants from AzureSqlEdge* to SqlServer* and updated <remarks> to reflect mssql/server.
src/Aspire.Hosting.Azure.ServiceBus/AzureServiceBusExtensions.cs	Updated container addition and references to use -mssql, SqlServerImage, SqlServerTag, and SqlServerRegistry.

Comments suppressed due to low confidence (2)

tests/Aspire.Hosting.Azure.Tests/AzureServiceBusExtensionsTests.cs:613

• Consider adding assertions to verify that the container image registry, image name, and tag on the sb-mssql resource match ServiceBusEmulatorContainerImageTags.SqlServerRegistry, SqlServerImage, and SqlServerTag to ensure the switch to mssql/server is fully validated in tests.

        var sql = builder.Resources.FirstOrDefault(x => x.Name == "sb-mssql");

src/Aspire.Hosting.Azure.ServiceBus/ServiceBusEmulatorContainerImageTags.cs:15

• [nitpick] The constant name Tag is quite generic; consider renaming it to something more descriptive such as ServiceBusEmulatorVersion or EmulatorTag to clarify its purpose.

    public const string Tag = "1.1.2";

[Martin Costello (martincostello)]

[Nudge as support ends in just over a month]

[Eric Erhardt (eerhardt)]

Thanks for the fix here Martin Costello (@martincostello). I just have 1 comment. Other than that, this looks good.

[Eric Erhardt (eerhardt)]

I think we should pin this to a version, like we do with the real SqlServer hosting integration:

https://github.com/dotnet/aspire/blob/ef3752be87d556f9673d3a44557bded08c7ad121/src/Aspire.Hosting.SqlServer/SqlServerContainerImageTags.cs#L15

This way we will be less likely to get breaking changes.

[Eric Erhardt (eerhardt)]

LGTM. Thanks for the contribution!