disable test - #7886
Merged
Merged
disable test#7886
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This PR intends to disable a problematic test in the public API tests by adding an attribute.
- Added the [ActiveIssue] attribute to disable the test method PublishAsAzureContainerAppForProjectShouldThrowWhenConfigureIsNull.
Reviewed Changes
| File | Description |
|---|---|
| tests/Aspire.Hosting.Azure.Tests/PublicApiTests/AppContainersPublicApiTests.cs | Disables a test by adding an ActiveIssue attribute |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tests/Aspire.Hosting.Azure.Tests/PublicApiTests/AppContainersPublicApiTests.cs:102
- If the intention is to completely disable the test, consider using [Fact(Skip = "Disabled due to issue 7885")] instead of relying solely on the ActiveIssue attribute, which may not prevent the test from running in all environments.
[ActiveIssue("https://github.com/dotnet/aspire/issues/7885")]
Eric Erhardt (eerhardt)
approved these changes
Mar 4, 2025
Dan Moseley (danmoseley)
enabled auto-merge (squash)
March 4, 2025 18:07
github-actions
Bot
added
the
area-integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7885