Repository navigation
Merge stable into angular19 (archive styles) - #8158
Merged
Merged
Conversation
One central partial for the backend-configuration archive (W1 layout): folder tree rows and drop targets, the selection bar, document date and read-access cells, the right-hand document panel and its drawer below 1100 px. Colours only through theme tokens; radii 4/6/8/10 px. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot review: small archive text was below 4.5:1. Rail and panel labels use --text-tertiary instead of --text-quaternary, the selected folder row's text uses --md-on-surface on its primary-container background, and empty folder rows are no longer faded with opacity. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Archive styles: folder tree, document panel and drawer
The archive table keeps its full width (its chips do not wrap). Without a frame of its own the overflow went to the content card, so at 1440 px the Etiketter column was cut off and opening the document panel shifted the whole page under the side menu. microting/eform-backendconfiguration-plugin#1450 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fix(archive): the document table scrolls inside its own frame
There was a problem hiding this comment.
🟡 Changes recommended
Preview shrinking and insufficient empty-folder text contrast remain unresolved.
2 open issues
What changed in this PR
Brings stable’s archive styles into Angular 19 for the backend-configuration plugin.
Changes:
- Adds folder-tree, document-table, panel, and responsive drawer styles.
- Contains horizontal table scrolling within its own frame.
- Registers the archive stylesheet.
| File | Description |
|---|---|
| eform-client/src/scss/components/_index.scss | Loads archive styles. |
| eform-client/src/scss/components/_archive.scss | Defines archive layout, component states, scrolling, and drawer styling. |
Review effort: Balanced
|
|
||
| .archive-folder-row--empty .archive-folder-row__name, | ||
| .archive-folder-row--empty .archive-folder-row__count { | ||
| color: var(--md-on-surface-variant); |
|
|
||
| .archive-panel__preview { | ||
| display: block; | ||
| height: 220px; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges
origin/stableintoangular19. That brings three archive style commits that landed onstable(#8148, #8153) but never reachedmasterorangular19:a622190a9feat(styles): archive folder tree, document panel and drawer stylesfb37e8169fix(styles): readable archive labels, selected and empty folder rows6d1d6fd73fix(archive): the document table scrolls inside its own frameThe merge has no conflicts and adds only
_archive.scssplus its index entry. backendconfiguration's archive Playwright tests (shardzb) need these styles. Without them the archive backdrop has no styles and counts as hidden.Note:
masterdoesn't have these commits either, somasterandstablehave drifted on the frontend.Verified with
ng buildagainstangular19.🤖 Generated with Claude Code