Angular 21: merge angular19 into master by renemadsen · Pull Request #8161 · microting/eform-angular-frontend

renemadsen · 2026-10-18T16:23:08Z

Summary

Moves the Angular 21 line (angular19) into master. master has not moved since angular19 last merged it, so this is angular19's 92 commits on top of master.

What it brings:

Angular 21.1: Material 21, @ng-matero/extensions 21, ngrx 21, TypeScript 5.9 and Yarn 4.
Standalone everywhere: no standalone: false and no NgModule declarations (Merge master into angular19 and finish the standalone migration (Angular 21) #8155).
Unit tests on Vitest via ng test, replacing Jest.
Fixes found while migrating the plugins:
- indexed action-menu IDs in table styles (style(table): match indexed action-menu ids on highlighted rows #8157);
- a circular import in the case-edit components (NG0919) (fix(cases): break the EformCasesModule import cycle in case-edit components #8159);
- a visual editor Playwright race (test(visual-editor): wait for the field dialog to close before opening the next #8160).
Archive styles from stable (Merge stable into angular19 (archive styles) #8158). master was missing them.

All 11 in-scope plugins (items-planning, greate-belt, workflow, basecustomer, chemical, outer-inner-resource, trash-inspection, insight-dashboard, kanban, timeplanning, backendconfiguration) are migrated on their own angular19 branches, and their CI there is green against this frontend. Their PRs into master follow once this one is merged. Plugin CI on master checks out the frontend's master, which is why the frontend goes first.

🤖 Generated with Claude Code

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

…ork) Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

…e component errors Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

…d module declarations) Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

…ation Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

…plications Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

…ilures Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

… and configs Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

…ion errors Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

….spec.json types Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

…" error Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

…lar 21 Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

…highlighted Master's template uses routerLinkActive; the standalone component did not import the directive, so the attribute was inert. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge master into angular19 and finish the standalone migration (Angular 21)

Plugins now render per-row ids (actionMenu0, actionMenu1, ...) so the highlighted-row rules that darkened the action-menu icon no longer matched. Use a prefix selector so they apply to both forms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

style(table): match indexed action-menu ids on highlighted rows

Brings the archive folder tree, document panel and drawer styles (a622190, fb37e81, 6d1d6fd) that landed on stable but never reached master or angular19. backendconfiguration's archive Playwright tests need them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@directive

…onents CaseEditElementComponent and CaseEditNavComponent listed EformCasesModule in their standalone `imports`, while EformCasesModule imports and exports those same components. In the production bundle the module class is defined after the components, so their eager `dependencies` arrays held `undefined`. At runtime Angular threw NG0919 ("Cannot read @directive metadata ... runtime circular dependency") and app-case-edit-element never rendered, e.g. in the case-complete modal. Both components only needed the module to render themselves recursively. A standalone component can already use its own selector, so the module import is removed and nothing replaces it. CaseEditSwitchComponent <-> ElementContainerComponent is a direct cycle of the same kind: the bundle defined the switch before the container, so the switch's dependency list captured `undefined` for element-container. Both sides now import each other through forwardRef, so the compiler emits a lazy `dependencies: () => [...]` closure that works whichever order the bundler picks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge stable into angular19 (archive styles)

fix(cases): break the EformCasesModule import cycle in case-edit components

…g the next closeVisualTemplateFieldCreateModal waited for #manageTags, which sits behind the dialog and is always visible, so it returned at once. The next #initialFieldCreateBtn click (about 10 ms later in the failing trace) opened a new "Nyt felt" dialog while the saved one was still in its close animation, and #changeFieldSaveCancelBtn matched two elements (strict mode violation). Wait until the dialog has left the DOM. closeEditModal now reuses the same helper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test(visual-editor): wait for the field dialog to close before opening the next

CLAassistant · 2026-10-18T16:23:17Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ renemadsen
❌ Copilot
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Copilot

🟡 Changes recommended

One or more issues must be addressed before approval.

3 open issues

What changed in this PR

Merges the Angular 21 frontend migration into master, preparing shared components and tooling for migrated plugins.

Changes:

Converts components and pipes to standalone imports.
Migrates unit testing to Vitest and enables Yarn 4 through Corepack.
Updates indexed UI selectors, styles, E2E synchronization, and CMS-loading fallback behavior.

File	Description
eform-client/vitest.ng-test.config.ts	Updated as part of this pull request.
eform-client/vitest.config.ts	Updated as part of this pull request.
eform-client/tsconfig.json	Updated as part of this pull request.
eform-client/src/tsconfig.spec.json	Updated as part of this pull request.
eform-client/src/test-setup.ts	Updated as part of this pull request.
eform-client/src/test-module-imports.ts	Updated as part of this pull request.
eform-client/src/test-helpers.ts	Updated as part of this pull request.
eform-client/src/scss/components/_table.scss	Updated as part of this pull request.
eform-client/src/scss/components/_index.scss	Updated as part of this pull request.
eform-client/src/app/plugins/plugins.module.ts	Updated as part of this pull request.
eform-client/src/app/plugins/modules/shared/components/text-editor-pn/pell-pn.component.ts	Updated as part of this pull request.
eform-client/src/app/plugins/modules/shared/components/subheader-pn/subheader-pn.component.ts	Updated as part of this pull request.
eform-client/src/app/plugins/modules/shared/components/spinner-pn/spinner-pn.component.ts	Updated as part of this pull request.
eform-client/src/app/plugins/modules/shared/components/pagination-pn/pagination-pn.component.ts	Updated as part of this pull request.
eform-client/src/app/plugins/modules/shared/components/page-size-pn/page-size-pn.component.ts	Updated as part of this pull request.
eform-client/src/app/plugins/modules/example-pn/example-pn.module.ts	Updated as part of this pull request.
eform-client/src/app/plugins/modules/example-pn/components/example-pn-page/example-pn-page.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/security/components/security-page/security-page.component.html	Updated as part of this pull request.
eform-client/src/app/modules/security/components/security-group-update/security-group-update.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/security/components/security-group-settings/security-group-settings.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/security/components/security-group-remove/security-group-remove.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/security/components/security-group-permissions/security-group-general-permissions/security-group-general-permissions.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/security/components/security-group-permissions/security-group-eforms-edit/security-group-eforms-edit.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/security/components/security-group-permissions/security-group-eforms-delete/security-group-eforms-delete.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/security/components/security-group-permissions/security-group-eforms-add/security-group-eforms-add.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/security/components/security-group-create/security-group-create.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/plugins-management/plugins-management.module.ts	Updated as part of this pull request.
eform-client/src/app/modules/plugins-management/components/marketplace/marketplace-plugin-install/marketplace-plugin-install.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/plugins-management/components/installed/installed-plugins-page/installed-plugins-page.component.html	Updated as part of this pull request.
eform-client/src/app/modules/plugins-management/components/installed/installed-plugin-modal/installed-plugin-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/email-recipients/email-recipients.module.ts	Updated as part of this pull request.
eform-client/src/app/modules/email-recipients/components/tags/email-recipients-tags.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/email-recipients/components/recipients/email-recipient-new/email-recipients-new.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/email-recipients/components/recipients/email-recipient-edit/email-recipient-edit.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/email-recipients/components/recipients/email-recipient-delete/email-recipient-delete.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/email-recipients/components/email-recipients-page/email-recipients-page.component.html	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-xlsx-report/eform-xlsx-report.module.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-xlsx-report/components/eform-xlsx-report-header/eform-xlsx-report-header.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-xlsx-report/components/eform-xlsx-report-container/eform-xlsx-report-container.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-visual-editor/components/eform-visual-editor-elements/field/visual-editor-field/visual-editor-field.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-visual-editor/components/eform-visual-editor-elements/field/visual-editor-field-delete-modal/visual-editor-field-delete-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-visual-editor/components/eform-visual-editor-elements/field/visual-editor-additional-fields/visual-editor-additional-field-show-picture/visual-editor-additional-field-show-picture.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-visual-editor/components/eform-visual-editor-elements/field/visual-editor-additional-fields/visual-editor-additional-field-pdf/visual-editor-additional-field-pdf.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-visual-editor/components/eform-visual-editor-elements/field/visual-editor-additional-fields/visual-editor-additional-field-number/visual-editor-additional-field-number.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-visual-editor/components/eform-visual-editor-elements/field/visual-editor-additional-fields/visual-editor-additional-field-files.spec.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-visual-editor/components/eform-visual-editor-elements/field/visual-editor-additional-fields/visual-editor-additional-field-entity-select/visual-editor-additional-field-entity-select.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-visual-editor/components/eform-visual-editor-elements/field/visual-editor-additional-fields/visual-editor-additional-field-entity-search/visual-editor-additional-field-entity-search.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-visual-editor/components/eform-visual-editor-elements/checklist/visual-editor-checklist/visual-editor-checklist.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-visual-editor/components/eform-visual-editor-elements/checklist/visual-editor-checklist-delete-modal/visual-editor-checklist-delete-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-docx-report/eform-docx-report.module.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-docx-report/components/eform-docx-report-table/eform-docx-report-table.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-docx-report/components/eform-docx-report-images/eform-docx-report-images.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-docx-report/components/eform-docx-report-header/eform-docx-report-header.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-docx-report/components/eform-docx-report-header-editor/eform-docx-report-header-editor.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/eform-docx-report/components/eform-docx-report-container/eform-docx-report-container.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/components/eforms-page/eforms-page.component.html	Updated as part of this pull request.
eform-client/src/app/modules/eforms/components/eform-upload-zip-modal/eform-upload-zip-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/components/eform-remove-eform-modal/eform-remove-eform-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/components/eform-excel-report-modal/eform-excel-report-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/components/eform-edit-tags-modal/eform-edit-tags-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/components/eform-edit-paring-modal/eform-edit-paring-modal.component.html	Updated as part of this pull request.
eform-client/src/app/modules/eforms/components/eform-duplicate-confrim-modal/eform-duplicate-confirm-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/components/eform-create-modal/eform-create-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/eforms/components/eform-columns-modal/eform-columns-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/device-users/device-users.module.ts	Updated as part of this pull request.
eform-client/src/app/modules/device-users/components/new-otp-modal/new-otp-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/device-users/components/edit-create-user-modal/edit-create-user-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/device-users/components/delete-device-user-modal/delete-device-user-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/cms/components/cms-settings/cms-settings.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/cms/components/cms-pages-list/cms-pages-list.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/cms/components/cms-page-edit/cms-page-edit.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/cms/components/cms-menus-list/cms-menus-list.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/cms/components/cms-menu-edit/cms-menu-item-dialog.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/cms/components/cms-menu-edit/cms-menu-edit.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/cms/components/cms-container/cms-container.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/cms/cms.module.ts	Updated as part of this pull request.
eform-client/src/app/modules/cms-public/pipes/safe-html.pipe.ts	Updated as part of this pull request.
eform-client/src/app/modules/cms-public/components/landing-page/landing-page.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/cms-public/components/cms-page-view/cms-page-view.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/cms-public/components/cms-menu-item/cms-menu-item.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/cms-public/components/cms-header/cms-header.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/cms-public/cms-public.module.ts	Updated as part of this pull request.
eform-client/src/app/modules/cases/cases.module.ts	Updated as part of this pull request.
eform-client/src/app/modules/auth/components/sign-out/sign-out.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/auth/components/google-authenticator/google-authenticator.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/auth/components/auth/restore-password/restore-password.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/auth/components/auth/login/login.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/auth/components/auth/auth.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/auth/auth.module.ts	Updated as part of this pull request.
eform-client/src/app/modules/application-settings/application-settings.module.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/modules/navigation-menu/components/navigation-menu-reset/navigation-menu-reset.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/modules/navigation-menu/components/menu-item/navigation-menu-template-item/navigation-menu-template-item.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/modules/navigation-menu/components/menu-item/navigation-menu-template-item/navigation-menu-template-item.component.spec.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/modules/navigation-menu/components/menu-item/navigation-menu-item/navigation-menu-item.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/modules/navigation-menu/components/menu-item/navigation-menu-item-delete/navigation-menu-item-delete.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/modules/navigation-menu/components/menu-custom/navigation-menu-custom/navigation-menu-custom.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/modules/navigation-menu/components/menu-custom/navigation-menu-custom-link/navigation-menu-custom-link.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/modules/navigation-menu/components/menu-custom/navigation-menu-custom-dropdown/navigation-menu-custom-dropdown.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/workers/workers/workers.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/workers/workers/workers.component.html	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/workers/worker-edit-create/worker-edit-create.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/workers/worker-delete/worker-delete.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/units/units.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/units/units.component.html	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/units/units-otp-code/units-otp-code.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/units/unit-move/unit-move.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/units/unit-create/unit-create.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/sites/site-edit/site-edit.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/sites/site-delete/site-delete.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/folders/folders/folders.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/folders/folder-delete/folder-delete.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/entity-select/entity-select/entity-select.component.html	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/entity-select/entity-select-remove/entity-select-remove.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/entity-search/entity-search/entity-search.component.html	Updated as part of this pull request.
eform-client/src/app/modules/advanced/components/entity-search/entity-search-remove/entity-search-remove.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/advanced/advanced.module.ts	Updated as part of this pull request.
eform-client/src/app/modules/account-management/components/users/users-page/users-page.component.html	Updated as part of this pull request.
eform-client/src/app/modules/account-management/components/users/user-modal/user-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/account-management/components/users/remove-user-modal/remove-user-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/account-management/components/users/confirm-email-modal/confirm-email-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/account-management/components/profile/change-password/change-password.component.ts	Updated as part of this pull request.
eform-client/src/app/modules/account-management/account-management.module.ts	Updated as part of this pull request.
eform-client/src/app/components/not-found/not-found.component.ts	Updated as part of this pull request.
eform-client/src/app/components/navigation/navigation.component.ts	Updated as part of this pull request.
eform-client/src/app/components/layouts/simple-layout/simple-layout.component.ts	Updated as part of this pull request.
eform-client/src/app/components/header/header.component.ts	Updated as part of this pull request.
eform-client/src/app/components/footer/footer.component.spec.ts	Updated as part of this pull request.
eform-client/src/app/components/eform-spinner/spinner.component.ts	Updated as part of this pull request.
eform-client/src/app/components/connection-setup/connection-setup.component.ts	Updated as part of this pull request.
eform-client/src/app/components/app.component.ts	Updated as part of this pull request.
eform-client/src/app/common/store/service/auth-state.service.spec.ts	Updated as part of this pull request.
eform-client/src/app/common/services/sentry/sentry-user.service.spec.ts	Updated as part of this pull request.
eform-client/src/app/common/services/cms/cms.service.ts	Updated as part of this pull request.
eform-client/src/app/common/pipes/safe-html.pipe.ts	Updated as part of this pull request.
eform-client/src/app/common/pipes/auth-image.pipe.ts	Updated as part of this pull request.
eform-client/src/app/common/pipes/auth-audio.pip.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/status-bar/status-bar.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/status-bar-compact/status-bar-compact.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/entity-list-elements/entity-list-elements.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/entity-item-edit-name/entity-item-edit-name.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/entity-import-list/entity-import-list.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/eform-tree-view-picker/eform-tree-view-picker.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/eform-tree-view-picker/eform-tree-view-picker.component.spec.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/eform-translation/eform-translation.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/eform-tag/eform-tag.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/eform-table/eform-table-headers/eform-table-headers.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/eform-table/eform-table-headers/eform-table-headers.component.spec.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/eform-subheader/eform-subheader.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/eform-pagination/eform-pagination.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/eform-page-size/eform-page-size.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/eform-new-subheader/eform-new-subheader.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/eform-collapse-toggler/eform-collapse-toggle.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/eform-collapse-toggler/eform-collapse-toggle.component.spec.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/delete-modal/delete-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared/components/date-formatter/date-formatter.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared-tags/eform-shared-tags.module.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared-tags/components/shared-tags/shared-tags.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared-tags/components/shared-tag-multiple-create/shared-tag-multiple-create.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared-tags/components/shared-tag-edit/shared-tag-edit.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared-tags/components/shared-tag-delete/shared-tag-delete.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-shared-tags/components/shared-tag-create/shared-tag-create.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-imported/pell/pell.module.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-imported/formatting-text-editor/formatting-text-editor.module.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-imported/formatting-text-editor/formatting-text-editor.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-imported/eform-imported.module.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-timer/element-timer.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-text/element-text.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-singleselect/element-singleselect.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-signature/element-signature.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-pdf/element-pdf.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-number/element-number.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-number-stepper/element-number-stepper.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-multiselect/element-multiselect.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-infobox/element-infobox.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-entityselect/element-entityselect.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-entitysearch/element-entitysearch.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-date/element-date.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-container/element-container.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-comment/element-comment.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-checkbox/element-checkbox.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-audio/element-audio.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-edit-element/case-edit-element.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit/case-edit-confirmation/case-edit-confirmation.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-edit-nav/case-edit-nav.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-actions/case-remove-modal/case-remove-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/common/modules/eform-cases/components/case-actions/case-archive-modal/case-archive-modal.component.ts	Updated as part of this pull request.
eform-client/src/app/common/helpers/route-match.helper.spec.ts	Updated as part of this pull request.
eform-client/src/app/common/guards/auth.guard.ts	Updated as part of this pull request.
eform-client/playwright/e2e/Tests/j/eform-visual-editor.create-eform.spec.ts	Updated as part of this pull request.
eform-client/playwright/e2e/Tests/g/application-settings.theme-new-design.spec.ts	Updated as part of this pull request.
eform-client/playwright/e2e/Tests/d/device-users.delete.spec.ts	Updated as part of this pull request.
eform-client/playwright/e2e/Tests/d/device-users.add.spec.ts	Updated as part of this pull request.
eform-client/playwright/e2e/Tests/b/my-eforms.tags-eform.spec.ts	Updated as part of this pull request.
eform-client/playwright/e2e/Page objects/Workers.page.ts	Updated as part of this pull request.
eform-client/playwright/e2e/Page objects/UserAdministration.page.ts	Updated as part of this pull request.
eform-client/playwright/e2e/Page objects/Sites.page.ts	Updated as part of this pull request.
eform-client/playwright/e2e/Page objects/SelectableLists.page.ts	Updated as part of this pull request.
eform-client/playwright/e2e/Page objects/Plugin.page.ts	Updated as part of this pull request.
eform-client/playwright/e2e/Page objects/MyEforms.page.ts	Updated as part of this pull request.
eform-client/playwright/e2e/Page objects/Folders.page.ts	Updated as part of this pull request.
eform-client/playwright.config.ts	Updated as part of this pull request.
eform-client/cypress/e2e/Workers.page.ts	Updated as part of this pull request.
eform-client/cypress/e2e/UserAdministration.page.ts	Updated as part of this pull request.
eform-client/cypress/e2e/Sites.page.ts	Updated as part of this pull request.
eform-client/cypress/e2e/j/eform-visual-editor.multi-language.spec.cy.ts	Updated as part of this pull request.
eform-client/cypress/e2e/j/eform-visual-editor.edit-xml.spec.cy.ts	Updated as part of this pull request.
eform-client/cypress/e2e/j/eform-visual-editor.edit-eform.spec.cy.ts	Updated as part of this pull request.
eform-client/cypress/e2e/h/searchable-lists.edit.spec.cy.ts	Updated as part of this pull request.
eform-client/cypress/e2e/Folders.page.ts	Updated as part of this pull request.
eform-client/cypress/e2e/DeviceUsers.page.ts	Updated as part of this pull request.
eform-client/cypress/e2e/d/device-users.delete.spec.cy.ts	Updated as part of this pull request.
eform-client/cypress/e2e/d/device-users.add.spec.cy.ts	Updated as part of this pull request.
eform-client/angular.json	Updated as part of this pull request.
eform-client/.yarnrc.yml	Updated as part of this pull request.
eform-client/.gitignore	Updated as part of this pull request.
Dockerfile	Updated as part of this pull request.
.github/workflows/dotnet-core-pr.yml	Updated as part of this pull request.
.github/workflows/dotnet-core-master.yml	Updated as part of this pull request.

_{Review effort: Balanced}

+export default defineConfig({
+  test: {
+    globals: true,
+    environment: 'happy-dom',
+    setupFiles: ['src/test-setup.ts'],


The guard's 10s CMS-config timeout always redirected to /auth. For a signed-in user the login page sends them straight back to /, where the guard reloads the config and times out again: a redirect loop. On timeout, let authenticated users through and send only the rest to /auth. Also fix the mocked doctype in test-setup ('}' -> '>'). Found by Copilot review of the angular19 -> master PR (#8161). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(auth): don't bounce signed-in users to /auth when CMS config is slow

Copilot

🔵 Needs a closer look

One or more issues must be addressed before approval.

1 open issue

Vitest config cannot compile Angular component resources

2 resolved since last review

_{Review effort: Balanced}

Copilot AI and others added 30 commits January 16, 2026 16:54

Initial plan

3dd5c5a

Update Angular to v21 and TypeScript to v5.9.3

23c3308

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Fix TypeScript configuration for Angular 21 compatibility

8f051f9

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Add jest-environment-jsdom for Jest 30 compatibility

8ab42cc

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Add Angular 21 migration documentation

ffe09c3

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Add Jest configuration for Angular 21 (partial fix for unit tests)

5cc282b

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Add comprehensive test runner migration analysis (Vitest recommended)

b594e87

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

WIP: Begin Vitest migration - dependencies installed, config created

69eb77e

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Install @analogjs/vitest-angular and debug TestBed initialization

bc1a34b

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Implement Angular CLI built-in Vitest support (partial - needs more w…

0a42510

…ork) Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Fix Vitest types and add explicit imports - tests now compile but hav…

f3967dd

…e component errors Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Add @angular/compiler and optimize test config (tests compile but nee…

ad500c1

…d module declarations) Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Add FormsModule to test files and document Vitest architectural limit…

4e1b992

…ation Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Add comprehensive standalone components migration plan with plugin im…

b73a441

…plications Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Phase 1: Convert all components to standalone (automated migration)

62f1c22

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Fix missing MatTooltip import - application builds successfully

0c7875a

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Update Vitest config and document standalone migration success

86f6ff7

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Complete standalone migration phases 2 & 3 - full modernization achieved

9acfd10

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Fix unit tests: revert to Jest, fix configuration and test imports

14c14ff

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Fix Jest module resolution: change from 'bundler' to 'node'

2e6b759

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Document Jest/Angular 21 incompatibility - tests have pre-existing fa…

35167b1

…ilures Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Recreate tsconfig.spec.json for Jest configuration

1d876fe

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Complete migration from Jest to Vitest - remove all Jest dependencies…

0c3c9b9

… and configs Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Add missing Vitest imports to 6 test files to fix TypeScript compilat…

0eb3741

…ion errors Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Merge branch 'master' into copilot/update-angular-to-21

ecbee7c

Fix vitest/globals type definition error by removing it from tsconfig…

668f49a

….spec.json types Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Remove vitest.config.mts to fix Angular CLI builder compatibility issue

3ca35e3

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Upgrade Vitest from 2.0.5 to ^2.1.0 for Angular CLI compatibility

62d70e3

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Add include pattern to test configuration to fix "No test files found…

2c29b53

…" error Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Upgrade Vitest to 4.0.18 - fix test discovery and execution with Angu…

1e77f52

…lar 21 Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

renemadsen and others added 10 commits October 18, 2026 06:58

fix(navigation): import RouterLinkActive so the active menu entry is …

d434af8

…highlighted Master's template uses routerLinkActive; the standalone component did not import the directive, so the attribute was inert. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge pull request #8155 from microting/ng21/merge-master

4bcd78b

Merge master into angular19 and finish the standalone migration (Angular 21)

Merge pull request #8157 from microting/ng21/action-menu-scss

e7479b6

style(table): match indexed action-menu ids on highlighted rows

Merge pull request #8158 from microting/ng21/merge-stable

03fe800

Merge stable into angular19 (archive styles)

Merge pull request #8159 from microting/ng21/cases-cycle

81e49d3

fix(cases): break the EformCasesModule import cycle in case-edit components

Merge pull request #8160 from microting/ng21/visual-editor-dialog

e5a5c90

test(visual-editor): wait for the field dialog to close before opening the next

Copilot AI balanced review requested due to automatic review settings October 18, 2026 16:23

Copilot started reviewing on behalf of renemadsen October 18, 2026 16:23

View session

Copilot AI reviewed Oct 18, 2026

View reviewed changes

renemadsen mentioned this pull request Oct 18, 2026

fix(auth): don't bounce signed-in users to /auth when CMS config is slow #8162

Merged

Merge pull request #8162 from microting/ng21/guard-timeout

ffa5d56

fix(auth): don't bounce signed-in users to /auth when CMS config is slow

Copilot AI balanced review requested due to automatic review settings October 19, 2026 06:05

Copilot started reviewing on behalf of renemadsen October 19, 2026 06:06

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

renemadsen merged commit b7e0eb6 into master Oct 19, 2026
47 of 52 checks passed

Navigation Menu

Repository navigation

Angular 21: merge angular19 into master - #8161

Angular 21: merge angular19 into master#8161
renemadsen merged 94 commits into
masterfrom
angular19

renemadsen commented Oct 18, 2026

Uh oh!

CLAassistant commented Oct 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

renemadsen commented Oct 18, 2026

Summary

Uh oh!

CLAassistant commented Oct 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants