Repository navigation
Angular 21: merge angular19 into master - #1450
Merged
Merged
Conversation
PR CI checks out the frontend (and sibling plugins) at the branch the PR targets instead of always stable. Corepack is enabled before every yarn install, since the frontend's angular19 branch pins yarn@4; the Docker build uses yarn for the frontend build as well. Dead WDIO config copies are dropped (the frontend no longer has WDIO). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Also removes the dead SettingsRemoveSiteModalComponent (legacy mdbModal, not declared or referenced anywhere), which cannot compile standalone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ervices Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Angular 21: standalone components, Vitest and angular19 CI
There was a problem hiding this comment.
🟢 Approval recommended
Static review identified no blocking defects in the standalone migration, tests, or CI changes; tests were not executed.
No open issues 🎉
What changed in this PR
Brings the workflow plugin’s Angular 21 migration into master, aligning it with the upgraded frontend.
Changes:
- Converts active components to standalone imports and simplifies the plugin module.
- Migrates add-site tests to Vitest and removes the unused remove-site modal.
- Adds Angular unit-test CI, branch-aligned frontend checkouts, and Corepack-enabled Yarn builds.
| File | Description |
|---|---|
| eform-client/src/app/plugins/modules/workflow-pn/workflow-pn.module.ts | Retains routing and providers while removing component declarations. |
| eform-client/src/app/plugins/modules/workflow-pn/layouts/workflow-pn-layout.component.ts | Imports standalone router outlet. |
| eform-client/src/app/plugins/modules/workflow-pn/components/workflow-cases/workflow-cases-page/workflow-cases-page.component.ts | Adds standalone page dependencies. |
| eform-client/src/app/plugins/modules/workflow-pn/components/workflow-cases/workflow-case-edit/workflow-case-edit.component.ts | Adds standalone editor dependencies. |
| eform-client/src/app/plugins/modules/workflow-pn/components/workflow-cases/workflow-case-delete/workflow-case-delete.component.ts | Adds standalone dialog dependencies. |
| eform-client/src/app/plugins/modules/workflow-pn/components/settings/workflow-settings/workflow-settings.component.ts | Adds standalone settings dependencies. |
| eform-client/src/app/plugins/modules/workflow-pn/components/settings/workflow-folders-modal/workflow-folders-modal.component.ts | Adds standalone folder-picker dependencies. |
| eform-client/src/app/plugins/modules/workflow-pn/components/settings/settings-remove-site-modal/settings-remove-site-modal.component.ts | Removes unused modal component. |
| eform-client/src/app/plugins/modules/workflow-pn/components/settings/settings-remove-site-modal/settings-remove-site-modal.component.spec.ts | Removes obsolete modal test. |
| eform-client/src/app/plugins/modules/workflow-pn/components/settings/settings-remove-site-modal/settings-remove-site-modal.component.scss | Removes obsolete stylesheet. |
| eform-client/src/app/plugins/modules/workflow-pn/components/settings/settings-remove-site-modal/settings-remove-site-modal.component.html | Removes obsolete modal template. |
| eform-client/src/app/plugins/modules/workflow-pn/components/settings/settings-add-site-modal/settings-add-site-modal.component.ts | Adds standalone add-site dependencies. |
| eform-client/src/app/plugins/modules/workflow-pn/components/settings/settings-add-site-modal/settings-add-site-modal.component.spec.ts | Uses Vitest and checks available-site filtering. |
| eform-client/src/app/plugins/modules/workflow-pn/components/index.ts | Removes a commented-out export. |
| Dockerfile | Enables Corepack and builds with Yarn. |
| .github/workflows/dotnet-core-pr.yml | Adds unit tests and aligns frontend checkout with the target branch. |
| .github/workflows/dotnet-core-master.yml | Adds unit tests and enables Corepack for integration testing. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves this plugin's Angular 21 line (
angular19) intomaster.masterhas not moved sinceangular19was created from it.angular19this was reviewed, merged and verified green against the frontend'sangular19.masteris now on Angular 21 as well (Angular 21: merge angular19 into master eform-angular-frontend#8161), so this PR's CI runs against it.🤖 Generated with Claude Code