Repository navigation
Angular 21: merge angular19 into master - #1454
Merged
Merged
Conversation
PR CI checks out the frontend (and sibling plugins) at the branch the PR targets instead of always stable. Corepack is enabled before every yarn install, since the frontend's angular19 branch pins yarn@4; the Docker build uses yarn for the frontend build as well. Dead WDIO config copies are dropped (the frontend no longer has WDIO). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ts, statistics, task-worker-assignments to standalone for Angular 21 G1 of the backend-configuration-pn migration. Shared components, the layout, the reports/statistics/task-worker-assignments feature modules and the root module are standalone now; their NgModules import the classes instead of declaring them. Not-yet-converted feature modules drop the removed EformImportedModule/FormattingTextEditorModule wrappers (documents imports FormattingTextEditorComponent) and a TS 5.9 BlobPart cast in the files module, so the host build stays green. Repeated row IDs are indexed and the test selectors use [id^=...]. G1 specs move from Jest to Vitest. The unused BackendConfigurationCaseHeaderComponent (mdb-card template, referenced only in comments) is deleted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…st, compliance to standalone for Angular 21 Components in the three folders are standalone with explicit imports; their NgModules import them instead of declaring them (MatDialogModule kept, and added directly to ComplianceCaseModule, which had it only through the shared modules). Specs moved from Jest to Vitest in the same commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lone for Angular 21 Specs are migrated from Jest to Vitest in the same commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…agement to standalone for Angular 21 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es, task-wizard, task-tracker to standalone for Angular 21 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ls, tail-bite to standalone for Angular 21 Last group of the plugin. compliance-report and chemicals components become standalone and their NgModules import them; tail-bite was already standalone. The case, statistics and task-worker-assignments modules now import MatDialogModule directly. Component barrel imports that could form import cycles are replaced with direct paths (one left FileCreateEditFileComponent undefined under ng test). Every remaining Jest spec in the plugin is moved to Vitest; the QR sheet builder and the locations page take their PDF/QR helpers as overridable defaults because module mocks do not work under ng test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The frontend's angular19 branch runs specs with Vitest through the Angular unit-test builder, and every backend-configuration-pn spec is migrated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ids in report styles Also index the per-row ids in the documents folder list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…efore typing Under the Angular 21 host's coalesced change detection the dialog DOM exists a frame before its first change detection; the name typed into it was wiped when ngModel wrote its initial value, leaving Save disabled until the test timed out. Wait for the interpolated title, then retry the fill until Save is enabled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…before filling The CVR number typed right after the dialog appeared was wiped by formControlName's initial write on the dialog's first (coalesced) change detection, leaving Save disabled (reproduced locally in shard l). Wait for the interpolated dialog title before filling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…expectations aria-sort was read with a one-shot getAttribute right after the header click; under the Angular 21 host's coalesced change detection the header re-renders a frame later, so the read returned null. Use toHaveAttribute / not.toHaveAttribute. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Angular 21: standalone components, Vitest and angular19 CI
The frontend angular19 branch uses Yarn 4, whose lockfile writes `version: 1.x.y` instead of Yarn 1's `version "1.x.y"`. The awk split on double quotes therefore returned an empty string, failing prewarm-playwright and skipping the pn-playwright-test matrix. Parse both formats. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ci: read the Playwright version from Yarn 4 and Yarn 1 lockfiles
There was a problem hiding this comment.
🟡 Changes recommended
One or more issues must be addressed before approval.
1 open issue
What changed in this PR
Aligns the plugin with the Angular 21 frontend on master.
Changes:
- Migrates components to standalone imports.
- Converts unit tests to Vitest and updates browser-test selectors.
- Enables Corepack and Yarn builds in Docker.
Review was static; integrated builds and tests were not run.
| File | Description |
|---|---|
| eform-client/src/app/plugins/modules/backend-configuration-pn/testing/detect-changes.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/state/files/files.reducer.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/state/chemicals/chemicals.reducer.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/state/calendar/calendar.reducer.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/state/adhoc/adhoc.reducer.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/services/backend-configuration-pn-worker-tags.service.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/services/backend-configuration-pn-task-list.service.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/services/backend-configuration-pn-tail-bite.service.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/services/backend-configuration-pn-inbox.service.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/services/backend-configuration-pn-compliance-report.service.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/services/backend-configuration-pn-chemicals.service.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/services/backend-configuration-pn-archive-folders.service.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/services/backend-configuration-pn-adhoc.service.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/services/archive-account-disabled.handler.stub.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-worker-assignments/task-worker-assignments.module.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-worker-assignments/components/task-worker-assignments-page/task-worker-assignments-page.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-wizard/task-wizard.module.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-wizard/components/task-wizard-table/task-wizard-table.component.html | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-wizard/components/task-wizard-filters/task-wizard-filters.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-wizard/components/task-wizard-actions/task-wizard-multiple-deactivate/task-wizard-multiple-deactivate.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-wizard/components/task-wizard-actions/task-wizard-folders-modal/task-wizard-folders-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-tracker/components/task-tracker-table/task-tracker-table.component.html | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-tracker/components/task-tracker-filters/task-tracker-filters.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-tracker/components/task-tracker-actions/task-tracker-shown-columns/task-tracker-shown-columns.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-tracker/components/task-tracker-actions/task-tracker-select-worker-modal/task-tracker-select-worker-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-management/task-management.module.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-management/components/task-management-table/task-management-table.component.html | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-management/components/task-management-actions/task-management-delete-modal/task-management-delete-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-list/task-list.module.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-list/components/task-list-tags/task-list-tags.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-list/components/task-list-table/task-list-table.component.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-list/components/task-list-page/task-list-edit-date.util.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-list/components/task-list-filters/task-list-filters.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-list/components/modals/batch-worker-modal/batch-worker-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-list/components/modals/batch-tags-modal/batch-tags-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-list/components/modals/batch-status-modal/batch-status-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-list/components/modals/batch-eform-modal/batch-eform-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-list/components/modals/batch-delete-modal/batch-delete-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-list/components/modals/batch-compliance-modal/batch-compliance-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-list/components/modals/batch-board-modal/batch-board-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/task-list/components/modals/batch-board-modal/batch-board-modal.component.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/tail-bite/tail-bite.routing.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/tail-bite/shared/tail-bite-tree.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/tail-bite/shared/tail-bite-rule-text.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/tail-bite/shared/tail-bite-route.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/tail-bite/shared/tail-bite-outbreak-status.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/tail-bite/shared/tail-bite-memo.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/tail-bite/shared/tail-bite-dates.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/tail-bite/components/tail-bite-outbreaks-page/tail-bite-outbreak-rows.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/tail-bite/components/tail-bite-outbreak-detail/tail-bite-outbreak-view.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/tail-bite/components/tail-bite-outbreak-detail/tail-bite-outbreak-detail.interceptor.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/tail-bite/components/tail-bite-locations-page/tail-bite-locations-page.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/tail-bite/components/tail-bite-assessment-form/tail-bite-assessment.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/statistics/statistics.module.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/statistics/components/statistics-container/statistics-container.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/statistics/components/planned-task-workers/planned-task-workers.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/statistics/components/planned-task-days/planned-task-days.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/statistics/components/document-updated-days/document-updated-days.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/statistics/components/ad-hoc-task-workers/ad-hoc-task-workers.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/statistics/components/ad-hoc-task-priorities/ad-hoc-task-priorities.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/reports/reports.module.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/reports/components/report-table/report-table.component.scss | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/reports/components/report-table/report-table.component.html | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/reports/components/report-container/report-container.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/reports/components/case-delete/case-delete.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/property-workers/property-workers.module.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/property-workers/components/property-worker-table/property-worker-table.component.html | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/property-workers/components/property-worker-table/app-install-state.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/property-workers/components/property-worker-qr-modal/property-worker-qr-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/property-workers/components/property-worker-otp-modal/property-worker-otp-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/property-workers/components/property-worker-filters/property-worker-filters.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/property-workers/components/property-worker-delete-modal/property-worker-delete-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/property-workers/components/property-worker-bulk-tags-modal/property-worker-bulk-tags-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/property-workers/components/property-worker-bulk-tags-modal/property-worker-bulk-tags-modal.component.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/files.routing.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/inbox-settings/inbox-settings.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/inbox-container/inbox-container.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/files-table/files-table.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/files-table/files-table.component.html | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/files-actions/file-create/file-create-zoom-page/file-create-zoom-page.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/files-actions/file-create/file-create-drop-zone/file-create-drop-zone.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/files-actions/download-files-name-archive/download-files-name-archive.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/file-tags/file-tags.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/archive-section-nav/archive-section-nav.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/archive-properties-dialog/archive-properties-dialog.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/archive-move-confirm-dialog/archive-move-confirm-dialog.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/archive-move-confirm-dialog/archive-move-confirm-dialog.component.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/archive-folder-tree/archive-folder-tree.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/archive-folder-tree/archive-folder-tree.component.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/archive-folder-picker/archive-folder-picker.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/archive-folder-picker/archive-folder-picker.component.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/archive-folder-name-dialog/archive-folder-name-dialog.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/archive-folder-choose-dialog/archive-folder-choose-dialog.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/components/archive-access-dialog/archive-access-dialog.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/files/archive-i18n.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/documents/components/documents-folders/documents-folders/documents-folders.component.html | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/documents/components/documents-folders/documents-folder-edit/documents-folder-edit.component.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/documents/components/documents-folders/documents-folder-delete/documents-folder-delete.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/documents/components/documents-folders/documents-folder-create/documents-folder-create.component.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/documents/components/documents-filters/documents-filters.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/compliance/components/compliances-table/compliances-table.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/compliance/components/compliances-container/compliances-container.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/compliance/components/compliance-delete/compliance-delete.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/compliance/components/compliance-case/compliance-case.module.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/compliance/components/compliance-case/compliance-case-header/compliance-case-header.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/compliance/compliance.module.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/compliance-report/store/compliance-period.storage.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/compliance-report/helpers/compliance-week-grouping.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/compliance-report/helpers/compliance-report-sections.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/compliance-report/helpers/compliance-report-row-highlight.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/compliance-report/helpers/compliance-overview.helper.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/compliance-report/components/compliance-pdf-preview-dialog/compliance-pdf-preview-dialog.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/compliance-report/components/compliance-overview-view/compliance-overview-view.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/compliance-report/components/compliance-details-view/compliance-details-view.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/compliance-report/compliance-report.module.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/chemicals/helpers/chemical-recipients.helper.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/chemicals/helpers/chemical-permissions.helper.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/chemicals/helpers/chemical-alert-rules.helper.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/chemicals/chemicals.routing.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/chemicals/chemicals.module.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/chemicals/chemicals-i18n.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/chemicals/chemicals-i18n-meaning.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/services/calendar-task.mapper.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/services/calendar-repeat.service.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/services/calendar-repeat-end-label.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/services/calendar-layout.service.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/services/calendar-copy-date.helper.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/services/calendar-board-name.helper.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/modals/task-preview-modal/task-preview-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/modals/task-delete-modal/task-delete-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/modals/repeat-scope-modal/repeat-scope-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/modals/eform-change-scope-modal/eform-change-scope-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/modals/custom-repeat-modal/custom-repeat-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/modals/calendar-select-worker-modal/calendar-select-worker-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/modals/calendar-image-lightbox/calendar-image-lightbox.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/modals/board-delete-modal/board-delete-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/modals/board-create-edit-modal/board-create-edit-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/components/store/calendar-filters.storage.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/components/calendar-week-grid/calendar-week-grid.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/components/calendar-task-block/calendar-task-block.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/components/calendar-schedule-view/calendar-schedule-view.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/components/calendar-month-view/calendar-month-view.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/components/calendar-mini-calendar/calendar-mini-calendar.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/components/calendar-header/calendar-header.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/components/calendar-header/calendar-header.component.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/components/calendar-day-column/calendar-day-column.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/components/calendar-container/calendar-container.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar-task-list/components/calendar-task-list-table/calendar-task-list-table.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar-task-list/components/calendar-task-list-page/calendar-task-list-page.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar-task-list/components/calendar-task-list-filters/calendar-task-list-filters.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar-task-list/calendar-task-list.module.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar-task-list/calendar-task-list-repeat.util.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/area-rules/components/area-rules-table/area-rules-table.component.html | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/area-rules/components/area-rule-edit-modal/area-rule-edit-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/area-rules/components/area-rule-delete-modal/area-rule-delete-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/area-rules/area-rules.module.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/adhoc/components/adhoc-table/adhoc-table.component.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/adhoc/components/adhoc-photo-delete-modal/adhoc-photo-delete-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/adhoc/components/adhoc-photo-delete-modal/adhoc-photo-delete-modal.component.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/adhoc/components/adhoc-delete-modal/adhoc-delete-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/adhoc/components/adhoc-delete-modal/adhoc-delete-modal.component.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/adhoc/components/adhoc-copy-modal/adhoc-copy-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/adhoc/components/adhoc-copy-modal/adhoc-copy-modal.component.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/adhoc/components/adhoc-complete-modal/adhoc-complete-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/adhoc/components/adhoc-complete-modal/adhoc-complete-modal.component.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/adhoc/components/adhoc-area-create-modal/adhoc-area-create-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/adhoc/components/adhoc-area-create-modal/adhoc-area-create-modal.component.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/adhoc/components/adhoc-area-admin-modal/adhoc-area-admin-modal.component.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/adhoc/adhoc.module.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/layouts/backend-configuration-pn-layout.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/helpers/inbox-classification.helper.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/helpers/future-task.helper.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/helpers/archive-panel.helper.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/helpers/archive-folders.helper.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/helpers/archive-fold.storage.spec.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/reports/report-table/report-table.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/reports/report-table/report-table.component.html | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/reports/report-container/report-container.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/reports/case-delete/case-delete.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/property-areas/property-areas.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/property-areas/property-areas.component.html | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/properties/property-actions/property-edit-areas-modal/property-areas-edit-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/properties/property-actions/property-docx-report-modal/property-docx-report-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/properties/property-actions/property-delete-modal/property-delete-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/properties/properties-page/properties-table/properties-table.component.html | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/google-drive-oauth-finish/google-drive-oauth-finish.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/google-drive-accounts/google-drive-accounts.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/backend-configuration-case/backend-configuration-case-header/backend-configuration-case-header.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/backend-configuration-case/backend-configuration-case-header/backend-configuration-case-header.component.scss | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/area-rule-plan-modal/area-rule-plan-modal.component.html | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/area-rule-plan-modal.module.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/components/area-rule-entity-list-modal/area-rule-entity-list-modal.component.ts | Updated as part of this pull request. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/backend-configuration-pn.module.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/za/tail-bite.page.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/row-action-menu.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/r/property-worker-over-midnight.spec.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/k/activate-plugin.spec.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/j/activate-plugin.spec.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/i/activate-plugin.spec.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/h/activate-plugin.spec.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/g/task-wizard.edit.spec.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/g/task-wizard.edit-frequency.spec.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/g/task-wizard.edit-assignment.spec.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/g/activate-plugin.spec.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/f/activate-plugin.spec.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/e/activate-plugin.spec.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/d/task-wizard.copy.spec.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/d/activate-plugin.spec.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/c/task-wizard.delete.spec.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/c/activate-plugin.spec.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/BackendConfigurationProperties.page.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/b/activate-plugin.spec.ts | Updated as part of this pull request. |
| eform-client/playwright/e2e/plugins/backend-configuration-pn/a/activate-plugin.spec.ts | Updated as part of this pull request. |
| eform-client/e2e/Tests/backend-configuration-settings/application-settings.plugins-page.spec.ts | Updated as part of this pull request. |
| eform-client/e2e/Tests/backend-configuration-general/task-management/backend-configuration-task-management.delete.spec.ts | Updated as part of this pull request. |
| eform-client/e2e/Tests/backend-configuration-general/property-workers/backend-configuration-property-workers.edit.spec.ts | Updated as part of this pull request. |
| eform-client/e2e/Tests/backend-configuration-general/property-workers/backend-configuration-property-workers.create.spec.ts | Updated as part of this pull request. |
| eform-client/e2e/Page objects/BackendConfiguration/BackendConfigurationTaskManagement.page.ts | Updated as part of this pull request. |
| eform-client/e2e/Page objects/BackendConfiguration/BackendConfigurationPropertyWorkers.page.ts | Updated as part of this pull request. |
| eform-client/e2e/Page objects/BackendConfiguration/BackendConfigurationProperties.page.ts | Updated as part of this pull request. |
| eform-client/e2e/Page objects/BackendConfiguration/BackendConfigurationFiles.page.ts | Updated as part of this pull request. |
| eform-client/e2e/Page objects/BackendConfiguration/BackendConfigurationDocuments.page.ts | Updated as part of this pull request. |
| eform-client/e2e/Page objects/BackendConfiguration/BackendConfigurationAreaRules.page.ts | Updated as part of this pull request. |
| eform-client/cypress/e2e/plugins/backend-configuration-pn/g/task-wizard.edit.spec.cy.ts | Updated as part of this pull request. |
| eform-client/cypress/e2e/plugins/backend-configuration-pn/g/task-wizard.edit-frequency.spec.cy.ts | Updated as part of this pull request. |
| eform-client/cypress/e2e/plugins/backend-configuration-pn/g/task-wizard.edit-assignment.spec.cy.ts | Updated as part of this pull request. |
| eform-client/cypress/e2e/plugins/backend-configuration-pn/d/task-wizard.copy.cy.ts | Updated as part of this pull request. |
| eform-client/cypress/e2e/plugins/backend-configuration-pn/c/task-wizard.delete.spec.cy.ts | Updated as part of this pull request. |
| eform-client/cypress/e2e/plugins/backend-configuration-pn/BackendConfigurationPropertyWorkers.page.ts | Updated as part of this pull request. |
| eform-client/cypress/e2e/plugins/backend-configuration-pn/BackendConfigurationProperties.page.ts | Updated as part of this pull request. |
| Dockerfile | Updated as part of this pull request. |
Review effort: Balanced
Comment on lines
+74
to
+77
| await expect(async () => { | ||
| await input.fill(text); | ||
| await expect(save).toBeEnabled({ timeout: 1000 }); | ||
| }).toPass({ timeout: UI_TIMEOUT }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Moves this plugin's Angular 21 line (
angular19) intomaster.masterhas not moved sinceangular19was created from it.angular19this was reviewed, merged and verified green against the frontend'sangular19.masteris now on Angular 21 as well (Angular 21: merge angular19 into master eform-angular-frontend#8161), so this PR's CI runs against it.🤖 Generated with Claude Code