Skip to content

Log tail default drift: lemonade returns 200 lines, protocol/vllm return 80 #17

Closed

Description

@mikeroySoft

Problem

crates/rocm-engine-protocol/src/lib.rs:15 defines DEFAULT_LOG_TAIL_LINES = 80. The vLLM engine imports it (engines/vllm/src/lib.rs:13). The Lemonade engine shadows it with a local const DEFAULT_LOG_TAIL_LINES: usize = 200 (engines/lemonade/src/lib.rs:51).

Result: a logs request without an explicit tail_lines returns 200 lines for a Lemonade service and 80 for a vLLM service. The default is a contract value and must not vary per engine.

Fix

Delete the local constant in engines/lemonade and import rocm_engine_protocol::DEFAULT_LOG_TAIL_LINES, as vLLM already does. Do not change the protocol value.

Acceptance

  • grep -rn "DEFAULT_LOG_TAIL_LINES" engines/ shows imports only, no local definitions.
  • A logs request with tail_lines: None yields the same line limit from both engines.

Activity

  1. self-assigned this
    on Sep 2, 2026
  2. added and removed
    ready-for-agentFully specified and ready for an AFK agent
    on Sep 2, 2026
  3. removed their assignment
    on Sep 2, 2026
  4. mikeroySoft commented on Sep 2, 2026

    @mikeroySoft
    OwnerAuthor

    Factory dispatcher escalating: second REVISE verdict from reviewer.

    Worker logs: /home/mike/dev/mikeroysoft/rocm-cli/.factory/logs/17-attempt-4.log

  5. self-assigned this
    on Sep 2, 2026
  6. added 2 commits that reference this issue on Sep 2, 2026
    357ed58
    3e7ed34
  7. removed their assignment
    on Sep 2, 2026
  8. mikeroySoft commented on Sep 2, 2026

    @mikeroySoft
    OwnerAuthor

    Factory dispatcher escalating: PR #25: CI failed (prek (lint / hygiene)); factory-approved label removed.

  9. added
    ready-for-agentFully specified and ready for an AFK agent
    and removed on Oct 24, 2026
  10. added a commit that references this issue on Oct 24, 2026
    8f113a8
  11. 2 remaining items

  12. removed their assignment
    on Oct 24, 2026
  13. mikeroysoft-agent commented on Oct 24, 2026

    @mikeroysoft-agent
    Collaborator

    Factory dispatcher escalating: gate failed after review bounce 1; worktree kept at /home/mike/.local/share/district/roots/rocm-cli/.factory/wt-17.

    Escalation packet: /home/mike/.local/share/district/roots/rocm-cli/.factory/escalations/17.md

    Worker logs: /home/mike/.local/share/district/roots/rocm-cli/.factory/logs/17-attempt-4.log

    Worker handoff notes:

    Ticket 17 handoff

    Changed

    • Lemonade now imports rocm_engine_protocol::DEFAULT_LOG_TAIL_LINES; its engine-local 200-line default is gone.
    • Added @id:logs-engine-omitted-tail-uses-protocol-default, which sends an omitted tail_lines through both built-in engine protocol handlers and asserts that each returns the 80 newest lines.
    • Corrected the new scenario index to logs-04 so feature naming hygiene passes.

    Verified

    • cargo xtask e2e -- -n "logs-04": PASS (1 scenario, 3 steps).
    • cargo test --manifest-path tests/e2e-cucumber/Cargo.toml --test feature_naming: PASS (4 tests).
    • cargo fmt --all -- --check: PASS.
    • Engine search: DEFAULT_LOG_TAIL_LINES appears only as protocol imports and uses; no engine-local definition remains.
    • All five ticket commits contain Signed-off-by trailers.
    • /home/mike/.local/share/uv/tools/factory/bin/python -m factory gate --report .factory/gate-report-17.md: PASS.

    Still unverified

    • Fresh remote CI after dispatcher push; this attempt was instructed not to push.

    Next

  14. mikeroysoft-agent commented on Oct 24, 2026

    @mikeroysoft-agent
    Collaborator

    Factory handoff request 17/1: a human decision is needed on #17.

    No decision owner could be determined (unassigned); a maintainer should claim it.

    Question
    How should #17 proceed? It escalated with: gate failed after review bounce 1; worktree kept at (local path withheld). Automatic recovery stopped because no manager is configured, so nothing recovers automatically.

    Evidence (bounded links; worker logs and the escalation packet stay on the runner)

    Proposed next step
    Read the evidence, then amend the ticket and relabel ready-for-agent for another attempt, fix the branch by hand, request changes on the PR, or close it. Replying here is context for humans; nothing here retries, approves or merges.

    Routing

    • decision_owner: absent — ticket body has no **Decision owner** section
    • initiative: skipped — initiative owner only routes requirements, not implementation
    • configuration: absent — no [collaboration] section in .factory.toml; legacy behaviour unchanged
      To claim or reassign this decision, set a **Decision owner** section (a GitHub login) in the issue body; the next pass reflects it and never overwrites it.
  15. added
    ready-for-agentFully specified and ready for an AFK agent
    and removed on Oct 24, 2026
  16. added a commit that references this issue on Oct 24, 2026
    4dba3bd
  17. added and removed
    ready-for-agentFully specified and ready for an AFK agent
    on Oct 24, 2026
  18. removed their assignment
    on Oct 24, 2026
  19. mikeroysoft-agent commented on Oct 24, 2026

    @mikeroysoft-agent
    Collaborator

    Factory dispatcher escalating: PR #25: gate failed after rebase onto moved main; factory-approved label removed.

    Escalation packet: /home/mike/.local/share/district/roots/rocm-cli/.factory/escalations/17.md

    Worker handoff notes:

    Ticket 17 handoff

    Changed

    • Rebased the five ticket commits through e2e: fix log scenario index onto fresh origin/main (9428da4e).
    • Excluded the unrelated test: serialize archive PATH lookups commit from the rebased branch.
    • Lemonade imports rocm_engine_protocol::DEFAULT_LOG_TAIL_LINES; no engine-local default remains.
    • Preserved @id:logs-engine-omitted-tail-uses-protocol-default, which sends omitted tail_lines requests through both built-in engine protocol handlers and asserts that each returns the 80 newest lines.
    • The origin/main...HEAD diff now contains only:
      • engines/lemonade/src/lib.rs
      • tests/e2e-cucumber/features/logs.feature
      • tests/e2e-cucumber/tests/e2e/logs_steps.rs

    Verified

    • cargo xtask e2e -- -n "logs-04": PASS (1 scenario, 3 steps).
    • cargo test --manifest-path tests/e2e-cucumber/Cargo.toml --test feature_naming: PASS (4 tests).
    • git grep -n 'DEFAULT_LOG_TAIL_LINES' -- engines: imports and uses only; no engine-local definition.
    • git diff --check origin/main...HEAD: PASS.
    • Conflict-marker search: no <<<<<<< or >>>>>>> markers.
    • All five rebased ticket commits retain Signed-off-by trailers.
    • /home/mike/.local/share/uv/tools/factory/bin/python -m factory gate --report .factory/gate-report-17.md: PASS.

    Still unverified

    • Fresh remote CI after the dispatcher updates the rewritten agent/17 branch; this attempt was instructed not to push.

    Next

  20. mikeroysoft-agent commented on Oct 24, 2026

    @mikeroysoft-agent
    Collaborator

    Factory dispatcher escalating: FIX worktree head f4e66cf8d13ab5a895922ff78abc313ae520c1cf is not the PR head 619e46b plus the worker's own commits; worktree kept at /home/mike/.local/share/district/roots/rocm-cli/.factory/wt-17.

    Escalation packet: /home/mike/.local/share/district/roots/rocm-cli/.factory/escalations/17.md

    Worker handoff notes:

    Ticket 17 handoff

    Changed

    • Rebased the five ticket commits through e2e: fix log scenario index onto fresh origin/main (9428da4e).
    • Excluded the unrelated test: serialize archive PATH lookups commit from the rebased branch.
    • Lemonade imports rocm_engine_protocol::DEFAULT_LOG_TAIL_LINES; no engine-local default remains.
    • Preserved @id:logs-engine-omitted-tail-uses-protocol-default, which sends omitted tail_lines requests through both built-in engine protocol handlers and asserts that each returns the 80 newest lines.
    • The origin/main...HEAD diff now contains only:
      • engines/lemonade/src/lib.rs
      • tests/e2e-cucumber/features/logs.feature
      • tests/e2e-cucumber/tests/e2e/logs_steps.rs

    Verified

    • cargo xtask e2e -- -n "logs-04": PASS (1 scenario, 3 steps).
    • cargo test --manifest-path tests/e2e-cucumber/Cargo.toml --test feature_naming: PASS (4 tests).
    • git grep -n 'DEFAULT_LOG_TAIL_LINES' -- engines: imports and uses only; no engine-local definition.
    • git diff --check origin/main...HEAD: PASS.
    • Conflict-marker search: no <<<<<<< or >>>>>>> markers.
    • All five rebased ticket commits retain Signed-off-by trailers.
    • /home/mike/.local/share/uv/tools/factory/bin/python -m factory gate --report .factory/gate-report-17.md: PASS.

    Still unverified

    • Fresh remote CI after the dispatcher updates the rewritten agent/17 branch; this attempt was instructed not to push.

    Next

  21. mikeroysoft-agent commented on Oct 24, 2026

    @mikeroysoft-agent
    Collaborator

    Factory manager: The blocker is branch ancestry, not the log-tail fix: kept worktree HEAD f4e66cf8d13ab5a895922ff78abc313ae520c1cf does not extend PR #25 head 619e46bc5d1123b82c60bed8fef6696d0f2c09e3. The handoff reports deliberately rebasing five ticket commits onto 9428da4e and dropping an unrelated commit, explaining the divergence.

    Preserve the worktree. A human must compare the histories and either approve replacing the PR branch using a lease against its freshly verified remote head, or restore ancestry-preserving history containing only the intended changes. Another FIX round does not authorize overwriting rewritten history; AUTHORIZE covers add-only violations only.

    The handoff reports passing targeted checks and a local gate, but the supplied gate excerpt records a ComfyUI test failure. Neither establishes current readiness. After history reconciliation, require a fresh passing gate, independent APPROVE, and green remote CI.

  22. mikeroysoft-agent commented on Oct 24, 2026

    @mikeroysoft-agent
    Collaborator

    Factory handoff request 17/3: a human decision is needed on #17.

    No decision owner could be determined (unassigned); a maintainer should claim it.

    Question
    How should #17 proceed? It escalated with: FIX worktree head f4e66cf8d13ab5a895922ff78abc313ae520c1cf is not the PR head 619e46b plus the worker's own commits; worktree kept at (local path withheld). Automatic recovery stopped because the manager asked for a human decision.

    Evidence (bounded links; worker logs and the escalation packet stay on the runner)

    Proposed next step
    Read the evidence, then amend the ticket and relabel ready-for-agent for another attempt, fix the branch by hand, request changes on the PR, or close it. Replying here is context for humans; nothing here retries, approves or merges.

    Routing

    • decision_owner: absent — ticket body has no **Decision owner** section
    • initiative: skipped — initiative owner only routes requirements, not implementation
    • configuration: absent — no [collaboration] section in .factory.toml; legacy behaviour unchanged
      To claim or reassign this decision, set a **Decision owner** section (a GitHub login) in the issue body; the next pass reflects it and never overwrites it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions