Repository navigation
agent/17: Log tail default drift: lemonade returns 200 lines, protocol/vllm return 80 - #25
Conversation
Standards
No other standards violations or notable code smells were found. The supplied gate report is accepted as authoritative. Spec
The production change itself correctly removes Lemonade’s local GitHub issue #17’s exact text could not be retrieved because GitHub API access was unavailable; the Spec assessment therefore uses the issue description recorded in the commit message. VERDICT: REVISE |
Standards
No other standards violations or notable code smells were found. The supplied gate report is accepted as authoritative. SpecNo findings. The diff removes Lemonade’s local default, imports the unchanged protocol constant, and verifies that an omitted limit returns the newest 80 lines. The helper extraction and explicit-limit assertion are directly relevant and do not constitute scope creep. Summary: Standards—1 finding (missing Gherkin coverage). Spec—0 findings. VERDICT: REVISE |
StandardsNo findings. The diff follows repository conventions for protocol ownership, regression testing, and user-observable Gherkin coverage. No material code smells identified. SpecNo findings. The issue text was unavailable because GitHub access failed. Based on the diff and commit context, the change consistently applies the protocol’s 80-line default to Lemonade, preserves explicit limits, and adds focused and end-to-end regression coverage across both built-in engines. The supplied deterministic gate report is authoritative: all checks passed. Summary: Standards—0 findings; Spec—0 findings. VERDICT: APPROVE |
c2cd5f3 to
891781d
Compare
|
{"type":"session","version":3,"id":"01a16ec7-9605-71e8-972f-ad7b6125471a","timestamp":"2026-10-24T16:38:56.261Z","cwd":"/tmp/factory-review-gejanq6y"} Factory rejected reviewer evidence: review_exit:1. |
Review: #17, Lemonade log tail default driftSpec check (issue #17)The #17 change itself is correct:
Required fixes (blocking)
Optional suggestions (non-blocking)
VERDICT: REVISE |
A logs request without tail_lines returned 200 lines from lemonade but 80 from vllm. The default is a protocol contract value; import it as vllm already does. Adds a regression test pinning the engine default to the protocol constant. Fixes #17 Signed-off-by: Michael Roy <mike@mikeroysoft.com>
Replace the tautological constant-equality test with one that writes a 200-line log and asserts a request with tail_lines omitted returns exactly DEFAULT_LOG_TAIL_LINES (80) lines ending at the newest line. Extract recent_log_lines(path, Option<usize>) from logs_response so the default resolution is testable without going through AppPaths::discover. No Gherkin scenario: neither rocm nor rocmd invokes EngineMethod::Logs; `rocm logs --service` reads the log file directly with the CLI's own DEFAULT_LOG_TAIL_LINES. The changed default is observable only over the engine-plugin JSON protocol, which the black-box e2e harness does not drive. Signed-off-by: Michael Roy <mike@mikeroysoft.com>
The changed default is observable only over the engine-plugin `logs` method, which neither `rocm` nor `rocmd` invokes on a user's behalf. Drive the built-in engines through the hidden `rocm __engine-stdio` entry point instead: plant a 200-line service log for lemonade and vllm, request logs without `tail_lines`, and assert both return exactly the 80-line protocol default ending at the newest line. Scenario @id:logs-engine-omitted-tail-uses-protocol-default fails with the old lemonade-local 200 default and passes with the protocol import. It reads planted files only, so it runs on the mock lane every PR. Signed-off-by: Michael Roy <mike@mikeroysoft.com>
Signed-off-by: mikeroysoft-agent <339795455+mikeroysoft-agent@users.noreply.github.com>
Signed-off-by: mikeroysoft-agent <339795455+mikeroysoft-agent@users.noreply.github.com>
StandardsNo required fixes.
Optional:
Spec (issue #17)
Summary:
VERDICT: APPROVE |
|
Gate failed after rebase onto current main: Gate reportHost toolchainROCm: unavailable
tests failure |
Closes #17
Gate report
Gate report