You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(UI): Name the Statuses as CONTEXT.md does - #166
The Set Status buttons, the status CSS classes, FakeStatus and Enums.Status used Answered, InWork, Watching, Dismissed, so on a seeded database the "in work" button looked up a Status that didn't exist and threw.
Now:
Everything uses Accepted, Watching, Upcoming, Dismissed: seed data, FakeStatus, Enums.Status (kept, since FakeStatus picks from it; members keep their positions), IssueComponent's status styles, and the Set Status buttons (ids, labels, CSS classes). site.css classes are renamed to match.
The seeded Status descriptions and the Create page say "issue" instead of "suggestion".
Existing data
scripts/migrations/152-rename-answered-status.js renames Answered Status records to Accepted, updates each Issue's embedded copy (IssueStatus.StatusName), and rewords seeded descriptions that still say "suggestion" (an Admin's own wording is left alone). It can safely be run more than once. Run it once per environment after this merges:
Tested twice against a throwaway mongo:8 container: the first run renamed and reworded, the second changed nothing.
Testing
UI tests updated to the new names (18 failed before the source change); IssueTracker.UI.Tests.Unit 148, CoreBusiness 86, Services 99, PlugIns 37 passed.
The glossary names the Statuses Accepted, Watching, Upcoming and
Dismissed, but the code used three different sets. The seeder created
Answered, Watching, Upcoming and Dismissed, while the Set Status
buttons, the status styles, FakeStatus and Enums.Status used Answered,
InWork, Watching and Dismissed. On a seeded database the "in work"
button looked up a Status that didn't exist and threw.
Everything now uses Accepted, Watching, Upcoming and Dismissed,
including the button ids and CSS classes. The seeded descriptions and
the Create page say "issue" instead of "suggestion".
scripts/migrations/152-rename-answered-status.js renames existing
Answered records, including each Issue's copy of its Status, and
rewords seeded descriptions. It can safely be run more than once.
Refs #152
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The migration replaced any description matching /suggestion/, so an
Admin's own wording that used the word was overwritten too. It now
replaces only the exact text the seeder used to write. Addresses
Copilot review on #166.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This rename creates a second .issue-detail-status-upcoming rule (the existing one is immediately below at line 504). Because both have equal specificity, the later #835581 declaration always overrides this #fd7e14 declaration, leaving the renamed rule ineffective. Remove one block or consolidate them into a single rule with the intended Upcoming color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First half of #152 (the
ApprovedForRelease→Approvedrename follows in its own PR).The glossary names the Statuses Accepted, Watching, Upcoming, Dismissed, but the code used three sets:
SampleDataseeded Answered, Watching, Upcoming, Dismissed.FakeStatusandEnums.Statusused Answered, InWork, Watching, Dismissed, so on a seeded database the "in work" button looked up a Status that didn't exist and threw.Now:
FakeStatus,Enums.Status(kept, sinceFakeStatuspicks from it; members keep their positions),IssueComponent's status styles, and the Set Status buttons (ids, labels, CSS classes).site.cssclasses are renamed to match.Existing data
scripts/migrations/152-rename-answered-status.jsrenamesAnsweredStatus records toAccepted, updates each Issue's embedded copy (IssueStatus.StatusName), and rewords seeded descriptions that still say "suggestion" (an Admin's own wording is left alone). It can safely be run more than once. Run it once per environment after this merges:mongosh "<connection string>/<database>" scripts/migrations/152-rename-answered-status.jsTested twice against a throwaway
mongo:8container: the first run renamed and reworded, the second changed nothing.Testing
IssueTracker.UI.Tests.Unit148, CoreBusiness 86, Services 99, PlugIns 37 passed.scripts/gate.shpassed.Refs #152
🤖 Generated with Claude Code