Repository navigation
refactor(CoreBusiness): Rename ApprovedForRelease to Approved - #168
Merged
Merged
Conversation
CONTEXT.md defines Approval as an Admin's decision that an Issue may be shown to every User, not that it ships in a release. The property is now Approved, and its doc comments and the approved-Issue queries say what it means. It is still stored as approved_for_release, so existing data needs no migration, and a new test holds that. Fixes #152 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The rename is consistently applied and persistence compatibility is explicitly preserved and tested.
Review effort: Balanced
Findings: None
What changed in this PR
Renames the approval domain property while preserving MongoDB compatibility and existing visibility behavior.
Changes:
- Renames
ApprovedForReleasetoApprovedacross all layers. - Retains the
approved_for_releaseMongoDB field. - Updates documentation, fakes, and tests.
| File | Description |
|---|---|
tests/IssueTracker.UI.Tests.Unit/Pages/ProfileTests.cs |
Updates profile test data. |
tests/IssueTracker.UI.Tests.Unit/Pages/DetailsTests.cs |
Updates visibility test data. |
tests/IssueTracker.UI.Tests.Unit/Pages/CommentTests.cs |
Updates comment visibility tests. |
tests/IssueTracker.UI.Tests.Unit/Pages/AdminTests.cs |
Updates admin test setup. |
tests/IssueTracker.Services.Tests.Unit/Issue/IssueServiceTests.cs |
Updates service approval tests. |
tests/IssueTracker.PlugIns.Tests.Unit/DataAccess/IssueRepositoryTests.cs |
Updates repository filter tests. |
tests/IssueTracker.PlugIns.Tests.Integration/DataAccess/GetIssuesWaitingForApprovalTests.cs |
Updates pending-issue integration coverage. |
tests/IssueTracker.PlugIns.Tests.Integration/DataAccess/GetApprovedIssuesTests.cs |
Updates approved-issue integration coverage. |
tests/IssueTracker.CoreBusiness.Tests.Unit/Models/IssueModelTests.cs |
Verifies persisted BSON field compatibility. |
src/UI/IssueTracker.UI/Pages/Profile.razor.cs |
Uses the renamed property for grouping. |
src/UI/IssueTracker.UI/Pages/Admin.razor.cs |
Uses the renamed property when approving. |
src/Services/IssueTracker.Services/PlugInRepositoryInterfaces/IIssueRepository.cs |
Clarifies approval semantics. |
src/Services/IssueTracker.Services/Issue/IssueService.cs |
Updates issue visibility logic. |
src/Services/IssueTracker.Services/Issue/Interface/IIssueService.cs |
Clarifies approval semantics. |
src/PlugIns/IssueTracker.PlugIns/DataAccess/IssueRepository.cs |
Updates approval filters. |
src/CoreBusiness/IssueTracker.CoreBusiness/Models/IssueModel.cs |
Renames the property while retaining its BSON name. |
src/CoreBusiness/IssueTracker.CoreBusiness/BogusFakes/FakeIssue.cs |
Updates generated issue data. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage 85.40% 85.40%
=======================================
Files 77 77
Lines 1596 1596
Branches 150 150
=======================================
Hits 1363 1363
Misses 189 189
Partials 44 44
|
mpaulosky
added a commit
that referenced
this pull request
Sep 30, 2026
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second half of #152 (the Status names landed in #166).
CONTEXT.mddefines Approval as an Admin's decision that an Issue may be shown to every User, not that it ships in a release.IssueModel.ApprovedForReleaseis nowApproved, across CoreBusiness, PlugIns, Services, UI and the tests.GetApprovedIssuesinIIssueServiceandIIssueRepository, now describe it that way.approved_for_release([BsonElement], as before), so existing data needs no migration.Testing
IssueModelTeststest: an approved Issue serializes withapproved_for_release: trueand noApprovedelement, so a future rename can't silently change the stored field.dotnet build -warnaserrorclean;scripts/gate.shpassed.Fixes #152
🤖 Generated with Claude Code