Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
Current qualification at published head Exact-head CIRun 42856360767 is red:
Fresh local integrated checks
Further cancellation investigation
Broad UI gate and main controlsThe complete default development functional matrix at Fresh selected controls at main Bounded paired repeats on main
Static review locates inherited hover ownership in button/sibling styling and the MCP fixture's stale inline-iframe read before its window-button action. Pairing is not mounted in those seeded flows. Timing/frame assertions and all deadlines remain unchanged. Main reproductions and selected passes establish boundaries, not an overall UI pass. Disposition and next steps
The native/API prerequisite is already merged #1285. Desktop Human proof, immutable choice, private-session cleanup and no implicit read grant are implemented here. Committed source checkpoints and fail/restore evidence remain accurate. No real devices, live account grants, provider credentials, native WKWebView/host IPC or deployment were exercised. Historical receipts at earlier source cuts (not final-head qualification)Current qualification at published head The full default development functional matrix finished in 7,798.3s, exit 1: 1,530/1,620 attempted cases held, with 18 cases unable to run. Of 38 families, 27 held, 10 failed and command-order could not fully run. Both Chromium/WebKit, columns/sidebar and all default sizes ran.
Passed families include smoke32/32, ambient8/8, safe-area90/90, committed-transcript120/120, tab lifetimes24/24, lease details108/108, gateway states14/14, linked devices18/18, shares26/26, session rows10/10, widgets48/48, approval deadlines2/2, clock snapshots4/4, published files24/24, attachments144/144 and the remaining transcript/turn/send checks. These are current frontend observations, not a global pass. CI42824610437 passed every executed qualification job, including frontend 455 files / 5,802 tests + 44 webhook tests, native pairing 4/4, full default stress 71/71, Windows and Linux. Initial macOS never acquired a hosted runner (capacity annotations, no steps), which made the required-check gate red. The focused macOS retry is now executing; all-platform qualification is pending. CI checkout Production scripted/default/raised Gateway reruns are following the functional matrix serially. Fresh exact-configuration main controls are prepared (36 groups so far), and are not yet results. Main has since advanced to Static attribution review found no new pairing startup/iframe route: normal session composition already eagerly imports the SDK; private pairing operations are lazy. The row-hover path is unchanged main CSS filling only the button while its sibling action owns the pointer. MCP The two corrected verification prerequisites pass and their probes bite: unexpected masthead copy fails4 assertions; removing only MCP inventory whitelist support fails16. Both restore to smoke32/32 and linked18/18. Verification units pass682 with2 skips; independent integration and harness reviews are clean. State checks pass180, with reviewed desktop source checkpoint Local receipts: The receipts below are historical through Desktop verification evidence for #893. This comment tracks qualification; the PR remains draft. At behavioral checkpoint The old-UI control failed Final remote head: The rebuilt local production scripted aggregate passes, including native gateway 4/4. Selected Gateway stress passes in both engines and both layouts: default1 10/10, raised3 14/14 per layout (parallel6, turns4, followers4, rounds40, seed7 for raised). These selected raised runs are distinct from the full default CI cohort. The broad local functional gate is red: 985/1,102 attempted cases held; sixteen whole checks are dev-server-only. Targeted controls on main reproduced every failing test name. The full paired WebKit-sidebar focus profiles held main 10/23, 10/23, 10/23 versus branch 10/23, 10/23, 11/23; the burst failure occurred main3/3 versus branch2/3. Main also reproduces linked devices 2/18 with Both earlier CI harness defects are fixed and independently reviewed. The committed evidence preserves the behavioral control/source cuts; the PR description and this comment are the final qualification record. Real devices, live accounts, native WKWebView execution and deployment were not exercised. |
…3-desktop-same-person
Use the row frame as the pointer owner while its trailing action is shown. Keep the control-specific pressed and selected rules unchanged. Fixes #1325.
Keep the failed Linux measurements and add a manual measurement on the standard Mac matrix leg without changing the budget or required jobs. Part of #1325.
…25-stress-receipt
Add a focus-only measurement plan without changing full/default scope or time bounds. Keep test frame handles in the native allocator, and guard moved-row setup and identity. Retain default and raised gateway-pairing coverage in the composed stress plan. Correct the ADR's stale frame-count description to the existing shared time budget. Scoped independent reviews are clean. Actual stock focus remains red:82/93 held, 8 failed and3 could not run; the helper repair is not a claim to fix those failures. No production focus clock, deadline, auth/grant capability or application state changes. No state checkpoint advances for these verification/tooling-only changes.
…3-frame-budget-probe
…3-frame-budget-probe
…25-stress-receipt
**Before:** Native CI could lose an assertion when GitHub truncated its annotation or later successful output displaced it. The external-event HTTP fixture also waited for socket EOF, and ordinary preparation-fixture teardown cut its transport before strong retirement. **After:** Failed children retain the existing bounded tail in correlated annotation parts. HTTP tests consume the actual framed response under the existing 20-second bound, and ordinary preparation teardown keeps its transport available through service retirement. Execution results, admission rules and deadlines retain their existing owners. Follow-up verification work from #1325. Its hover repair already merged in #1337 and #1325 is closed. This PR's twelve-file delta contains CI/test tooling, fixture repairs and their owning documentation. ## Background The native matrix runs real Cargo executables. Its original single oversized annotation did not establish that GitHub received the assertion. Receiver message/count limits differ from the local bounded tail. The preceding published dd7eb81 head passed eleven jobs in [CI43660899364](https://github.com/nessalabs/nessa-agent/actions/runs/43660899364), but Windows server-other failed four external-event requests at their original 20-second read bound. Multipart annotations reconstructed the complete failure report with verified SHA256 f4d549a204ea62266b468702cc6a44183cf18167c204377e3f55671822ea3d9d. That proves retained evidence, not the cause of those timeouts. ## The problem Reporting and test-fixture lifecycle must not invent successful execution, authority or release. A complete HTTP response does not require socket EOF; an End request count does not establish acknowledgement or persistence. An ordinary teardown should let its existing strong retirement finish before deliberately cutting the mock transport. ## The solution ```mermaid flowchart LR F["Failed child: existing bounded tail"] --> P["Indexed, correlated annotation parts"] --> R["Reader checks completeness and digest"] F --> E["Original child result stays authoritative"] ``` - Existing native reporting retains default libtest capture, bounded multipart output and original child results even when formatting or reporting fails. Lease-timeout observations remain bounded and nonblocking after the original deadline; save entry is an observation, not a write receipt. Optional Mac measurement retains its original parameters. - The external-event fixture uses the existing HTTP client's framing, explicit local TLS selection and a total 20-second send/body-receive bound. Exact signed body bytes and physical duplicate headers reach the actual router. Valid-MAC duplicate-header tests reject before authority/store/provider effects. Synchronous JSON CPU decoding is not claimed bounded. - The child-preparation fixture keeps every earlier owner/capacity, first actor/cause, Closed, once-End and capacity-reuse assertion. It awaits unchanged strong service/storage retirement, observes three End requests, then closes the mock connection. SDK stale-generation rejection and deliberate disconnect cases remain unchanged. The original full pre-push attempt at `8f68b1f` failed after 1,883 conversation passes with AttachmentAuthorizationStale in strong retirement. Sixteen isolated original controls passed, so its exact intermittent cause remains unproven. The new ordering has its own executable regression; neither selected passes nor source inspection establish that original cause. ## How we checked it Published and remotely verified source: [3ec743a](3ec743a). It includes main `a8ee3b188b7ea6eab537c8ffe017ce8bbcdf5895` with all 46 incoming paths byte-exact. The full normal-host mandatory pre-push passed in 1890 seconds. No hook, assertion, timeout, concurrency setting or required aggregate was bypassed. Local native desktop host checks explicitly skip where WebKitGTK is absent. An intervening mandatory build attempt failed linking the server test executable with SIGBUS amid severe disk pressure, before native tests ran. Generated workspace-package artifacts were then cleared after all checks ended, restoring about 11 GB free; source, raw verification evidence and the pinned browser CLI were retained. The successful full retry above uses unchanged build, thread, feature and deadline settings. New [exact-head checks](https://github.com/nessalabs/nessa-agent/commit/3ec743acb7bb433671ce8c51e8f5493fd02fad77/checks) retain their own current status; this publication statement does not claim a hosted all-platform pass. Prior dd7 failures remain retained. - HTTP repair: 20 native tests and focused Node/CI contracts passed, CI21 strict all-target Clippy/test compilation and isolated crate checks passed, and four actual fault/restoration pairs exercised EOF completion, missing timeout and both duplicate-header guards. Fresh full CODE R2 is clean; independent 20 native, 13 Node and 38 adversarial checks passed. - Preparation repair: both child variants and adjacent preparation paths passed 9/9. Restoring cut-before-retire while retaining the new count executed one failing test (1 versus 3 End requests); restoring the repair passed 9/9. The full default-parallel conversation library passed 1,884 with zero failures and seven existing ignores. CI21 and isolated strict all-target Clippy, formatting and docs validation (179 documents, zero issues) passed. Fresh assembled CODE R1 is clean; independent 19 native and 13 Node passed. - Prior runner/lease integration reviews and actual Cargo partition/receiver controls remain source-bound. Counts from overlapping review suites are not presented as unique tests. The earlier ENOSPC/linker failure executed no tests and is not negative regression evidence. ## Tradeoffs and follow-ups Masking, cancellation, receiver capacity, a later hang and output beyond the retained tail can still leave incomplete evidence. Digests correlate content, not unique executions. Default capture can delay an assertion if a later case hangs. The original Windows timeout and intermittent stale-ticket causes remain unproven. This residual changes no product UI, admission, credential class, same-person attribution, share grant or owner-phone consent. Browser gate 17 does not apply to this CI/test-only residual; #1296's failed and incomplete browser/stress/quiet-host performance/native WK/manual qualification remains required independently. No merge or issue #893 completion is claimed. The fixture ordering is recorded in existing ADR329 cycle 8; HTTP boundaries remain in the owning external-events design. No production lifecycle/model change or unrelated state-page review occurred, so unrelated sourceRevision/modelCheck checkpoints remain unchanged. ## Rollout No migration or product setting. Revert the scoped CI/reporting and fixture changes to restore the earlier behavior.


Before: Devices paired phones and agent computers, but had no read-gateway invitation or same-person choice.
After: Devices → Add device → Gateway offers the immutable creation choice. True uses explicit Human reauthentication on a separate pairing-only session; false keeps the panel path. The existing native authority owns activation, attribution and cleanup.
Part of #893. API/CLI, principal/grant persistence and link lifecycle support already merged in #1285. This PR remains draft: broader UI qualification is red, so #893 is not declared complete.
Background
PeerRead gateways require separate conversation share grants. Phones retain OwnerPhone consent and agent computers retain Environment consent. The panel stays Integration. Only the credential registry supplies Human provenance; an administrator role, caller label, namespace or placement's internal
Creation::Personcategory cannot supply it.#1282/#1286 UI semantics are preserved. Main's #1291 ambient renderer, #1293 Place type and #1301 placement/stress work are integrated without replacing their hunks.
The problem
The desktop lacked both the gateway entry and a specified Human proof path. Adding this choice to phone/computer pairing would change their consent classes.
The solution
hold.peer, PeerRead, DeviceRead, grant subject and phone consent remain with their existing owners.How we checked it
Published head:
8fc4301afed597d998d773453d9d9fed9e3501e3. Assembled source checkpoint:3cb4eecdb524757253fe786152f8a89b54436d52, with main6c70aeb9integrated.3cb4eecd; native/server/Cargo trees match main exactly.3cb4eecd; native and OwnerPhone checkpoints retain their scope. Diagram body unchanged; no TLA/TLC claim.88bc8b58: 1,530/1,620 held, exit1, 18 cases unable to run, 7,798.3s. 27 families held, 10 failed and command-order could not fully run. Both engines/layouts/default sizes; separate perf budget omitted. Frontend/SDK/functional check sources remain unchanged; this does not establish new native assembly behavior.19954d1f, same functional frontend as6c70aeb9: 51/133 held in 36 diagnostic groups. They reproduce the red families, with individual-case variation. These are selected controls, not a complete main matrix or performance-rate estimate.At the preceding
88bc8b58checkpoint, CI42824610437 passed 13/13 after the initial macOS runner-capacity failure was retried. It includes frontend 455 files / 5,802 tests + 44 webhook tests, native pairing 4/4, default full stress 71/71, Windows and Linux/macOS qualification. Local production scripted passed, with Gateway stress 10/10 default and 14/14 raised per layout. These retain their source cut; they do not substitute for final-head native/CI results.Negative controls cover 45 deliberate unit mutations at the behavioral checkpoint, restored after each; unchanged reducer relocation is recorded by hash. Native probes exercise actual audit-write failure/restoration, stable credential/receiver retry, no implicit share, Integration-attributed revoke and later false enrollment without stale attribution. The obsolete UI and wrapping controls fail their intended assertions and pass restored. Mandatory harness corrections also bite: unexpected masthead copy fails4 assertions; removing only MCP-list whitelist support fails16, restored to smoke32/32 and linked18/18.
Live receipts, exact main-control configurations and unresolved gates. Committed implementation/source checkpoints and control evidence.
Tradeoffs and follow-ups
Explicit Human token entry is the selected proof path. It adds no durable Integration-to-Human relation or owner-secret fallback. The token retains its existing authority, while only the pairing port reaches its private client. The input clears; no application storage or URL retains it; reconnect is disabled. The ten-minute scheduled UI timer depends on the event loop and is not credential expiry or a server session TTL. JavaScript string zeroization is not promised.
A saved choice or Active phase does not prove that the person link committed or that reads are allowed. The separate share grant and native admission remain canonical. Real devices, provider credentials, native WKWebView/host IPC and the separate performance budget are outside these browser receipts.
Broader failures remain blocking. Static review identifies inherited button/sibling hover styling and stale inline-iframe reads; main controls also reproduce overview/motion, notice, background, bidi and delivery failures. The CI phone-cancel failure is not reproduced by the five selected controls and remains unresolved; the complete local Ubuntu CI-scope diagnostic passed71/71 without reproducing it. This retains the original red CI outcome. The source-identical Windows lease-test timeout also remains unresolved. Main's newer #1299 tooling/lint commit
bc8cb5109was reviewed and textually merges cleanly; it is not integrated into the frozen head. Active #1294 head945f2ca0retains sidebar ownership. No assertion or deadline is relaxed and no overall UI pass or merge readiness is claimed.Rollout
No persistence migration. Reverting the desktop entry leaves stored invitations and their lifecycle with the existing registry.