Skip to content

Keep sidebar rows highlighted over trailing actions (#1325) - #1337

Merged
Varuas37 merged 4 commits into
mainfrom
claude/project-thread-xlhibm
Nov 14, 2026
Merged

Varuas37 merged 4 commits into
mainfrom
claude/project-thread-xlhibm

Conversation

@Varuas37

Copy link
Copy Markdown
Contributor

Requested by Saurav · project thread

Before: A sidebar row loses its highlight when the pointer moves onto its trailing action.

After: The highlight stays while the pointer is anywhere over that row, including its action.

Closes #1325. This is the hover fix from #1326 on its own, as Codex asked there (finding). The Advanced smoke change, Cargo diagnostics, lease-test instrumentation, stress-verdict artifact and the manual Mac performance input stay on #1326's branch; once this merges, #1326's diff shrinks to just those.

Background

The kit draws a sidebar row as a frame holding two siblings: the row control (name, count, glyph) and its trailing action button.

The problem

The window painted the hover fill only while the control itself was hovered. Moving onto the sibling action keeps the frame hovered but not the control, so the control goes transparent. The control-only selector came from 45458da (#668).

sequenceDiagram
  participant P as Person
  participant F as Row frame
  participant C as Row control
  participant A as Trailing action
  P->>C: points at the row
  C-->>P: control hovered, row highlighted
  P->>A: moves onto the action
  Note over F,C: frame still hovered, control is not
  C-->>P: highlight disappears (bug)
Loading

Before, Chromium

The solution

8c6145c lets the frame's hover supply its direct control's fill. Specificity stays (0,2,0), so selected, pressed and overview rules keep precedence, and the action keeps its hit target. 4ec942f and 92426f2 record the evidence.

sequenceDiagram
  participant P as Person
  participant F as Row frame
  participant C as Row control
  participant A as Trailing action
  P->>C: points at the row
  F-->>C: frame hovered, control gets the fill
  P->>A: moves onto the action
  F-->>C: frame still hovered, control keeps the fill
  C-->>P: row stays highlighted
Loading

After, Chromium

How we checked it

  • The existing measured rows check, shared-controls.mjs --only rows, Chromium, columns + sidebar, on this branch: 2/2 held. Reverting only the selector: 1/2 held, failing with kit row under its glyph: its fill is rgba(0, 0, 0, 0). Restored: 2/2. (The cloud sandbox can't download WebKit; the original WebKit receipts, 4/4 → 2/4 → 4/4, are in the evidence README.)
  • pnpm frontend:check and the pre-push hook passed.
  • Conversation stress: no new step. This is a paint rule for pointer hover; it changes nothing a person or agent does through a conversation (CODING_STANDARDS gate 19). The rows check owns this contract.
  • Not run here: native WKWebView/manual check on a Mac, and the full shared-controls/smoke matrices (the evidence README records their earlier, unrelated failures: WebKit segmented timeouts and the Advanced smoke assertion).

Tradeoffs and follow-ups

None for the fix itself. Pressed, coarse-pointer and overview-glass precedence were reviewed in source, not proven by the focused check.

Rollout

Nothing special. Revert the selector to undo it.


Generated by Claude Code

Use the row frame as the pointer owner while its trailing action is shown. Keep the control-specific pressed and selected rules unchanged.

Fixes #1325.
Record the unchanged browser regression and its revert probe for #1325.

The control-only hover selector came from 45458da (Desktop: one component per repeated pattern). Keep this repair separate from sidebar parking and pairing.
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 98248f6e-3938-4d44-89e4-72f3abcc8410
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Varuas37
Varuas37 marked this pull request as ready for review November 14, 2026 16:58
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T17:00:20.895709Z 92426f2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 92426f297d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JcBpmRaEvnV3CE7XJxEEsA
@Varuas37
Varuas37 merged commit cc39f7c into main Nov 14, 2026
13 checks passed
@Varuas37
Varuas37 deleted the claude/project-thread-xlhibm branch November 14, 2026 21:37
Varuas37 added a commit that referenced this pull request Nov 17, 2026
**Before:** Native CI could lose an assertion when GitHub truncated its
annotation or later successful output displaced it. The external-event
HTTP fixture also waited for socket EOF, and ordinary
preparation-fixture teardown cut its transport before strong retirement.

**After:** Failed children retain the existing bounded tail in
correlated annotation parts. HTTP tests consume the actual framed
response under the existing 20-second bound, and ordinary preparation
teardown keeps its transport available through service retirement.
Execution results, admission rules and deadlines retain their existing
owners.

Follow-up verification work from #1325. Its hover repair already merged
in #1337 and #1325 is closed. This PR's twelve-file delta contains
CI/test tooling, fixture repairs and their owning documentation.

## Background

The native matrix runs real Cargo executables. Its original single
oversized annotation did not establish that GitHub received the
assertion. Receiver message/count limits differ from the local bounded
tail.

The preceding published dd7eb81 head passed eleven jobs in
[CI43660899364](https://github.com/nessalabs/nessa-agent/actions/runs/43660899364),
but Windows server-other failed four external-event requests at their
original 20-second read bound. Multipart annotations reconstructed the
complete failure report with verified SHA256
f4d549a204ea62266b468702cc6a44183cf18167c204377e3f55671822ea3d9d. That
proves retained evidence, not the cause of those timeouts.

## The problem

Reporting and test-fixture lifecycle must not invent successful
execution, authority or release. A complete HTTP response does not
require socket EOF; an End request count does not establish
acknowledgement or persistence. An ordinary teardown should let its
existing strong retirement finish before deliberately cutting the mock
transport.

## The solution

```mermaid
flowchart LR
  F["Failed child: existing bounded tail"] --> P["Indexed, correlated annotation parts"] --> R["Reader checks completeness and digest"]
  F --> E["Original child result stays authoritative"]
```

- Existing native reporting retains default libtest capture, bounded
multipart output and original child results even when formatting or
reporting fails. Lease-timeout observations remain bounded and
nonblocking after the original deadline; save entry is an observation,
not a write receipt. Optional Mac measurement retains its original
parameters.
- The external-event fixture uses the existing HTTP client's framing,
explicit local TLS selection and a total 20-second send/body-receive
bound. Exact signed body bytes and physical duplicate headers reach the
actual router. Valid-MAC duplicate-header tests reject before
authority/store/provider effects. Synchronous JSON CPU decoding is not
claimed bounded.
- The child-preparation fixture keeps every earlier owner/capacity,
first actor/cause, Closed, once-End and capacity-reuse assertion. It
awaits unchanged strong service/storage retirement, observes three End
requests, then closes the mock connection. SDK stale-generation
rejection and deliberate disconnect cases remain unchanged.

The original full pre-push attempt at `8f68b1f` failed after 1,883
conversation passes with AttachmentAuthorizationStale in strong
retirement. Sixteen isolated original controls passed, so its exact
intermittent cause remains unproven. The new ordering has its own
executable regression; neither selected passes nor source inspection
establish that original cause.

## How we checked it

Published and remotely verified source:
[3ec743a](3ec743a).
It includes main `a8ee3b188b7ea6eab537c8ffe017ce8bbcdf5895` with all 46
incoming paths byte-exact. The full normal-host mandatory pre-push
passed in 1890 seconds. No hook, assertion, timeout, concurrency setting
or required aggregate was bypassed. Local native desktop host checks
explicitly skip where WebKitGTK is absent.

An intervening mandatory build attempt failed linking the server test
executable with SIGBUS amid severe disk pressure, before native tests
ran. Generated workspace-package artifacts were then cleared after all
checks ended, restoring about 11 GB free; source, raw verification
evidence and the pinned browser CLI were retained. The successful full
retry above uses unchanged build, thread, feature and deadline settings.

New [exact-head
checks](https://github.com/nessalabs/nessa-agent/commit/3ec743acb7bb433671ce8c51e8f5493fd02fad77/checks)
retain their own current status; this publication statement does not
claim a hosted all-platform pass. Prior dd7 failures remain retained.

- HTTP repair: 20 native tests and focused Node/CI contracts passed,
CI21 strict all-target Clippy/test compilation and isolated crate checks
passed, and four actual fault/restoration pairs exercised EOF
completion, missing timeout and both duplicate-header guards. Fresh full
CODE R2 is clean; independent 20 native, 13 Node and 38 adversarial
checks passed.
- Preparation repair: both child variants and adjacent preparation paths
passed 9/9. Restoring cut-before-retire while retaining the new count
executed one failing test (1 versus 3 End requests); restoring the
repair passed 9/9. The full default-parallel conversation library passed
1,884 with zero failures and seven existing ignores. CI21 and isolated
strict all-target Clippy, formatting and docs validation (179 documents,
zero issues) passed. Fresh assembled CODE R1 is clean; independent 19
native and 13 Node passed.
- Prior runner/lease integration reviews and actual Cargo
partition/receiver controls remain source-bound. Counts from overlapping
review suites are not presented as unique tests. The earlier
ENOSPC/linker failure executed no tests and is not negative regression
evidence.

## Tradeoffs and follow-ups

Masking, cancellation, receiver capacity, a later hang and output beyond
the retained tail can still leave incomplete evidence. Digests correlate
content, not unique executions. Default capture can delay an assertion
if a later case hangs. The original Windows timeout and intermittent
stale-ticket causes remain unproven.

This residual changes no product UI, admission, credential class,
same-person attribution, share grant or owner-phone consent. Browser
gate 17 does not apply to this CI/test-only residual; #1296's failed and
incomplete browser/stress/quiet-host performance/native WK/manual
qualification remains required independently. No merge or issue #893
completion is claimed.

The fixture ordering is recorded in existing ADR329 cycle 8; HTTP
boundaries remain in the owning external-events design. No production
lifecycle/model change or unrelated state-page review occurred, so
unrelated sourceRevision/modelCheck checkpoints remain unchanged.

## Rollout

No migration or product setting. Revert the scoped CI/reporting and
fixture changes to restore the earlier behavior.
Varuas37 added a commit that referenced this pull request Nov 18, 2026
<!-- claude-projects-attribution: {"github_login":"Varuas37"} -->
_Requested by **Saurav** · [project
thread](https://claude.ai/code/project/chan_01UZaufydjNk2K88KGgoAfmr?thread=cmsg_01UZaufydjNk2K88KGgoAfmrX5YyyUXBGeQoMRRr3igVbS)_

**Before:** Of the 11 changes merged to main in the last day, two fixes
had no check in CI. A sidebar row losing its hover fill under its
actions (#1337), or onboarding asking for the vault passphrase (#1340),
could come back unnoticed.

**After:** The conversation stress suite (run by every PR's CI) fails if
either comes back. 2 gaps closed, no issues opened.

## Background

The daily test-gap run reviews what merged to main in the last 26 hours.
For each fix it puts the bug back and checks that a test CI runs fails.
A fix only a local script checks counts as a gap.

## The problem

- **#1337 (row hover).** When the pointer moved from a sidebar row onto
its trailing action (a channel's settings), the row lost its highlight.
Only `shared-controls.mjs --only rows` checked this, and no CI job runs
that script.
- **#1340 (onboarding vault).** The setup window opened the vault's
unlock dialog on its own. The stress `onboarding` step already refused a
vault dialog, but it ran over an unlocked vault. There the old code drew
no dialog either, so the step passed with the bug put back.

## The solution

All in `verification/desktop/scripts/conversation-stress.mjs`:

1. **`channel` step.** Once two channels exist, it finds the channel row
that is not selected (its rest and hover fills differ). It points at the
row, then at its settings beside it, and requires the same hover fill
both times.
2. **`onboarding` step.** It locks the vault through its native session,
as after a restart. Then it opens the setup window, which already
refuses any vault dialog. It unlocks the vault again afterwards.

## How we checked it

| Entry | Bug | What holds it now |
| --- | --- | --- |
| #1353 | A VM creation whose answer was lost never finished | Existing:
2 allocation tests fail with it put back |
| #1351 | A voice call ended when its chat left the panes | Existing: 2
VoiceController V16 tests fail with it put back |
| #1337 | Row hover dropped under its trailing actions | **New**
channel-step check: fails with the CSS put back (`rgba(0, 0, 0, 0), not
oklab(0.985 0 0 / 0.05)`), holds on main |
| #1340 | Onboarding asked for the passphrase | **New** locked vault in
the onboarding step: fails with the fix put back ("the setup window
opened a vault dialog on its own"), holds on main |
| #1350 #1346 #1339 #1332 | Features, copy, and SDK guard naming | Not
fixes |
| #1341 #1338 #1336 #1334 | Crate moves and refactors | Not fixes |

- Stress `--only onboarding,passphrase,channel,stop` in Chromium held
9/9 on this branch. `verification/desktop/scripts/lib/*.test.mjs` passed
698 tests. eslint and prettier are clean.
- Not run: WebKit (it cannot be downloaded in the cloud sandbox).

## Tradeoffs and follow-ups

- The hover check needs an unselected channel row. In the `stop` step
only one channel exists, and it is selected, so the check runs in the
`channel` step.
- The onboarding step briefly locks the shared vault. It unlocks it
again in a `finally`, so later steps see it unlocked.

## Rollout

Nothing special. Test-only change.

---
_Generated by [Claude
Code](https://claude.ai/code/session_018rccRX3nxAcKBWu6gcEXWB)_

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep sidebar rows highlighted over their trailing actions

2 participants